From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?=C3=93scar?= Fuentes Newsgroups: gmane.emacs.bugs Subject: bug#61496: 30.0.50; Default value of icon-title-format Date: Tue, 14 Feb 2023 01:02:04 +0100 Message-ID: <87zg9hqflv.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3970"; mail-complaints-to="usenet@ciao.gmane.io" To: 61496@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 14 01:03:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRin1-0000nx-9t for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Feb 2023 01:03:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRimr-0002Jm-0d; Mon, 13 Feb 2023 19:03:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRimo-0002I0-AB for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2023 19:03:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRimk-0005ZT-DA for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2023 19:03:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRimk-0004bu-4m for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2023 19:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Feb 2023 00:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61496 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167633293517659 (code B ref -1); Tue, 14 Feb 2023 00:03:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Feb 2023 00:02:15 +0000 Original-Received: from localhost ([127.0.0.1]:51997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRilz-0004al-Cg for submit@debbugs.gnu.org; Mon, 13 Feb 2023 19:02:15 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:57556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRilx-0004ac-Q0 for submit@debbugs.gnu.org; Mon, 13 Feb 2023 19:02:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRilx-00029X-L8 for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2023 19:02:13 -0500 Original-Received: from relayout01.e.movistar.es ([86.109.101.201] helo=relayout01-redir.e.movistar.es) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRilv-0005Sn-KZ for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2023 19:02:13 -0500 Original-Received: from sky (73.red-81-39-121.dynamicip.rima-tde.net [81.39.121.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 981711563@telefonica.net) by relayout01.e.movistar.es (Postfix) with ESMTPSA id 4PG1bf3L58zfc11 for ; Tue, 14 Feb 2023 01:02:05 +0100 (CET) X-TnetOut-Country: IP: 81.39.121.73 | Country: ES X-TnetOut-Information: AntiSPAM and AntiVIRUS on relayout01 X-TnetOut-MsgID: 4PG1bf3L58zfc11.AF478 X-TnetOut-SpamCheck: no es spam, clean X-TnetOut-From: ofv@wanadoo.es X-TnetOut-Watermark: 1676937726.81287@W1ji6Whv1ozkxBaiw5QVcQ Received-SPF: softfail client-ip=86.109.101.201; envelope-from=ofv@wanadoo.es; helo=relayout01-redir.e.movistar.es X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255534 Archived-At: AFAIK icon-title-format was broken since long time ago (possibly for several major releases) and it was fixed recently. I propose that its default value should be nil, and interpret that value as "same as frame-title-format". That's why: 1. The case of having an specific frame title when it is iconified seems to me as way less frequent than expecting that the frame keeps the same title. 2. After upgrading to Emacs 29, users that set frame-title-format will see how frames change their title when iconified. 3. There are mechanisms for applying settings or performing actions depending on the title of a frame (KDE Window Rules and scripts based on xdotool, for instance.) For keeping those mechanisms on a working state with Emacs 29, the user must ensure that either it keeps icon-title-format synced with frame-title-format and/or his scripts must be adapted. Without that, any config that depends on the content's of the frame title will be broken (unless the user already set icon-title-format, but it would be surprising if he did, as that setting had no effect until now.) Having a working icon-title-format, in practice, is a new feature, so defining a new default for it shouldn't have any impact. Certainly, it will not have a visible effect compared to recent Emacs releases. However, keeping its current default value may cause confusion and breakage for any user that sets frame-title-format on his config. The required change in code is simple enough: src/xdisp.c | 3 ++- modified src/xdisp.c @@ -13424,7 +13424,8 @@ gui_consider_frame_title (Lisp_Object frame) Fselect_window (f->selected_window, Qt); set_buffer_internal_1 (XBUFFER (XWINDOW (f->selected_window)->contents)); - fmt = FRAME_ICONIFIED_P (f) ? Vicon_title_format : Vframe_title_format; + fmt = FRAME_ICONIFIED_P (f) && !NILP (Vicon_title_format) ? + Vicon_title_format : Vframe_title_format; mode_line_target = MODE_LINE_TITLE; title_start = MODE_LINE_NOPROP_LEN (0); ... plus a trivial doc change on its DEFVAR_LISP and initialization. If this proposal is acceptable, it should be applied to Emacs 29, to avoid putting ourselves on a similar scenario when Emacs 30 is released.