From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability Date: Fri, 24 Feb 2023 15:54:46 +0100 Message-ID: <87zg93866h.fsf@gmail.com> References: <87a614g628.fsf@gmail.com> <83cz60r7hu.fsf@gnu.org> <875ybsfvtj.fsf@gmail.com> <831qmgr17p.fsf@gnu.org> <87wn48ecdz.fsf@gmail.com> <83v8jspgnr.fsf@gnu.org> <87lekodxja.fsf@gmail.com> <83a614p4sh.fsf@gnu.org> <87cz60dus9.fsf@gmail.com> <835ybrpnqj.fsf@gnu.org> <87y1oncz09.fsf@gmail.com> <83r0ufo3uc.fsf@gnu.org> <87356vbf0b.fsf@gmail.com> <83pm9znw0i.fsf@gnu.org> <87lekn9ss3.fsf@gmail.com> <83h6vbntqd.fsf@gnu.org> <878rgn9r6u.fsf@gmail.com> <83edqfnq5u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5787"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61726@debbugs.gnu.org, Eli Zaretskii To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 24 15:55:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVZTl-0001MD-LH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Feb 2023 15:55:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVZTU-0007rT-FJ; Fri, 24 Feb 2023 09:55:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVZTS-0007qV-UV for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 09:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVZTS-0007yb-KF for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 09:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVZTS-0008Jl-Gw for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 09:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2023 14:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61726-submit@debbugs.gnu.org id=B61726.167725049831942 (code B ref 61726); Fri, 24 Feb 2023 14:55:02 +0000 Original-Received: (at 61726) by debbugs.gnu.org; 24 Feb 2023 14:54:58 +0000 Original-Received: from localhost ([127.0.0.1]:36495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVZTO-0008J7-GB for submit@debbugs.gnu.org; Fri, 24 Feb 2023 09:54:58 -0500 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:39462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVZTK-0008IQ-4E for 61726@debbugs.gnu.org; Fri, 24 Feb 2023 09:54:54 -0500 Original-Received: by mail-ed1-f51.google.com with SMTP id f13so55215184edz.6 for <61726@debbugs.gnu.org>; Fri, 24 Feb 2023 06:54:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q9wPH8jeIaJRLe37dWAmryzJBaJyM854NBDPb8cnao8=; b=G7TpXKWOwsCtOTw35GtgA4BLqyYcogjPhu9Cm81chePi7PuMfTiTv62sJEmoUg/IbV UM8jROxlPYR8epEClxCP/gJTTJue/q9Q99QWl7SmYPRLBSTO8OhpPajNC6RzqXLwuPaB OrUkqm+QujeQ1B1OCslYyJASipvu+pqdnzyTafDe0/3x+TmWPrv1FnSOtdCXiYWrPkcl zN4HyeIvsBW8dY5uNCqAdvRopAyqCr7BjiIiqARwzShFFoIZvbF3ULi0LLqSm3WPZdLs Y45qCyiq2HeLZBwsOw6sTuVkoRuwkcjAjPJ1ZAYznaXmmaw0YPHE+qXcuypTbpkT0CA7 sRYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q9wPH8jeIaJRLe37dWAmryzJBaJyM854NBDPb8cnao8=; b=EffmLnArA60MHzJ+F/n296c8bDsp+tPRzxKRrbdtoKdap6serfrgevjcvMIXWRjCvl /1xKjLhvW4+e/I6/FULsbU+6ueY/eh3iyI97KTE5bV/6DsszleXWFai285Gp4ZWYTp/1 pay/mSRjBWbM3g5FOPnxG2uPukbsjGABbhflpxmubQr3HLTNSLuojC9PY+jbgqY6wmOe RqY1QKnDRk99/x9LYPq11i3jKCMnRvsPs3aFpTRChLaOMx1pPZ6Wx0XQYSSyQMKAP+SN jHSeiVavhjEH+vsBQWNc1pn5hPKwBWUZIlr+U4Y6FKAuRO+dehwEWyb4WGz4TIiZmRbT Y6cQ== X-Gm-Message-State: AO0yUKUs1poHyJkXnV+7gEjDY5cwJ0DDNvqYHDxE5FHbE2c6U7iXmzum Pw5jCOMqeWxj9q6eM7PxNOzHBsH5Kd0= X-Google-Smtp-Source: AK7set8VsrhZK8lr79KEP4bkhmnAoC4fQf72GDOdRFkCjc5z0RWXKzTa5UAyJZfwnUVGIwTNznLwGA== X-Received: by 2002:a17:906:4784:b0:8f1:da18:c6ca with SMTP id cw4-20020a170906478400b008f1da18c6camr5906953ejc.3.1677250487939; Fri, 24 Feb 2023 06:54:47 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id bi8-20020a170906a24800b008e8e975e185sm2991573ejb.32.2023.02.24.06.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 06:54:47 -0800 (PST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 24 Feb 2023 13:45:23 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256608 Archived-At: On Fri, 24 Feb 2023 at 13:45, Jo=C3=A3o T=C3=A1vora wrote: > I don't see how this is relevant to the code-point counting problem here, > though. The relevance is in how the offset-counting function should proceed when the buffer is not UTF-8 encodable: - My patch has a garbage-in garbage-out behavior. - Eli made a suggestion he deems more correct, but is more expensive. Since JSON must be UTF-8 encoded for data exchange purposes, I don't see the benefit, and in fact I consider this option just a different choice of garbage-in garbage-out behavior. - A third option is to make the function throw an error. However, if the buffer is not UTF-8 encodable, we already get an error from json-serialize, because it doesn't let you generate invalid JSON: (progn (insert ?" (max-char) ?") (json-serialize (buffer-substring-no-properties (pos-bol) (pos-eol)))) =E2=87=92 Debugger entered--Lisp error: (wrong-type-argument utf-8-str= ing-p " \"\377\"")