From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62599: 30.0.50; Improve ibuffer-diff-with-file Date: Sun, 02 Apr 2023 17:44:09 +0100 Message-ID: <87zg7q2q06.fsf@tcd.ie> References: <8C7E5ED2-1FC7-42F8-AF1F-F4F6024DE033@acm.org> Reply-To: Basil Contovounesios Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38371"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62599@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 02 18:45:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pj0pT-0009iU-JK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Apr 2023 18:45:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pj0pE-0004xS-5D; Sun, 02 Apr 2023 12:45:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj0pC-0004xG-AY for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 12:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pj0pC-0008BU-1V for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 12:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pj0pB-00011a-TR for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 12:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Basil Contovounesios Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2023 16:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62599-submit@debbugs.gnu.org id=B62599.16804538603866 (code B ref 62599); Sun, 02 Apr 2023 16:45:01 +0000 Original-Received: (at 62599) by debbugs.gnu.org; 2 Apr 2023 16:44:20 +0000 Original-Received: from localhost ([127.0.0.1]:42512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj0oV-00010I-Ld for submit@debbugs.gnu.org; Sun, 02 Apr 2023 12:44:19 -0400 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:38859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj0oS-000103-4K for 62599@debbugs.gnu.org; Sun, 02 Apr 2023 12:44:18 -0400 Original-Received: by mail-wm1-f42.google.com with SMTP id l15-20020a05600c4f0f00b003ef6d684102so13039292wmq.3 for <62599@debbugs.gnu.org>; Sun, 02 Apr 2023 09:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1680453850; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rxTJ77Qo97k/QQkcykzaUU/+j7IdvkW3ZUX7nKn7GZY=; b=fwy2w8HvypYeNybveI9RCc5QqRuJ9YZBIRWkXLYgHkBuBuBnQTfn//TyphO6EvFNAA Qoi93HKgU1a8mO8W6CV70FloQAT+vcFD6oKbaRPq8slyeF9EZzMJMthP2fOTZ/kshRIY BrjTG2bQebD0X80QvUYHUY5j/oppzD5FgOpiTZQUG5OqZ+SQCi3AKhffJvVj8SjXijKy LnOkbR2pHCUZPSbkgVxu7LImDW+GaE9cCIQiqgtEBnFo3mk8XVlTmiKDzlK9ZFGzTnXR as4s9L3+EDJRdH0TVL32IideVwgiTm4PDRe4wNgPU88r6l96mtCoKGfROlmKKH52wbmf LGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680453850; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rxTJ77Qo97k/QQkcykzaUU/+j7IdvkW3ZUX7nKn7GZY=; b=ov5mWAT7vqWgNElwneXBcrnEhfk9aVh4qEyVXbsxw7cZcjACkrVdMSRLMIHuFbQTvr qTAHWFmr1+UMw44CT+eCrnoPDqgMDeYo5atNQe5KGTEJWSviYGI90DEyxN0m7BiNoM3U P0sQ9BtImwcJyQSouykAgqPosQy9FpBFrKlA6IKIMXvJ2CKnfJC103dUtgGgRCSUFUh2 74awqOrPo5rwKej4oIdT59eFdjPCmYxwVupBxtKMhFlUvjgqGEYPLTwkguoDjCb4q6st 1Bq5NE+IXRIe9qoAo0zYU0XJxZi5G9joKMuMZMy5AzfbK6edUrylHfvvorUUhenwUaFq x+Zg== X-Gm-Message-State: AO0yUKVqAu491hnYhUH1iOtugfXmf+hhGab0WnLioJHeP8svr2llBSjE oDK5zvJd/nQN40rRBikba2nBJ1oR1N1Vz3pT6BU= X-Google-Smtp-Source: AK7set86V/CCyDiKInT74C+mtBSnFU9PiaPFFrv9pK03OKOPLN9qxazDeqmeWEI82mYcq8u3HhMZ7w== X-Received: by 2002:a05:600c:204:b0:3ea:d620:57a7 with SMTP id 4-20020a05600c020400b003ead62057a7mr26172412wmi.8.1680453850219; Sun, 02 Apr 2023 09:44:10 -0700 (PDT) Original-Received: from localhost ([51.37.77.228]) by smtp.gmail.com with ESMTPSA id v20-20020a7bcb54000000b003ed2c0a0f37sm9476087wmj.35.2023.04.02.09.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 09:44:09 -0700 (PDT) In-Reply-To: <8C7E5ED2-1FC7-42F8-AF1F-F4F6024DE033@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Sun, 2 Apr 2023 10:24:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259118 Archived-At: Mattias Engdeg=C3=A5rd [2023-04-02 10:24 +0200] wrote: > Thank you -- I'm no buffer expert but see no obvious flaws. Thanks for reviewing. I'll wait a few more days for comments before pushing. > `verilog-diff-file-with-buffer` in verilog-mode.el looks vaguely > similar, down to the dodgy unwind-protect, but it has stronger > compatibility requirements so it probably can't use more recent diff > machinery. Oh, that reminded me that call-process has a DISPLAY parameter. I guess in ibuffer-diff-buffer-with-file-1 we're still interested in calling redisplay after diff-sentinel, though: Basil L. Contovounesios [2023-04-01 23:20 +0100] wrote: > + (diff-sentinel (call-process shell-file-name nil t nil > + shell-command-switch command) > + oldtmp newtmp) > + (goto-char (point-max))) > + (redisplay))) I opened https://bugs.gnu.org/62620 for the Verilog case. Thanks, --=20 Basil