From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master Date: Mon, 10 Apr 2023 10:11:23 +0100 Message-ID: <87zg7ggkzo.fsf@tcd.ie> References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> <875ya4k5t6.fsf@tcd.ie> <87r0ssm9ra.fsf@gmail.com> Reply-To: Basil Contovounesios Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5059"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , 62741-done@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 10 11:12:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plnZl-00018w-9w for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Apr 2023 11:12:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plnZH-0003qM-VU; Mon, 10 Apr 2023 05:12:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plnZE-0003ps-9l for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 05:12:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plnZD-0007D6-U3 for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 05:12:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plnZD-0003TF-5c for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 05:12:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Basil Contovounesios Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Apr 2023 09:12:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62741 X-GNU-PR-Package: emacs Original-Received: via spool by 62741-done@debbugs.gnu.org id=D62741.168111789513279 (code D ref 62741); Mon, 10 Apr 2023 09:12:03 +0000 Original-Received: (at 62741-done) by debbugs.gnu.org; 10 Apr 2023 09:11:35 +0000 Original-Received: from localhost ([127.0.0.1]:34327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plnYl-0003S1-DV for submit@debbugs.gnu.org; Mon, 10 Apr 2023 05:11:35 -0400 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:52105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plnYh-0003Rm-5e for 62741-done@debbugs.gnu.org; Mon, 10 Apr 2023 05:11:34 -0400 Original-Received: by mail-wm1-f43.google.com with SMTP id l16so2005882wms.1 for <62741-done@debbugs.gnu.org>; Mon, 10 Apr 2023 02:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1681117885; x=1683709885; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=swRrecGujgS9g35mApFuFp0ImVh0sw66L+PBD6VkUxM=; b=RJF6Iy4NLKFlu1XnkOywQyRsPR7wG48vInSPTJcZc+p712aTZrbMyqTJuEgMTTJ8it Lmy3Etb9A3IYlcD+MqavMAscLE87VJhSPzMqhIouOuudlY1UExtoDXjxtPC+KM1OSgw6 uVuo6KUIr9HAl67vJNHwmPuEucQBH0IAxRCR4lZfdeoq1lATsy252zIgorzoJgZIz8Ic gunehp98ZGEl2N5nNhG060NUvl/yU9kcNWzHjuJcwaBbdBp2zubCQD7YwyoK3SxLMDby R+UcsdCzo5vo8phv9tL+ep++nh/LSiJv5Anav4Xc34KCtJrZhMJjckbMsE94YxOBnsgU SnEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681117885; x=1683709885; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=swRrecGujgS9g35mApFuFp0ImVh0sw66L+PBD6VkUxM=; b=FuoUF1McQ7qK9Hfh7P1u8PDCjoDUdiQqOHieO8oKEBJQRzGLlKJLMvXEBOdb3l+qs3 oBpQevuKOxA8834Z2sO1xtwtJOUArPEdNQzCqlcCXF3IXqQWyiHjrNSKX7E2hUiLx0TP nsT/xuQaHiTrCsw++SfoY3o2SffT1tl33EexhLdC2bYHRV/nYQCaoESPdYlGqOD8/ykE 0f17Hy91MP+d/oUqQW/AQvdgVvgfGibqzCm/LLS1/38ZkX6XB0GD2uim0zLa0GyAmWOZ sZ48OgIfOsRAookXiemnnrut4RrhHHby4P0KL4sk9QkTFHS1adpXJiX9MlEJr9sHdd1p +ErA== X-Gm-Message-State: AAQBX9dgGFNK4aIJUBZ908Ngw80Wh4LO0DdKrvl4wzxbciqYODAVJP7j 8qAzzX276qg7WJ2mpm/AxHFdrQ== X-Google-Smtp-Source: AKy350ZbxBkbuKT3dUU/lMr/Q8zSOa2lY7KEGOb+FZ+gwPjR2AtAtluKUox2WEVBPMV8RryqjmrCZg== X-Received: by 2002:a1c:7214:0:b0:3ed:b56c:9496 with SMTP id n20-20020a1c7214000000b003edb56c9496mr6608735wmc.31.1681117885327; Mon, 10 Apr 2023 02:11:25 -0700 (PDT) Original-Received: from localhost ([109.78.216.163]) by smtp.gmail.com with ESMTPSA id x10-20020a05600c21ca00b003edf2dc7ca3sm13038689wmj.34.2023.04.10.02.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 02:11:24 -0700 (PDT) In-Reply-To: <87r0ssm9ra.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 10 Apr 2023 09:17:29 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259556 Archived-At: close 62741 30.1 severity 62741 minor quit Jo=C3=A3o T=C3=A1vora [2023-04-10 09:17 +0100] wrote: > Pasting the backtrace here for Dmitry to have a look. > > Test eglot-test-eclipse-connect backtrace: > string-match("\0" nil 0) > split-string(nil "\0" t) > project--vc-list-files("/tmp/eglot--fixturernYTOR/project/" Git nil) > #f(compiled-function (dir) #)("/tmp/eglot-= -fixturernYTOR/project/") > mapcan(#f(compiled-function (dir) #) ("/tm= p/eglot--fixturernYTOR/project/")) > #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/eglot--fixturernYTOR/project/")) > apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/eglot--fixturernYTOR/project/") nil) > project-files((vc Git "/tmp/eglot--fixturernYTOR/project/")) > > It would seem that the problem here is there are no files versioned yet, > so this expression in project--vc-list-files > > (apply #'vc-git--run-command-string nil "ls-files" args) > > Returns nil.=20=20 > > But I cannot reproduce this locally. It's easy to reproduce the backtrace without Eglot, and it happens both on master and emacs-29. From emacs -Q: (let ((dir (make-nearby-temp-file "my-" t))) (unwind-protect (let ((default-directory (file-name-as-directory dir))) (make-directory ".git") (make-empty-file "file") ; Optional. (require 'project) (project-files (project-current))) (delete-directory dir t))) C-x C-e Debugger entered--Lisp error: (wrong-type-argument stringp nil) string-match("\0" nil 0) split-string(nil "\0" t) project--vc-list-files("/tmp/my-VHbIUg/" Git nil) #f(compiled-function (dir) #)("/tmp/my-VHb= IUg/") mapcan(#f(compiled-function (dir) #) ("/tm= p/my-VHbIUg/")) #f(compiled-function (project &optional dirs) #)((vc Git "/tmp/my-VHbIUg/")) apply(#f(compiled-function (project &optional dirs) #) (vc Git "/tmp/my-VHbIUg/") nil) project-files((vc Git "/tmp/my-VHbIUg/")) > I'll leave it up to you, Basil, to decide whether to close or leave this > bug open. Closing, since the difference between master and emacs-29 materialised in the context of Eglot. If Dmitry thinks project-files is doing something unexpected, we can open a new ticket if necessary. Thanks, --=20 Basil