From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63260: 29.0.90; Regression installing/activating packages without autoloads Date: Thu, 04 May 2023 18:28:47 +0200 Message-ID: <87zg6kysao.fsf@tcd.ie> References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> Reply-To: Basil Contovounesios Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29706"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63260@debbugs.gnu.org, Philip Kaludercic To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 04 18:30:41 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pubqp-0007H9-SO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 May 2023 18:30:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pubqM-0001KK-O2; Thu, 04 May 2023 12:30:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pubqG-0001Jq-Np for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 12:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pubqG-000090-BQ for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 12:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pubqG-00010p-1A for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 12:30:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Basil Contovounesios Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 May 2023 16:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63260 X-GNU-PR-Package: emacs Original-Received: via spool by 63260-submit@debbugs.gnu.org id=B63260.16832177453746 (code B ref 63260); Thu, 04 May 2023 16:30:03 +0000 Original-Received: (at 63260) by debbugs.gnu.org; 4 May 2023 16:29:05 +0000 Original-Received: from localhost ([127.0.0.1]:51932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pubpI-0000yM-LK for submit@debbugs.gnu.org; Thu, 04 May 2023 12:29:05 -0400 Original-Received: from mail-pl1-f173.google.com ([209.85.214.173]:49313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pubpF-0000xi-K9 for 63260@debbugs.gnu.org; Thu, 04 May 2023 12:29:02 -0400 Original-Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1ab05018381so6108075ad.2 for <63260@debbugs.gnu.org>; Thu, 04 May 2023 09:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1683217735; x=1685809735; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ByT1v349SgCMbgHik0jgGfDpSJO4/jDaZJHxUpjdIio=; b=FpB/cFhLy4ksQ4Zm5AK6KW247waCC/ncfjK6y2C9Ozcwvt2RwDoLWeZTx9M31sE6l8 1DuyBvNVraeO4cZus7w1wb4P9UlJ25Cil40fAQFTtQvmCRL7IjwEsojgS1sHpYIsLB50 IkA0OMAhyGZvhAj+cEqGHZZJ/QCNdLiJ4yKlf3OkdTRsmhUOuyhfh+x/Z9ak/X4JwHpW WW2ZOqzumZft9J/Y/W9UDl52wlLLNSvO/kxFbgKg5Pv8f507YaPBiFNl0FD4a7q0GylO sdBWnsk79b9jtG6ELT1oEMI6MucExXy7HFCvn38s8sXH2Wtkt0+H88J2wUygsRHMyf// VzCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683217735; x=1685809735; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ByT1v349SgCMbgHik0jgGfDpSJO4/jDaZJHxUpjdIio=; b=GrgnbD/A4szyH/cp5vYcJhFHGN4CLzoqKJ9MnLjj1T9ZX+5MnqnpE2Yd8g4zaclI0o liCDK07/jK+LDi/4WvAUpcO6wP9uB2t9C8oqNamqEHkk7zChR91CUG4CsJhCf9znTCkN EAf/HMBSujhDEe1araWfdUxh+6LzTzb06FE6hr7GCrN2pNOv8S41hegGZG7jvXZvw+n/ MEanZD82FJzraKLwCdc5fGu5uTd3114t4GGjFSC3gV3EbAqLkjDx7RSIlmh3IsOkMglJ LfdXmmF8t0kahvDZbL5o/uv20EOzpxA9q+RLzeUYtdwV7zerF1McQFyTBGA8EFKIkzu7 m09w== X-Gm-Message-State: AC+VfDymqDQjNAnQcjJ3p6QNjUM2/RakV3+SR3NHqDdRGDpiCF32lxrf EGiEiOaDHkPS0CzwZWaR9aYCZw== X-Google-Smtp-Source: ACHHUZ7qxQ2vcFXn7xn5m+zsbQEn3SFcK9EEMhSbLAhWmHt1gXu26fY9p4QDibcH3sq+PHS0b3VAWA== X-Received: by 2002:a17:902:b10e:b0:1a0:6690:d3d1 with SMTP id q14-20020a170902b10e00b001a06690d3d1mr4065168plr.6.1683217735393; Thu, 04 May 2023 09:28:55 -0700 (PDT) Original-Received: from localhost (20014C4E1E52280005DF6EAF1CEC5CC5.dsl.pool.telekom.hu. [2001:4c4e:1e52:2800:5df:6eaf:1cec:5cc5]) by smtp.gmail.com with ESMTPSA id b11-20020a170902d50b00b001a67a2dae7fsm15314192plg.266.2023.05.04.09.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 09:28:54 -0700 (PDT) In-Reply-To: <87ttwsnn59.fsf@gmail.com> (Robert Pluim's message of "Thu, 04 May 2023 17:15:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261030 Archived-At: Robert Pluim [2023-05-04 17:15 +0200] wrote: >>>>>> On Thu, 04 May 2023 12:15:15 +0200, Basil Contovounesios via "Bug re= ports for GNU Emacs, the Swiss army knife of text editors" said: > > Bug> This change: > > Basil> Prevent generating empty autoload files > Basil> dd21003878d 2023-04-30 18:42:58 +0200 > Basil> https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Ddd2100387= 8d > > Basil> seems to have reintroduced the following issue: > > Basil> https://lists.gnu.org/r/emacs-devel/2022-06/msg00563.html > > Basil> First start Emacs 29 (or 30) with a clean slate: > > Basil> $ cd "$(mktemp --directory)" > Basil> $ export HOME=3D"${PWD}" XDG_CONFIG_HOME=3D"${PWD}/.config" > Basil> $ emacs > > Basil> Then try to install the sicp package (which lacks autoloads) f= rom MELPA: > > Basil> 0. C-x b RET > Basil> 1. (setq package-archives '(("melpa" . "https://melpa.org/pack= ages/"))) > Basil> C-x C-e > Basil> 2. M-x package-install RET sicp RET > Basil> 3. C-h e > Basil> 4. C-M-S-v > > Only when `package-quickstart' is non-nil, right? No, this is in an empty user-emacs-directory, i.e. with the default package-quickstart =3D nil. Besides, package-quickstart does not come into play during package-install AFAICT. > How about this: > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 0919ce34448..42d47ed259c 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -4498,7 +4498,8 @@ package-quickstart-refresh > (pfile (prin1-to-string file))) > (insert "(let ((load-true-file-name " pfile ")\ > \(load-file-name " pfile "))\n") > - (insert-file-contents file) > + (when file > + (insert-file-contents file)) This does not address the file-missing error during package activation, but it allows a subsequent package-quickstart-refresh to complete (albeit with a warning in a *Compile-Log*): Compiling file /tmp/tmp.6cdF8paE0K/.emacs.d/package-quickstart.el at Thu May 4 18:24:07 2023 Entering directory =E2=80=98/tmp/tmp.6cdF8paE0K/.emacs.d/=E2=80=99 package-quickstart.el:4:2: Warning: Empty let body due to the following generated contents of package-quickstart-file: (let ((load-true-file-name nil)(load-file-name nil)) ) Thanks, --=20 Basil