From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Mon, 29 May 2023 16:43:00 +0200 Message-ID: <87zg5nb3m3.fsf@gmail.com> References: <87a5xrzsph.fsf@stebalien.com> <83pm6nlhll.fsf@gnu.org> <87v8gfmqyt.fsf@gmail.com> <83ilcflbua.fsf@gnu.org> <87mt1rmjjg.fsf@gmail.com> <83v8gfjnzj.fsf@gnu.org> <87edn3mbr3.fsf@gmail.com> <83mt1rjg69.fsf@gnu.org> <875y8fm7x7.fsf@gmail.com> <83lehbjdjd.fsf@gnu.org> <87wn0vkqn1.fsf@gmail.com> <83jzwvj94x.fsf@gnu.org> <87h6rw8y82.fsf@gmail.com> <83353gipww.fsf@gnu.org> <87edmzto0l.fsf@gmail.com> <83ilcbgrxo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21687"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 29 16:44:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3e6a-0005S4-V7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 May 2023 16:44:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3e6O-0000hD-Vf; Mon, 29 May 2023 10:44:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3e6M-0000gP-PJ for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 10:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3e6M-00023S-H5 for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 10:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3e6M-0001Dx-Cy for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 10:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2023 14:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.16853713894628 (code B ref 63731); Mon, 29 May 2023 14:44:02 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 29 May 2023 14:43:09 +0000 Original-Received: from localhost ([127.0.0.1]:58708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3e5U-0001CZ-Ti for submit@debbugs.gnu.org; Mon, 29 May 2023 10:43:09 -0400 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:46289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3e5T-0001CN-O4 for 63731@debbugs.gnu.org; Mon, 29 May 2023 10:43:08 -0400 Original-Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3f6dfc4e01fso34936845e9.0 for <63731@debbugs.gnu.org>; Mon, 29 May 2023 07:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685371382; x=1687963382; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=X0dOOmKkO2Et+XLtNacZH1zNNhSgNsgybZmmCYTmbBQ=; b=kLHV7DqI64zts4dCXd9DSWn0mxFPh4Lkq+ooxjbfHQgYta0EPaCktIC5R5UbQFRIBC PQlzzJlu53KwyZ6zd5HVaJ8Zd6IcyAhdcwHcJcXTflEMdFIJ3yxXJzRwIt2ADzb3pX2Q 5pTWEbbvxXD4mmO3rHrK6T5QYHzxCXp7sdq4LNErPUA6d2DS1kslwGMmwmfgrTC0nHXO zMRStNmfpuWog02YtumHYOYAk0mKoUpNAfez04GVH6fCH9vgEXP89s5Hi/sPwTy7zGzU qZohl3tocNkdal025uX6Ki8ubWlGudEoQ0cSNm8YvL9q2a0IEwoHQxGpcmuAcgUIirsg MHDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685371382; x=1687963382; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X0dOOmKkO2Et+XLtNacZH1zNNhSgNsgybZmmCYTmbBQ=; b=f5haRNh5HfWXJyLhqcoDpBhrIsAQtvvlm98bfKQqqZIi//2T0iFqzHWNiONp/1ctu+ 71FIQUQl6pEXObKxdffk9k8p1uic1T13omvtrHmu5iAO6HNua9QYRPYMIU0DKxfxidDH 1Z3kTHh4cbnHHIDYAwvuQJzoRFko1RqmWIsGy7T32IvPEdOk41JTqNxFUtdXllWjdxxD a6fyTGAWs67yKNl4HSb2IxOn3YSX6WTAm+tRPg6uUlEEwUWs/a8KSiYfkAFm9F3m2Q7j pbklIdm/sq5iTEjAnTR40GEXPM/S5Svvhs9nrdclx1bOHFIh2I2qjCqdTrp/2wzw8EhU OLKA== X-Gm-Message-State: AC+VfDx7ZyqdF78NsubXS+GM5+DX/moNpCaAjsFB3odCDHFLHR2p/2uH SyGhLsO71qXik2CXJKYsE2LGc9Y5sCk= X-Google-Smtp-Source: ACHHUZ7VytKIUNoqb3exg/5Kcq17zd+irOPIZwZYvaq1tM00x70c2OtObJMb2mZrRgt4m00NksAEtQ== X-Received: by 2002:a05:600c:b54:b0:3f4:2174:b28a with SMTP id k20-20020a05600c0b5400b003f42174b28amr9493566wmr.15.1685371381708; Mon, 29 May 2023 07:43:01 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id h8-20020a1ccc08000000b003f709a7e46bsm449166wmb.46.2023.05.29.07.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 07:43:01 -0700 (PDT) In-Reply-To: <83ilcbgrxo.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 29 May 2023 16:58:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262585 Archived-At: >>>>> On Mon, 29 May 2023 16:58:43 +0300, Eli Zaretskii said: >> display: composed to form "=F0=9F=91=8D=EF=B8=8F" (see below) Eli> This is not what I see. I didn't use the above set-char-table-ran= ge Eli> expression literally, but instead started "emacs -Q", and then Eli> evaluated in *scratch*: Eli> (set-char-table-range Eli> composition-function-table Eli> #xFE0F Eli> '(["\\c.\ufe0f" 1 compose-gstring-for-graphic])) Eli> After that, the sequence U+1F44D U+FE0F displays as a single glyph, Eli> and there's no thin space after it. What am I missing? Is this Eli> somehow specific to ftcrhb font driver or something? It=CA=BCs a single glyph, but that glyph contains a thin-space. I used this to check, the second 'a' is slightly offset =F0=9F=91=8D=EF=B8=8Fa =F0=9F=91=8Da This persists if I disable harfbuzz, and it behaves the same on macOS Eli> You are saying that the entry in composition-function-table for Eli> U+1F44D (and other similar characters) is used in preference to the Eli> entry for U+FE0F that follows it, even though there's no U+1F3FB Eli> etc. after it to "steal" the composition? Did you try stepping Eli> through composite.c to see whether and why this is the case? Right. It looks the the FE0F entry is ignored. I=CA=BCve not ventured into composite.c yet. >> I can change the emoji-zwj.awk script to add CHAR+FE0F for all emoji, >> unless someone knows how to fix composition to do the right thing >> here. Eli> I think we need first to understand the issue at hand better. The= re's Eli> more here than meets the eye, I think. Absolutely Robert --=20