From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vladimir Sedach Newsgroups: gmane.emacs.bugs Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Date: Mon, 03 Jul 2023 11:03:37 -0600 Message-ID: <87zg4dsz9y.fsf@t510.orion.oneofus.la> References: <87pm5h4iy1.fsf@t510.orion.oneofus.la> <83h6qtw3tq.fsf@gnu.org> <87wmzp2e0d.fsf@t510.orion.oneofus.la> <831qhwx5qf.fsf@gnu.org> <87zg4k76es.fsf@orphne.orion.oneofus.la> <83mt0jvmfu.fsf@gnu.org> <87r0pva66g.fsf@t510.orion.oneofus.la> <834jmrv3p6.fsf@gnu.org> <87o7kz9wej.fsf@t510.orion.oneofus.la> <83wmzmuaq7.fsf@gnu.org> <87wmzmb5fl.fsf@t510.orion.oneofus.la> <83a5wita0p.fsf@gnu.org> <87ttuqax6d.fsf@t510.orion.oneofus.la> <835y75tsn7.fsf@gnu.org> <87r0ps7v92.fsf@t510.orion.oneofus.la> <831qhqq0kf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36234"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.15; emacs 28.2 Cc: 64311@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 03 19:04:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGMyL-0009Bz-MS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Jul 2023 19:04:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGMy5-0006VG-5v; Mon, 03 Jul 2023 13:04:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGMy2-0006Uz-V0 for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 13:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGMy2-0005a5-FS for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 13:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qGMy1-0007Qc-Ts for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 13:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vladimir Sedach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2023 17:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64311-submit@debbugs.gnu.org id=B64311.168840382528526 (code B ref 64311); Mon, 03 Jul 2023 17:04:01 +0000 Original-Received: (at 64311) by debbugs.gnu.org; 3 Jul 2023 17:03:45 +0000 Original-Received: from localhost ([127.0.0.1]:34390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGMxl-0007Q2-2s for submit@debbugs.gnu.org; Mon, 03 Jul 2023 13:03:45 -0400 Original-Received: from robust-software.ca ([174.136.98.50]:4820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGMxh-0007Ps-Ni for 64311@debbugs.gnu.org; Mon, 03 Jul 2023 13:03:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=virgo1; bh=bSWiT9RDyfDwo n6wLre6Rq19u61gIB2Ea6SP4moxFFQ=; h=date:in-reply-to:subject:cc:to: from:references; d=oneofus.la; b=eNI2dWLT/k0PpTbVL+Z5jSRk6AzhJo52EVyi1 o1hF7XdFXMGeGzWunn6QsQkgIqe0WO4bViUovgL9jgWaYYK2xa2uGiey1VsTbdi6sfzBwn UPerUMXLkpSiF8vjYhW/Sm0yD//wsoLqeZCEP8992DiTD97P1YduCX3DDe8Xypo4= Original-Received: from t510.orion.oneofus.la (node-1w7jra28qzk6xrruvejpf19h4.ipv6.telus.net [2001:56a:f913:3c01:702a:1815:9e78:938]) by virgo1.oneofus.la (OpenSMTPD) with ESMTPSA id 416f637f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 3 Jul 2023 10:03:39 -0700 (PDT) In-reply-to: <831qhqq0kf.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264537 Archived-At: Eli Zaretskii writes: > I think the alternative patch below solves all those issues. If you > disagree, pleased tell what left-over problems you see after applying > that patch. How should defvaralias be used? On the master branch I count 74 defvaralias declarations in lisp/, excluding lisp/obsolete/ (there are some more generated dynamically by org-babel). Of these, 73 are used for variable rename refactoring (the 1 other use is vhdl-last-input-event as a compatibility shim for xemacs). There were 2 things that to me looked wrong with the existing defvaralias declaration in shell.el: 1. As far as I can tell, every declaration aside from shell.el is of the form (defvaralias old-variable new-variable). The one in shell.el is the other way around. 2. There are only 2 occurrences where the old variable is still referenced in Emacs code: erc-join-buffer and shell-dirtrackp Isn't the point of defvaralias in removing uses of the old variable name from Emacs code? -- Vladimir Sedach