From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Tue, 04 Jul 2023 00:03:05 +0000 (UTC) Message-ID: <87zg4cpmpz.fsf@catern.com> References: <3eea0a7dff2915453876fc3a2b628886c78a4d4b.camel@laposte.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33305"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: frederic.giquel@laposte.net, Gregory Heytings , acm@muc.de, yantar92@posteo.net, monnier@iro.umontreal.ca To: 60467@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 04 02:04:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGTWn-0008Ob-Oc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jul 2023 02:04:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGTWY-0005dh-03; Mon, 03 Jul 2023 20:04:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGTWV-0005by-2u for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 20:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGTWU-0003FQ-GJ for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 20:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qGTWT-00021m-U3 for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 20:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jul 2023 00:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.16884289947730 (code B ref 60467); Tue, 04 Jul 2023 00:04:01 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 4 Jul 2023 00:03:14 +0000 Original-Received: from localhost ([127.0.0.1]:34667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGTVi-00020c-IX for submit@debbugs.gnu.org; Mon, 03 Jul 2023 20:03:14 -0400 Original-Received: from s.wrqvtzvf.outbound-mail.sendgrid.net ([149.72.126.143]:61826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGTVf-00020M-TH for 60467@debbugs.gnu.org; Mon, 03 Jul 2023 20:03:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=Y1iPa+RFwyfVWgeXTKihAbyGaIUleKfNQ3KT56tghSM=; b=Zwul9pi++jjBsNxWZ67Gc+FPhgXg/BxGd1lexYabrlli5lmykF9sxTaJgUgLTCytuW0j aTmvaadpXPWWHlbXb6s5RW0QA57D+tQcw1/y4x4UfZfuRBotpW3XBNNi9OlqBfoBgCWCPt lTOaaU7Izcfb44VHQJaPKeqq6HTc2TMqzM1X0qHGb1/ltZntptM2zy4j8vgZW8QgzanDeU hmNl0XUj1Ri6Q1hMQS5xFEwRMahLIvp2O8Ies3sfzdSnksj2uDJR3kUuPbfBIk3JTkB+/0 MJccplgtyjdnLjtNlwev6VpPG7VpaB0osiD6I5z6x/AO7sb2XPn74OpsZ8i8bz5g== Original-Received: by filterdrecv-8684c58db7-nkctk with SMTP id filterdrecv-8684c58db7-nkctk-1-64A361B9-6E 2023-07-04 00:03:05.757637325 +0000 UTC m=+4667077.930869525 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-5 (SG) with ESMTP id ni54xzRZQZyBv1pJNL_uRA Tue, 04 Jul 2023 00:03:05.485 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=debbugs.gnu.org Original-Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 152316250F; Mon, 3 Jul 2023 20:03:04 -0400 (EDT) In-Reply-To: <3eea0a7dff2915453876fc3a2b628886c78a4d4b.camel@laposte.net> ("=?UTF-8?Q?Fr=C3=A9d=C3=A9ric?= Giquel"'s message of "Thu, 22 Jun 2023 21:27:25 +0200") X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbKJjCz6/0we8jsyJIY1M7/8f+5C5TU2WoK5QibMizDDw5A405VBJT/Qv/0SGrV/ynnhsW44edP6p+yyNlAw9kVU4775MdbhiB/Nr0Grqy+GVp6cuKslZCOUTq2+RTuaAMVecu/dQ48XnR2TBxVlf7SUs94zuhQtq+1mNDxmj8mXQA== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264553 Archived-At: Incidentally, this bug has an easy reproduction in emacs -Q on Emacs 29 and before: (with-temp-buffer (insert "foo") (setq-local buffer-undo-list nil comment-start ";") (comment-line 1)) which produces the "combine-change-calls: buffer-undo-list broken" warning. This is easy to trigger in practice: simply open a file already containing text, and comment a line as your first action. Anyway, this was also fixed by Stefan's change 977630b5285809a57e50, * lisp/subr.el (combine-change-calls-1): Fix bug#60467 (I send this email just because I spent some time tracking this down only to find it was already fixed. Maybe my smallish reproducer will somehow be helpful to someone...)