From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65193: 29.1.50; SET_FRAME_ICONIFIED can cause Lisp evaluation inside read_socket_hook. Date: Thu, 10 Aug 2023 21:03:31 +0800 Message-ID: <87zg2zqcbg.fsf@yahoo.com> References: <87pm3vs3qf.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12740"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65193@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 10 15:04:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qU5Km-00036e-OA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Aug 2023 15:04:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qU5Ke-0007d4-4j; Thu, 10 Aug 2023 09:04:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU5Kc-0007Yf-Mr for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 09:04:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qU5Kc-0002sI-ES for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 09:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qU5Kc-0000q0-1N for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 09:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Aug 2023 13:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65193 X-GNU-PR-Package: emacs Original-Received: via spool by 65193-submit@debbugs.gnu.org id=B65193.16916726303202 (code B ref 65193); Thu, 10 Aug 2023 13:04:02 +0000 Original-Received: (at 65193) by debbugs.gnu.org; 10 Aug 2023 13:03:50 +0000 Original-Received: from localhost ([127.0.0.1]:41671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU5KQ-0000pa-7K for submit@debbugs.gnu.org; Thu, 10 Aug 2023 09:03:50 -0400 Original-Received: from sonic313-56.consmr.mail.ne1.yahoo.com ([66.163.185.31]:35571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU5KM-0000pL-Vk for 65193@debbugs.gnu.org; Thu, 10 Aug 2023 09:03:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691672621; bh=PG9urr07TalLtztmzeJh8BlXFuf4bwhzB4y/5dw3v9g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Amz25MDEbAvAxBmSoNe6Y+yBdHsETPXf54yW5GSZf5nnxRq6XB1eyAJm0lTxi3SX5QO7AYnf1jZZJFbByA1GSJPSg/je8WyO6l5UuLW8cl7NVmZAsAGuJCGqH6+nOCVHw/TzdUS97Z64QXkQenmDhWZK+FWMOWbux7v+M9KiTaLIWiKCc7l+URQ5vaZI9cemShBCf+7Z40YdiZ4DL2W4W7ELVWHdh0zTMiNv7V/XNd95mr/QbrSe+1CO5ODV2fpDGa/lUEYcwW3qMOu8nqfUF2KBimu8E+Bp4yuo/MeL5fDOuKmKFe/IlrcLcO5HwVBz9uPVtTRA90THNjuvlJXCtw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691672621; bh=KzFoPVcxDffkliGNc0L/o1ZlZuS2Vh2mhqmlfYyRiOz=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=tFDclWf6Ia0ZtH4OYpC7ebV/ct4saf7MQcfKNl1iDbI7NpkBk3XxshLSKv/SwCPOzX6EQnROEXR5y8WTwMV/mW4o1POK5RxkV3IANLdCStN/LvPzQURc3HYPfjTR4apuyxttFpHyk9v4o1pWNPAVUrueGFivR4cEYMmlckYWA0WQzHsBWZnCaGvRawRzdcbj4nInXScH7CyzJxmSH/3vTRal2mfE7gkWSAUrQQDN+fIiNACYF+0Xw6T/TFXsIOutb0HTy1Cit8HWuh/TySoMFdZ9BD6elZxfWZJH7hRvLjcMl4KDHhwm6kKe/qAVAuJLyNB1ER4AO2Tue3B3Xkx/9A== X-YMail-OSG: hZCwV2UVM1kPLdArFMZRkK1iwW.SmaWaQmGLqm7Q_MNKxAWGn1VS1mJzHrM1KMF T2y2JynIVJDOocW5gtXBuTaBwHMIKJMvMqvAjKXYNnl64Kvoy_ppbj.5Cj0T6EDveOXm5VAXyYGu oj15uS2lidBJaUdyLPiFNA2RMKCQgjctiYMPmAZKsDA8vwMkqzfNpS1NB6M0Q6bbNYJZ.vmFiyhe F_s3wrsOkSBQz7A7YgiE_mMfmIGmRLy5joqSPqBIPogLRuwbFkBXhnXWQd.e6ZdhM_p9xtYkFex8 L_vu4eXWVJtzK5IDEJitMmkABM5tQ92ASxxUmo.MswS4dcjqzepnkqrPlLdFeCApB262ZrDotmSJ jRkqVSJZ0tZ9dWslJqCl7sTtnOq.okS3y6ay5efLGww.begVG.GoMxB8NY06WgxAPq2SIY8moXaM 1Dvu7bm5e9jEHskOnh65bS77lb_Vvbd48.fVHlBamv4ZongfRck_RDslbnSSyno_W08N1WO15NDI pc6g61kRVaOEusf2nS0OmDrXkT24mI47UR8B1.F7SARgCNfn7WGjjVCAJSe_8IfzOBp__IZ69uqU xmvgXi7wTXn.CVqaDriyWDx1s61NcD99Hrr70MY3TCkBPPmo3ZKPN_LnTbyhQZr1vvJtPyX536KU 3ClwQqkThb5oD_tkdFkz8rt0UadiGp_2faTxJ43Npn8gaMWvSdALdxuVmOBhRzf_.1RRvn28ELqY owsPfpksaJmNjCAc0zr4ZWHwkrDqMOJswzkcrFx1yg6iJ4PW4aqVjWMqBKzJzWsvUWRFrn5nsjpU fgGzpsbBd1B.x_PJBxEANVgQNrnWFPsJBRX20HWi0A X-Sonic-MF: X-Sonic-ID: fc0a4d8f-cc1e-481f-a7b5-065da9fecf71 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Thu, 10 Aug 2023 13:03:41 +0000 Original-Received: by hermes--production-sg3-69654d8bd-d8v2r (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 9936c7bc3d8c88a8f5b670d5b4775060; Thu, 10 Aug 2023 13:03:35 +0000 (UTC) In-Reply-To: (YAMAMOTO Mitsuharu's message of "Thu, 10 Aug 2023 18:21:26 +0900") X-Mailer: WebService/1.1.21695 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267129 Archived-At: YAMAMOTO Mitsuharu writes: > To my understanding, the Lisp evaluator is not reentrant, and thus > Lisp evaluation inside read_socket_hook, which can be called from > fairly arbitrary places via unblock_input/maybe_quit, causes > hard-to-reproduce, spontaneous crashes. Only if that Lisp is permitted to signal out of those arbitrary places, since we no longer call read_socket_hook directly from signal handlers. Mode line format evaluation catches all non-local exits, AFAIK. > That's really surprising. I've once heard we shouldn't do that. Is > that changed? I think so, see above. > My understanding is that GC can only be triggered by eval_sub or > Ffuncall calls (except explicit garbage_collect calls), but not by > Lisp object allocations, for example. Avoiding Lisp evaluation inside > read_socket_hook also means avoiding GC inside read_socket_hook. Hmm. But given that we haven't avoided Lisp evaluation within read_socket_hook for some time now, that's still a moot point.