From: sbaugh@catern.com
To: Gregory Heytings <gregory@heytings.org>
Cc: Spencer Baugh <sbaugh@janestreet.com>,
Philip Kaludercic <philipk@posteo.net>,
64619@debbugs.gnu.org, martin rudalics <rudalics@gmx.at>,
Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Subject: bug#64619: [PATCH] Add toggle-window-dedicated command
Date: Sat, 19 Aug 2023 21:47:39 +0000 (UTC) [thread overview]
Message-ID: <87zg2mpuv9.fsf@catern.com> (raw)
In-Reply-To: <387ee04aa97c3477c4f3@heytings.org> (Gregory Heytings's message of "Sat, 19 Aug 2023 20:37:31 +0000")
Gregory Heytings <gregory@heytings.org> writes:
> I agree with Drew here: strong dedication would be a better default.
> The fact that the window was weakly dedicated and that I could switch
> to another buffer without any warning or confirmation surprised me
> when I tried your patch, hence my reaction. Dedicating a window to a
> buffer is somewhat like making a buffer read-only, and I guess "weak
> read-onlyness" would be surprising to most users.
Maybe it's surprising to Emacs developers, but I think strong dedication
would be more surprising to users.
In fact, I initially used strong dedication in my patch. But I found it
annoying that I had to turn off strong dedication explicitly if I wanted
to switch to another buffer. That's what made me realize that weak
dedication was better.
Strong dedication would make sense if C-x b used display-buffer. Then
it would be very helpful: C-x b in a strongly dedicated window would
automatically use another window, which would be nice for muscle memory
since you could just use C-x b regardless of what window you're in. But
C-x b doesn't use display buffer, and instead just errors when the
current window is strongly dedicated, which I think is fairly useless
behavior; the user reaction is almost always going to be annoyance
followed by C-x w d and C-x b again. So I think weak dedication is
better. (Or making C-x b use display-buffer?)
>>> 2. I would not bind it to the "d" key but to the "!" key: ISTM that
>>> toggling window dedication is not such a common action that it
>>> needs a letter key binding.
>>
>> It's not common at the moment, but I expect some users will use this
>> command quite frequently. Also the C-x w prefix is pretty empty at
>> the moment, so it's not as if it's competing with anything.
>>
>
> It's pretty empty, but IMO that's not a reason to use its "best"
> bindings for something like this. "d" should IMO be used for "delete"
> (yes, I know it's already available with C-x 0). See
> https://lists.gnu.org/archive/html/emacs-devel/2022-09/msg00326.html.
Eh, I agree with others in that thread, I don't think C-x w d should run
delete-buffer. :)
But this does make me think that maybe toggle-window-dedicated should
not have a default binding at first. We can see if people use it and
only then give it a binding. I'm fine with that.
next prev parent reply other threads:[~2023-08-19 21:47 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 15:38 bug#64619: [PATCH] Add toggle-window-dedicated command Spencer Baugh
2023-07-14 19:42 ` Philip Kaludercic
2023-07-14 21:17 ` Drew Adams
2023-07-14 23:58 ` sbaugh
2023-07-15 21:30 ` Drew Adams
2023-07-18 15:35 ` Spencer Baugh
2023-07-18 17:56 ` Philip Kaludercic
2023-07-15 5:44 ` Eli Zaretskii
2023-07-15 7:53 ` martin rudalics
2023-07-15 17:41 ` sbaugh
2023-07-15 18:16 ` martin rudalics
2023-07-18 15:34 ` Spencer Baugh
2023-08-19 13:34 ` sbaugh
2023-08-19 16:13 ` Philip Kaludercic
2023-08-19 16:20 ` sbaugh
2023-08-19 16:21 ` Philip Kaludercic
2023-08-19 20:02 ` sbaugh
2023-08-20 5:57 ` Eli Zaretskii
2023-08-21 13:00 ` sbaugh
2023-08-21 13:20 ` Gregory Heytings
2023-08-21 14:02 ` Eli Zaretskii
2023-08-21 19:22 ` Eli Zaretskii
2023-08-21 19:20 ` Eli Zaretskii
2023-10-13 1:33 ` sbaugh
2023-10-25 13:46 ` Eli Zaretskii
2023-08-19 16:43 ` Gregory Heytings
2023-08-19 20:06 ` sbaugh
2023-08-19 20:37 ` Gregory Heytings
2023-08-19 21:47 ` sbaugh [this message]
2023-08-19 22:36 ` Gregory Heytings
2023-08-20 6:13 ` Eli Zaretskii
2023-08-20 8:02 ` Gregory Heytings
2023-08-20 8:30 ` Eli Zaretskii
2023-08-20 8:41 ` Gregory Heytings
2023-08-20 8:54 ` Eli Zaretskii
2023-08-20 9:56 ` Gregory Heytings
2023-08-20 10:11 ` Eli Zaretskii
2023-08-20 10:25 ` Gregory Heytings
2023-08-20 14:09 ` sbaugh
2023-08-20 15:31 ` Eli Zaretskii
2023-08-20 21:56 ` Gregory Heytings
2023-08-21 11:23 ` sbaugh
2023-08-21 8:27 ` Augusto Stoffel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg2mpuv9.fsf@catern.com \
--to=sbaugh@catern.com \
--cc=64619@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=philipk@posteo.net \
--cc=rudalics@gmx.at \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).