unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Rahguzar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 65214@debbugs.gnu.org
Subject: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on
Date: Sun, 27 Aug 2023 10:53:20 +0200	[thread overview]
Message-ID: <87zg2cam70.fsf@zohomail.eu> (raw)
In-Reply-To: <87msyczyrd.fsf@yahoo.com>

Hi Po,

Po Lu <luangruo@yahoo.com> writes:

> Rahguzar <rahguzar@zohomail.eu> writes:
>
>> This is just a ping. Any chance these changes will be part of Emacs
>> 29.2? I think they are a big improvement over large images not scrolling
>> at all.
>
> Alas no, by reason of our policy against risky behavioral changes to the
> release branch.
>
> I have asked several other users of p-s-p-m to comment on this offline,
> but am still waiting for responses from some of them.

Makes sense, since the problem is in an edge case. Since it affects,
'image-mode' which is built in and also some modes which rely on the
functionality provided 'image-mode' is it possible to go with one of the
following workarounds:

1) Special case the handling of buffers with only one line. I don't know
if this can be made safe enough.

2) Modify the 'image-mode' to have a newline after the image. It seems
like a good enough solutions to me: as far as I can tell 'image-mode'
commands just care about the fact that point-min has the display
property holding the image. But most likely there are unintended
consequences I am not thinking of.

3) Have an easy way of disable 'pixel-scroll-precision-mode' buffer
locally. This can then be used by 'image-mode' and others modes. This
might be the best solution since 'image-mode' has sets its own
'mwheel-scroll-up/down-function' to keep track of 'vscroll' and
reapplies it when needed. As far as I can tell this bookkeeping can't be
done with 'pixel-scroll-precision-mode'. I think a non-default value for
'mwheel-scroll-up/down-function' is a good heuristic for when not to
enable 'pixel-scroll-precision-mode' in a buffer but that might also be
too broad a measure.

Or maybe some other way I am not thinking of.

Best,
Rahguzar





      reply	other threads:[~2023-08-27  8:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 17:05 bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-11  3:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-11 13:19   ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-11 14:39     ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12  2:22       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12  6:50         ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12  7:25           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12 10:43             ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27  7:53             ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27  8:16               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27  8:53                 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg2cam70.fsf@zohomail.eu \
    --to=bug-gnu-emacs@gnu.org \
    --cc=65214@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=rahguzar@zohomail.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).