From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#64855: 30.0.50; ERC 5.6: Make scrolltobottom less erratic Date: Tue, 19 Sep 2023 06:38:52 -0700 Message-ID: <87zg1icmfn.fsf__17115.1828648121$1695130836$gmane$org@neverwas.me> References: <87h6psyurb.fsf@neverwas.me> <87il948r8x.fsf@neverwas.me> <871qf2183j.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15772"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 64855-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 19 15:40:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiaxo-0003v3-4r for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Sep 2023 15:40:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiaxM-0001E8-Nt; Tue, 19 Sep 2023 09:40:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiaxH-0001DC-5X for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2023 09:39:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qiaxF-0007mg-Ni for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2023 09:39:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qiaxO-0006nA-6e for bug-gnu-emacs@gnu.org; Tue, 19 Sep 2023 09:40:02 -0400 Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Sep 2023 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 64855@debbugs.gnu.org, jp@neverwas.me, jp@neverwas.me Original-Received: via spool by 64855-done@debbugs.gnu.org id=D64855.169513075326039 (code D ref 64855); Tue, 19 Sep 2023 13:40:02 +0000 Original-Received: (at 64855-done) by debbugs.gnu.org; 19 Sep 2023 13:39:13 +0000 Original-Received: from localhost ([127.0.0.1]:55641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiawa-0006lu-NQ for submit@debbugs.gnu.org; Tue, 19 Sep 2023 09:39:13 -0400 Original-Received: from mail-108-mta167.mxroute.com ([136.175.108.167]:36373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiawW-0006li-9n for 64855-done@debbugs.gnu.org; Tue, 19 Sep 2023 09:39:10 -0400 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta167.mxroute.com (ZoneMTA) with ESMTPSA id 18aadaa51c6000d7b6.001 for <64855-done@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 19 Sep 2023 13:38:55 +0000 X-Zone-Loop: 8463e75b1b1197af586ab18aff1f47ba2acd95ef487e X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QHX1paYPwD3RKVvHv1cJOp+ZV6B9uer72YmjDcPLIww=; b=jBAN2Fp5k9oRM87tPqOhuG4ZnX evtE9N71ZmAnP8IImzKrJlaVhU7N/Mu/wPCXAiLav0mtyw4/NSPTkeBaEpuSAbaobyqz7J/j56GiO ef+cV9iUHhz2qU1b1elTJbQUDCG0LcWvL7CbFuL3+POLDdxyGxSIGr0akxNneojTgz9hxdHZGaMJS RpvTS4Oz7x41cvCM2oOel99Uqyz8lncIaghVGbTNK76GvH+j4FovcswAOpg6VZ2lew/CEYnauoOqI Cyjc8OTJ0E3prn5zdWHi0+/cVC3JLO+DUOQdtuW4jITAvoWp0za5Kc7fjn7Oy4MO4pc8HMz//j9jb 8MduqmkQ==; In-Reply-To: <871qf2183j.fsf@neverwas.me> (J. P.'s message of "Wed, 13 Sep 2023 07:05:52 -0700") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270876 Archived-At: "J.P." writes: > But it comes with a few known problems. > > The first can be observed during the rapid insertion of newly arriving > messages, like you get with history playback or large swaths of help > text. Basically, when point is away from the prompt and you issue a > command that changes `window-start' significantly (e.g., M-<), point > hardly moves at all, maybe half a screenful at most. > > Another issue is only noticeable if you have code running that > suppresses message insertion after prompt submissions (see bug#49860's > `echo-message' for one example). Basically, if you've got > `erc-scrolltobottom-relaxed' enabled and you stare long enough, you'll > notice that the prompt drifts downward with every submitted round of > multi-line input. > > Attached is a patch that attempts to address both of these issues, along > with a couple more to get at some unrelated odds and ends. I'm also sort > of thinking we ought to temporarily change the default of the new option > `erc-scrolltobottom-all' to t for a few weeks to help flush out any > other glaring bugs introduced by this feature. If anyone thinks that's a > bad idea, please say so. Thanks. I've installed this as 69a1546 Run erc--scrolltobottom-on-pre-insert unconditionally along with two others from that set. However, I left out [3/4] [5.6] Skip erc-ignored-user-p when erc-ignore-list is empty because even a minor change like this to such a widely used feature should probably be accompanied by tests and extra scrutiny, especially since I myself am not really familiar with it. The optimization itself seems simple enough, but one of those options is buffer-local and set via the /IGNORE command, which complicates matters. I'm thinking we may end up folding that patch into a larger initiative aimed at moving everything related to message skipping and hiding to another module. Indeed, there seems to be a good deal of overlap in functionality among the lurker, hide-list, and /IGNORE features (and also the fools stuff in erc-match). It'd be nice to get all that out of erc.el because it can mostly be implemented using hooks, which should help with maintenance and maybe save uninterested users some cycles.