From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer Date: Tue, 09 Jan 2024 21:12:22 -0600 Message-ID: <87zfxdvq3t.fsf@pub.pink> References: <87o7f3e4cb.fsf@melete.silentflame.com> <83wmtr2mye.fsf@gnu.org> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> Reply-To: john muhl Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39224"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67661@debbugs.gnu.org, Eli Zaretskii , Eshel Yaron , Juri Linkov To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 04:13:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNP1h-0009zh-BI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 04:13:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNP1V-00014M-LV; Tue, 09 Jan 2024 22:12:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNP1T-00012d-PH for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 22:12:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNP1T-0005C3-EN for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 22:12:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNP1a-00044s-J1 for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 22:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: john muhl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 03:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67661 X-GNU-PR-Package: emacs Original-Received: via spool by 67661-submit@debbugs.gnu.org id=B67661.170485635615620 (code B ref 67661); Wed, 10 Jan 2024 03:13:02 +0000 Original-Received: (at 67661) by debbugs.gnu.org; 10 Jan 2024 03:12:36 +0000 Original-Received: from localhost ([127.0.0.1]:41503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNP1A-00043r-8Q for submit@debbugs.gnu.org; Tue, 09 Jan 2024 22:12:36 -0500 Original-Received: from out-182.mta0.migadu.com ([2001:41d0:1004:224b::b6]:42380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNP17-00043h-UR for 67661@debbugs.gnu.org; Tue, 09 Jan 2024 22:12:35 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; s=key1; t=1704856345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6N392b4OCwjPj+zv00QyRl+g3BDDSkWU1Zm+Y8SH4iY=; b=K6PfYGXkMi5CgnPb+3WDa9SKunIVamIzFn6R4UNEY3O9ti1MvL+06h7H1dheEAkgZVhTbH auXc4M4VhKCwpcGThqSYFNwsctjti6HwB0g8GwhRRibS9lOxW6sYDBM/REZT3N+M7VI1Q1 73IFKjD3En77R8dFYul1/oWCIV5fdBM= In-Reply-To: <87bka828jm.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Fri, 29 Dec 2023 18:00:29 +0000") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277676 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sean Whitton writes: I forgot the CCs. Sorry Sean for the double email. > Hello, > > On Fri 29 Dec 2023 at 05:47pm GMT, Sean Whitton wrote: > >> I'm not sure whether to close the bug or not, because there remains the >> behavioural change for icomplete-in-buffer since Emacs 29.1. > > I've found a work around for the behavioural change: > > (setopt completion-auto-help t) > (advice-add 'completion-at-point :after #'minibuffer-hide-completions) > > So maybe we should just add something explaining this to NEWS? > > The default value of completion-auto-help is t, but I had it set to > `lazy'. > If someone wants the Emacs 29 behaviour back, they'll need to ensure > completion-auto-help is t, so I think we should mention it somewhere. > Essentially, completion-auto-help now affects both the *Completions* > buffer and icomplete-in-buffer's display. This commit (d7ff14fcba6) caused an eshell test to start failing. It seems like the test was written to account for the above mentioned bug in pcomplete but wasn=E2=80=99t sure. Attached is the test output and the change in the test to fix it. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=em-cmpl-tests.log Running 27 tests (2024-01-09 20:53:56-0600, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))') Loading em-alias... Loading em-banner... Loading em-basic... Loading em-extpipe... Loading em-glob... Loading em-ls... Loading em-pred... Loading em-prompt... Loading em-script... Loading em-term... passed 1/27 em-cmpl-test/command-completion (0.031879 sec) passed 2/27 em-cmpl-test/file-completion/after-list (0.002264 sec) passed 3/27 em-cmpl-test/file-completion/glob (0.001335 sec) Test em-cmpl-test/file-completion/non-unique backtrace: signal(ert-test-failed (((should (looking-at "Complete, but not uniq ert-fail(((should (looking-at "Complete, but not unique")) :form (lo (if (unwind-protect (setq value-67 (apply fn-65 args-66)) (setq form (let (form-description-69) (if (unwind-protect (setq value-67 (apply (let ((value-67 'ert-form-evaluation-aborted-68)) (let (form-descrip (let* ((fn-65 #'looking-at) (args-66 (condition-case err (list "Comp (save-excursion (goto-char (point-max)) (forward-line -1) (let* ((fn (save-current-buffer (set-buffer (messages-buffer)) (save-excursion (progn (write-region nil nil (expand-file-name "file.txt")) (write-r (unwind-protect (progn (write-region nil nil (expand-file-name "file (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct (save-current-buffer (set-buffer eshell-buffer) (let* ((coding-syste (unwind-protect (save-current-buffer (set-buffer eshell-buffer) (let (let* ((process-environment (cons "HISTFILE" process-environment)) ( (progn (let* ((process-environment (cons "HISTFILE" process-environm (unwind-protect (progn (let* ((process-environment (cons "HISTFILE" (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct (save-current-buffer (let* ((coding-system-for-write nil) (temp-file (closure (t) nil (save-current-buffer (let* ((coding-system-for-writ #f(compiled-function () #)() handler-bind-1(#f(compiled-function () #