From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69237: 30.0.50; Toggle password visibility Date: Fri, 16 Feb 2024 14:33:02 +0100 Message-ID: <87zfw0ttyp.fsf@gmx.de> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6828"; mail-complaints-to="usenet@ciao.gmane.io" To: 69237@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 18 19:25:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rblqs-0001Wi-Oo for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Feb 2024 19:25:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rblqH-0001tM-5i; Sun, 18 Feb 2024 13:24:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rblqF-0001qR-Kh for bug-gnu-emacs@gnu.org; Sun, 18 Feb 2024 13:24:43 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rblqF-00039u-Cv for bug-gnu-emacs@gnu.org; Sun, 18 Feb 2024 13:24:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rblqZ-0003TL-V7 for bug-gnu-emacs@gnu.org; Sun, 18 Feb 2024 13:25:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Feb 2024 18:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69237 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170828066313029 (code B ref -1); Sun, 18 Feb 2024 18:25:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Feb 2024 18:24:23 +0000 Original-Received: from localhost ([127.0.0.1]:37352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rblpt-0003Nx-WB for submit@debbugs.gnu.org; Sun, 18 Feb 2024 13:24:23 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:53956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rblSR-0001mW-8S for submit@debbugs.gnu.org; Sun, 18 Feb 2024 13:00:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rayL1-0008WQ-AA for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2024 08:33:15 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rayKx-0006hY-UB for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2024 08:33:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708090383; x=1708695183; i=michael.albinus@gmx.de; bh=TEts3SGTnB3xXenAnfqf8y5JxsompCN+/KcFtD2qyCI=; h=X-UI-Sender-Class:From:To:Subject:Date; b=l0SPsPAXYbF71B6idcO/g74/wpVxAk5UNX/51qIpHIOXMG5L3WI5994SWCoB7UCq /3xsO2pYmrXIJ297T/A38jzTfY6atzCjoMT8gSVUAD5IpuDg5aFUVJRl8guFj/SHf OrvgwN3DgzBySJP9SnDzD3yzVMU+aJQv08F/K34fGBWMB2MGUiolZ5kYtHhJGZtdV uaZWh4sDv7K6KGEE8w7gzVSREs2cRq7Nl2F5HYyEB/qRlAw7rL+hcyxjaGEYalSs9 hR1HIwOeqGkZZuUyD+F6wdxh2gEuYKUEUnTACL9FENrbFOTNX1xqvi4zoiLe0rdEK jCVENsajqJMfT0vKdA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MSbxD-1rPbYl3zIn-00Szx0 for ; Fri, 16 Feb 2024 14:33:03 +0100 X-Provags-ID: V03:K1:u2M3ndXZ8KE8zkP/PmjSIiHQfqD9dKzUK4RWB6xW0dIuxQULrVX +HgfD7xctUK4jt6fm0RDiSKAqCO7Y5fME/yfnaRdnEvv4fX6yPxtrPJORxk4vuFU2UdyU7x djM8ajZjIBL5rGMILwFWc6TVQCLKGcOrK4V8I66ryWzMjo0oRNreLXhlLIKjU7otE7KelS+ YyDJAA1tr4fUIPjgfvFNA== UI-OutboundReport: notjunk:1;M01:P0:8Q2Qb6WLSy4=;T1o20lQXMp5ppunElqTLxPM2EP7 0U936keJnkDpjONtzFJoyELdLgayS0EFRXuxruVCdSytY8utzEPHL5kg6/BU06nXVAgdo7q7B zkCaraxG65Yo3qpwaNHXxC3ZovtIDrUQikCcSINEPWiu9IqKO3i7vf+T905qRpXBowF6HLjW5 WGHDoh2RECDr3PuQbeAYSyja8+Di3A5qmTalbGIk4io61txtT9dBUMWglSDTftl0J13CLTG9v UT3tqJLcmUpctRVBtjRkUpY/Gji7m3mQpbRWJCbdn6HkL9P37tpZ9gCwnVGGRKdD2TfGUDKLq ggN2cSEwAPeKIFAAIxjC4C/a/7JPyqjXE4hEzeURTs1sFjjoiqkU02d/fqw1gdieI36dBEfTF 9FL2YmrydJnooLk8tkx8qEJ96QaBdvc1nVuSm5k+UwV7s49ZCU03PYiqrrqFJfp0eYqABdPa2 EIXcfTqeVjuMdzvfw1erjdvp11JaKdPvGyhR9SIgXG7OgAUsujA2c0JkQuoQ66FSt9b4WKtGE OroaBfIgxaaxGYWNn77rdrpZbrCpmQ30hR55MXts0WjPwXRmzYiJ7P49i1i26EcF7lxVSvPr4 ZMSUA3JfyrZrbtSeRKb4BHVL0vjppG56COz48Kg9rq1M54/yD5ikTG20gIpt3F2/fP10rQ0lj 14cza50LCLZzN4U+pqYYtS2BJlakTeNH2HiZi8LVR54ZUJePSbEAg5EIYgAOYrPkOfK5e08q5 Dx+MwyyP5H0vBs7on1zTjVl3I2AqGFqKwkKxGEzfHbWCEVwynTXfysWfsaK6k9aAhfLJ0LTy Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280189 Archived-At: --=-=-= Content-Type: text/plain We have `read-passwd', which reads a password in the minibuffer, hiding the input. However, modern password input boxes outside Emacs allow to show/hide the input while typing. The appended patch tries to implement this feature. The minibuffer in `read-passwd' has bound TAB to a function, which toggles visibility of the typed input. On graphic displays, the mode-line has an additional indicator for whowing/hiding the typed password. Clicking on this indicator with mouse-1 toggles the password visibility. Comments? Best regards, Michael. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.39, cairo version 1.18.0) of 2024-01-07 built on gandalf Repository revision: 166b10e9f80dc78147601a87b6425f59860bcfe4 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12302004 System Description: Fedora Linux 39 (Workstation Edition) Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LIBOTF LIBSELINUX LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8 Major mode: Group Minor modes in effect: gnus-undo-mode: t display-time-mode: t delete-selection-mode: t icomplete-mode: t global-goto-address-mode: t goto-address-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/albinus/src/elpa/packages/debbugs/debbugs hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs /home/albinus/src/elpa/packages/debbugs/debbugs-org hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-org /home/albinus/src/elpa/packages/debbugs/debbugs-gnu hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-gnu /home/albinus/src/elpa/packages/debbugs/debbugs-guix hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-guix /home/albinus/src/elpa/packages/debbugs/debbugs-browse hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-browse /home/albinus/src/elpa/packages/debbugs/debbugs-pkg hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-pkg /home/albinus/src/elpa/packages/debbugs/debbugs-autoloads hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-autoloads /home/albinus/src/elpa/packages/debbugs/debbugs-compat hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-compat /home/albinus/.emacs.d/elpa/helm-3.9.7/helm-packages hides /home/albinus/.emacs.d/elpa/helm-core-3.9.7/helm-packages ~/lisp/telepathy hides /home/albinus/.emacs.d/elpa/telepathy-20131209.1258/telepathy /home/albinus/src/elpa/packages/tramp-theme/tramp-theme-autoloads hides /home/albinus/.emacs.d/elpa/tramp-theme-0.2/tramp-theme-autoloads /home/albinus/src/elpa/packages/tramp-theme/tramp-theme hides /home/albinus/.emacs.d/elpa/tramp-theme-0.2/tramp-theme /home/albinus/src/elpa/packages/tramp-theme/tramp-theme-pkg hides /home/albinus/.emacs.d/elpa/tramp-theme-0.2/tramp-theme-pkg /home/albinus/.emacs.d/elpa/hydra-0.15.0/lv hides /home/albinus/.emacs.d/elpa/lv-0.15.0/lv /home/albinus/.emacs.d/elpa/transient-20240201.1100/transient hides /usr/local/share/emacs/30.0.50/lisp/transient ~/lisp/dbus hides /usr/local/share/emacs/30.0.50/lisp/net/dbus /home/albinus/src/tramp/lisp/tramp-sh hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-sh /home/albinus/src/tramp/lisp/tramp-fuse hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-fuse /home/albinus/src/tramp/lisp/tramp-loaddefs hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-loaddefs /home/albinus/src/tramp/lisp/tramp-ftp hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-ftp /home/albinus/src/tramp/lisp/tramp hides /usr/local/share/emacs/30.0.50/lisp/net/tramp /home/albinus/src/tramp/lisp/tramp-cache hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-cache /home/albinus/src/tramp/lisp/tramp-uu hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-uu /home/albinus/src/tramp/lisp/tramp-rclone hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-rclone /home/albinus/src/tramp/lisp/tramp-integration hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-integration /home/albinus/src/tramp/lisp/tramp-archive hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-archive /home/albinus/src/tramp/lisp/tramp-adb hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-adb /home/albinus/src/tramp/lisp/tramp-cmds hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-cmds /home/albinus/src/tramp/lisp/tramp-compat hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-compat /home/albinus/src/tramp/lisp/tramp-sudoedit hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-sudoedit /home/albinus/src/tramp/lisp/tramp-container hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-container /home/albinus/src/tramp/lisp/tramp-gvfs hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-gvfs /home/albinus/src/tramp/lisp/tramp-crypt hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-crypt /home/albinus/src/tramp/lisp/tramp-message hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-message /home/albinus/src/tramp/lisp/tramp-smb hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-smb /home/albinus/src/tramp/lisp/trampver hides /usr/local/share/emacs/30.0.50/lisp/net/trampver /home/albinus/src/tramp/lisp/tramp-sshfs hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-sshfs Features: (shadow emacsbug whitespace vc-dir ewoc conf-mode smerge-mode diff org-element org-persist org-id org-refile avl-tree generator oc-basic ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view filenotify ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi org org-macro org-pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp org-table org-loaddefs cal-menu calendar cal-loaddefs ediff-vers ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util hyperspec nndoc gnus-dup debbugs-gnu debbugs-compat debbugs soap-client warnings mailalias debug backtrace cl-print timezone find-func shortdoc help-fns radix-tree eww mm-url macrostep-c cmacexp macrostep cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs add-log vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view pcvs-util pulse xref project grep display-line-numbers url-queue gnus-fun shr-color color flow-fill mm-archive url-http url-gw url-auth gnus-gravatar gravatar dns url-cache smiley gnus-cite mail-extr gnus-bcklg textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async cl-extra gnus-ml debbugs-browse bug-reference disp-table qp pop3 utf-7 nndraft nnmh nnml network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-cache gnus-sum shr pixel-fill kinsoku url-file svg time-stamp nnnil smtpmail gnus-demon nntp gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr magit-base magit-section cursor-sensor crm dash compat mule-util sort find-dired vc-git diff-mode easy-mmode misearch multi-isearch rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap sgml-mode facemenu dom nxml-util nxml-enc xmltok image-mode exif dired-aux compile text-property-search comp-run comp-common face-remap ob-shell ob ob-tangle ol org-src ob-ref ob-lob ob-table ob-exp ob-comint ob-core org-cycle org-fold org-fold-core ob-eval org-keys oc org-compat org-version org-macs vc vc-dispatcher time tramp-sh lxc-tramp lxd-tramp tramp trampver tramp-integration files-x tramp-message help-mode tramp-compat xdg shell pcomplete comint ansi-osc ring parse-time iso8601 time-date format-spec ansi-color tramp-loaddefs rx delsel ido jka-compr icomplete cus-edit pp cus-load icons wid-edit dired dired-loaddefs goto-addr thingatpt alert-autoloads android-mode-autoloads auth-source-gopass-autoloads auth-source-keytar-autoloads auth-source-kwallet-autoloads auth-source-xoauth2-autoloads auto-sudoedit-autoloads auto-virtualenv-autoloads auto-virtualenvwrapper-autoloads boxquote-autoloads clang-format-autoloads company-shell-autoloads company-autoloads counsel-toki-autoloads counsel-tramp-autoloads counsel-autoloads dbus-codegen-autoloads debbugs-autoloads dired-du-autoloads dired-rsync-autoloads dired-toggle-sudo-autoloads direnv-autoloads disk-usage-autoloads dockerfile-mode-autoloads editorconfig-charset-extras-autoloads editorconfig-custom-majormode-autoloads editorconfig-domain-specific-autoloads editorconfig-autoloads editorconfig-generate-autoloads ednc-autoloads el-get-autoloads envrc-autoloads etc-sudoers-mode-autoloads exec-path-from-shell-autoloads fontaine-autoloads forge-autoloads closql-autoloads emacsql-autoloads friendly-tramp-path-autoloads fzf-autoloads ggtags-autoloads ghub-autoloads gited-autoloads gitlab-ci-mode-flycheck-autoloads gitlab-ci-mode-autoloads flycheck-autoloads gntp-autoloads gnus-desktop-notify-autoloads helm-gitlab-autoloads helm-projectile-autoloads helm-autoloads helm-core-autoloads async-autoloads ibuffer-tramp-autoloads inheritenv-autoloads ivy-gitlab-autoloads gitlab-autoloads journalctl-mode-autoloads keepass-mode-autoloads keytar-autoloads kubernetes-autoloads log4e-autoloads lsp-java-autoloads dap-mode-autoloads lsp-docker-autoloads bui-autoloads lsp-latex-autoloads consult-autoloads lsp-treemacs-autoloads lsp-mode-autoloads f-autoloads lxc-tramp-autoloads lxd-tramp-autoloads magit-filenotify-autoloads magit-autoloads pcase git-commit-autoloads magit-popup-autoloads magit-section-autoloads marcopolo-autoloads mastodon-autoloads nexus-autoloads nnir-est-autoloads oauth2-autoloads ob-restclient-autoloads orderless-autoloads persist-autoloads pkg-info-autoloads epl-autoloads popup-autoloads projectile-autoloads promise-autoloads pylint-autoloads python-environment-autoloads deferred-autoloads pyvenv-autoloads recentf-remove-sudo-tramp-prefix-autoloads request-autoloads restclient-test-autoloads restclient-autoloads s3ed-autoloads finder-inf slime-autoloads macrostep-autoloads spinner-autoloads ssh-deploy-autoloads su-autoloads sudo-edit-autoloads sudo-ext-autoloads sudo-utils-autoloads swiper-autoloads ivy-autoloads sx-autoloads markdown-mode-autoloads telepathy-autoloads totp-autoloads totp-auth-autoloads base32-autoloads tramp-theme-autoloads transient-dwim-autoloads transient-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads ht-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads treepy-autoloads uuid-autoloads vdiff-autoloads hydra-autoloads lv-autoloads vertico-autoloads virtualenv-autoloads virtualenvwrapper-autoloads s-autoloads dash-autoloads web-server-autoloads wfnames-autoloads with-editor-autoloads info compat-autoloads yaml-autoloads yaml-mode-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 886899 163552) (symbols 48 39461 3) (strings 32 179866 14690) (string-bytes 1 5887530) (vectors 16 96047) (vector-slots 8 2459540 118160) (floats 8 849 18205) (intervals 56 34351 1182) (buffers 984 108)) --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable diff --git a/etc/images/README b/etc/images/README index a778d9ce6c3..77377d36b5a 100644 =2D-- a/etc/images/README +++ b/etc/images/README @@ -125,7 +125,7 @@ For more information see the adwaita-icon-theme reposi= tory at: https://gitlab.gnome.org/GNOME/adwaita-icon-theme -Emacs images and their source in the Adwaita/scalable directory: +Emacs images and their source in the Adwaita/symbolic directory: checked.svg ui/checkbox-checked-symbolic.svg unchecked.svg ui/checkbox-symbolic.svg @@ -137,3 +137,5 @@ Emacs images and their source in the Adwaita/scalable = directory: left.svg ui/pan-start-symbolic.svg right.svg ui/pan-end-symbolic.svg up.svg ui/pan-up-symbolic.svg + conceal.svg actions/view-conceal-symbolic.svg + reveal.svg actions/view-reveal-symbolic.svg diff --git a/etc/images/conceal.svg b/etc/images/conceal.svg new file mode 100644 index 00000000000..172b73ed3d3 =2D-- /dev/null +++ b/etc/images/conceal.svg @@ -0,0 +1,4 @@ + + + + diff --git a/etc/images/reveal.svg b/etc/images/reveal.svg new file mode 100644 index 00000000000..41ae3733a53 =2D-- /dev/null +++ b/etc/images/reveal.svg @@ -0,0 +1,4 @@ + + + + diff --git a/lisp/simple.el b/lisp/simple.el index 9a33049f4ca..667b6c84a66 100644 =2D-- a/lisp/simple.el +++ b/lisp/simple.el @@ -10858,6 +10858,80 @@ visible-mode (setq-local vis-mode-saved-buffer-invisibility-spec buffer-invisibility-spec) (setq buffer-invisibility-spec nil))) + +=0C +;; It would be preferable to use "=F0=9F=91=81" ("\N{EYE}"). However, th= ere is +;; no corresponding Unicode char with a slash. Therefore, we use images. +(defvar read-passwd-show-password-image "reveal.svg" + "Mode-line image to show a hidden password") + +(defvar read-passwd-hide-password-image "conceal.svg" + "Mode-line image to hide a visible password") + +(defvar read-passwd-mode-line-buffer nil + "Buffer to modify `mode-line-format' for showing/hiding passwords.") + +(defvar read-passwd-mode-line-string nil + "Propertized mode line indicator for showing/hiding passwords.") + +(defvar read-passwd-mode-line-display nil + "Display properties for `read-passwd-mode-line-string'.") + +(defun read-passwd--toggle-visibility () + "Toggle minibuffer contents visibility. +Adapt also mode line." + (interactive) + (with-current-buffer read-passwd-mode-line-buffer + (setq read-passwd--hide-password (not read-passwd--hide-password)) + (when (display-graphic-p) + (setq read-passwd-mode-line-display + (find-image + `((:type svg + :file ,(if read-passwd--hide-password + read-passwd-hide-password-image + read-passwd-show-password-image)) + :ascent center)) + read-passwd-mode-line-string + `(:propertize " " + display ,read-passwd-mode-line-display + help-echo "mouse-1: Toggle password visibility" + mouse-face mode-line-highlight + local-map + (keymap + (mode-line keymap (mouse-1 . read-passwd--toggle-visibilit= y))))) + (force-mode-line-update))) + (read-passwd--hide-password)) + +(define-minor-mode read-passwd-mode + "Toggle visibility of password in minibuffer." + :group 'mode-line + :group 'minibuffer + :keymap read-passwd-map + :version "30.1" + (setq read-passwd--hide-password nil + ;; Stolen from `eldoc-minibuffer-message'. + read-passwd-mode-line-buffer + (window-buffer + (or (window-in-direction 'above (minibuffer-window)) + (minibuffer-selected-window) + (get-largest-window)))) + + (when (display-graphic-p) + (if read-passwd-mode + (with-current-buffer read-passwd-mode-line-buffer + ;; Add `read-passwd-mode-line-string'. + (when (listp mode-line-format) + (setq mode-line-format + (cons '(:eval read-passwd-mode-line-string) + mode-line-format)))) + (with-current-buffer read-passwd-mode-line-buffer + ;; Remove `read-passwd-mode-line-string'. + (when (listp mode-line-format) + (setq mode-line-format (cdr mode-line-format)))))) + + (when read-passwd-mode + (read-passwd--toggle-visibility))) + =0C (defvar messages-buffer-mode-map (let ((map (make-sparse-keymap))) diff --git a/lisp/subr.el b/lisp/subr.el index c317d558e24..2f475891df9 100644 =2D-- a/lisp/subr.el +++ b/lisp/subr.el @@ -3375,14 +3375,23 @@ read-passwd-map (let ((map (make-sparse-keymap))) (set-keymap-parent map minibuffer-local-map) (define-key map "\C-u" #'delete-minibuffer-contents) ;bug#12570 + (define-key map "\t" #'read-passwd--toggle-visibility) map) "Keymap used while reading passwords.") -(defun read-password--hide-password () +(defvar read-passwd--hide-password t) + +(defun read-passwd--hide-password () + "Make minibuffer contents hidden or visible." (let ((beg (minibuffer-prompt-end))) (dotimes (i (1+ (- (buffer-size) beg))) - (put-text-property (+ i beg) (+ 1 i beg) - 'display (string (or read-hide-char ?*)))))) + (if read-passwd--hide-password + (put-text-property + (+ i beg) (+ 1 i beg) 'display (string (or read-hide-char ?*))= ) + (remove-list-of-text-properties (+ i beg) (+ 1 i beg) '(display))= ) + (put-text-property + (+ i beg) (+ 1 i beg) + 'help-echo "C-u: Clear password\nTAB: Toggle password visibility")= ))) (defun read-passwd (prompt &optional confirm default) "Read a password, prompting with PROMPT, and return it. @@ -3420,18 +3429,20 @@ read-passwd (setq-local inhibit-modification-hooks nil) ;bug#15501. (setq-local show-paren-mode nil) ;bug#16091. (setq-local inhibit--record-char t) - (add-hook 'post-command-hook #'read-password--hide-password n= il t)) + (read-passwd-mode 1) + (add-hook 'post-command-hook #'read-passwd--hide-password nil= t)) (unwind-protect (let ((enable-recursive-minibuffers t) (read-hide-char (or read-hide-char ?*))) (read-string prompt nil t default)) ; t =3D "no history" + (read-passwd-mode -1) (when (buffer-live-p minibuf) (with-current-buffer minibuf ;; Not sure why but it seems that there might be cases wher= e the ;; minibuffer is not always properly reset later on, so und= o ;; whatever we've done here (bug#11392). (remove-hook 'after-change-functions - #'read-password--hide-password 'local) + #'read-passwd--hide-password 'local) (kill-local-variable 'post-self-insert-hook) ;; And of course, don't keep the sensitive data around. (erase-buffer)))))))) --=-=-=--