From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dan Christensen Newsgroups: gmane.emacs.bugs Subject: bug#68931: 30.0.50; Gnus byte-compilation error with (display . [not expire]) with git emacs Date: Wed, 21 Feb 2024 14:28:03 -0500 Message-ID: <87zfvtehx8.fsf@uwo.ca> References: <87ttmnop61.fsf@uwo.ca> <86r0hr13eu.fsf@gnu.org> <523B7DE4-EA66-4686-845A-35CDCC575F92@gmail.com> <86jznj0yol.fsf@gnu.org> <87fry63ojy.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21584"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 68931@debbugs.gnu.org Cancel-Lock: sha1:K/qXUWkqWATJRnsg9fp8Srj3xWU= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 21 20:41:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcsSg-0005G7-Rw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Feb 2024 20:40:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcsSP-0007jH-Pa; Wed, 21 Feb 2024 14:40:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcsSO-0007ip-3M for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 14:40:40 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rcsSN-0000YA-R9 for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 14:40:39 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rcsSj-0003gj-Te for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 14:41:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87ttmnop61.fsf@uwo.ca> Resent-From: Dan Christensen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Feb 2024 19:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68931 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170854444014105 (code B ref -1); Wed, 21 Feb 2024 19:41:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Feb 2024 19:40:40 +0000 Original-Received: from localhost ([127.0.0.1]:36471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcsSL-0003fC-9u for submit@debbugs.gnu.org; Wed, 21 Feb 2024 14:40:40 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:40368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcsSJ-0003ex-6Y for submit@debbugs.gnu.org; Wed, 21 Feb 2024 14:40:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcsRw-0007dV-50 for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 14:40:12 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcsRp-00005h-Ve for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 14:40:11 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rcsRl-0003on-W7 for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 20:40:01 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280415 Archived-At: On Feb 5, 2024, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > diff --git a/lisp/gnus/gnus-agent.el b/lisp/gnus/gnus-agent.el > index 604eea4c33d..cfcbea2e233 100644 > --- a/lisp/gnus/gnus-agent.el > +++ b/lisp/gnus/gnus-agent.el > @@ -2925,8 +2921,9 @@ gnus-category-make-function-1 > ;; Functions are just returned as is. > ((or (symbolp predicate) > (functionp predicate)) > - `(,(or (cdr (assq predicate gnus-category-predicate-alist)) > - predicate))) > + (let ((fun (or (cdr (assq predicate gnus-category-predicate-alist)) > + predicate))) > + (if (symbolp fun) `(,fun) `(funcall ',fun)))) > ;; More complex predicate. > ((consp predicate) > `(,(cond I see that this part was committed and then reverted. I just manually applied it to master, and it makes the warnings in the *Compile-Log* buffer go away, and my display predicate still works correctly. The warnings said: Warning: Use ‘funcall’ instead of ‘#[0 \301\300!\207 [expire gnus-article-marked-p] 2]’ in the function position So I recommend that this be committed again. Dan