From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#68931: 30.0.50; Gnus byte-compilation error with (display . [not expire]) with git emacs Date: Sat, 02 Mar 2024 18:30:14 -0800 Message-ID: <87zfvg82tl.fsf@ericabrahamsen.net> References: <87ttmnop61.fsf@uwo.ca> <86r0hr13eu.fsf@gnu.org> <523B7DE4-EA66-4686-845A-35CDCC575F92@gmail.com> <86jznj0yol.fsf@gnu.org> <87fry63ojy.fsf@ericabrahamsen.net> <87zfvtehx8.fsf@uwo.ca> <875xyhjwvv.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21148"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 68931@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 03 03:31:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rgbd3-0005N8-SU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Mar 2024 03:31:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rgbcb-00006q-99; Sat, 02 Mar 2024 21:30:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgbcX-00006G-Qk for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2024 21:30:33 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rgbcX-0006cW-I1 for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2024 21:30:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rgbd0-00022e-7k for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2024 21:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Mar 2024 02:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68931 X-GNU-PR-Package: emacs Original-Received: via spool by 68931-submit@debbugs.gnu.org id=B68931.17094330567835 (code B ref 68931); Sun, 03 Mar 2024 02:31:02 +0000 Original-Received: (at 68931) by debbugs.gnu.org; 3 Mar 2024 02:30:56 +0000 Original-Received: from localhost ([127.0.0.1]:39484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgbct-00022J-LL for submit@debbugs.gnu.org; Sat, 02 Mar 2024 21:30:56 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:40728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgbcp-00021z-0h for 68931@debbugs.gnu.org; Sat, 02 Mar 2024 21:30:54 -0500 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 68C21FA183 for <68931@debbugs.gnu.org>; Sun, 3 Mar 2024 02:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1709433016; bh=GFJrGCjACbS8WrvKp1YVTfQHvIBO2azzfmTQc3nUQEM=; h=From:To:Subject:In-Reply-To:References:Date:From; b=nvHffJ7SSjy3eGkfCI7+z3FqQmTPZs2HKRsfZO2RFPSUm8eMLWlW8tR7hKFDA+Msv NQQZXwAEd2/W1hkHjFeXo19aotAhdemI8kRu/3LPLRIjV9ECpY5ATdr8IPMGbqcz2X yE6K8BNX/5HGYhnXd8Pm6ygkxvMDaigM3FjumiI0= In-Reply-To: <875xyhjwvv.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 21 Feb 2024 14:05:56 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280912 Archived-At: Eric Abrahamsen writes: > Dan Christensen writes: > >> On Feb 5, 2024, Stefan Monnier via "Bug reports for GNU Emacs, the >> Swiss army knife of text editors" wrote: >> >>> diff --git a/lisp/gnus/gnus-agent.el b/lisp/gnus/gnus-agent.el >>> index 604eea4c33d..cfcbea2e233 100644 >>> --- a/lisp/gnus/gnus-agent.el >>> +++ b/lisp/gnus/gnus-agent.el >>> @@ -2925,8 +2921,9 @@ gnus-category-make-function-1 >>> ;; Functions are just returned as is. >>> ((or (symbolp predicate) >>> (functionp predicate)) >>> - `(,(or (cdr (assq predicate gnus-category-predicate-alist)) >>> - predicate))) >>> + (let ((fun (or (cdr (assq predicate gnus-category-predicate-alist)) >>> + predicate))) >>> + (if (symbolp fun) `(,fun) `(funcall ',fun)))) >>> ;; More complex predicate. >>> ((consp predicate) >>> `(,(cond >> >> I see that this part was committed and then reverted. I just manually >> applied it to master, and it makes the warnings in the *Compile-Log* >> buffer go away, and my display predicate still works correctly. The >> warnings said: >> >> Warning: Use =E2=80=98funcall=E2=80=99 instead of =E2=80=98#[0 \301\300= !\207 [expire >> gnus-article-marked-p] 2]=E2=80=99 in the function position >> >> So I recommend that this be committed again. > > It will be! I only reverted because I'd committed completely by > accident, and Stefan had mentioned it might need some equivalent > adjustments elsewhere to be completely correct. I just haven't tested it > fully yet. Okay, it went back in as-is. Stefan mentioned `gnus-function-implies-unread-1` and `gnus-category-make-function`, but it looks like the problem only arises when the agent code is used for Summary display predicate purposes, and the byte-compiled stuff is cached. The rest of the agent code operates on symbolic structures only. At least, I hope so! If people start complaining about their Agent predicates going wonky, we'll know where to look. Eric