From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#70137: 30.0.50; pp-macroexpand-last-sexp buffers should turn lexical binding on Date: Sun, 14 Apr 2024 09:42:12 +0200 Message-ID: <87zftwcrvv.fsf@gmail.com> References: <87v8504829.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31581"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70137@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 14 09:43:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvuW7-000877-CR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Apr 2024 09:43:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvuVp-0007AS-I2; Sun, 14 Apr 2024 03:42:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvuVo-0007AG-UD for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 03:42:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvuVo-0004XN-MV for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 03:42:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvuVz-0007FW-Fx for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 03:43:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Apr 2024 07:43:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70137 X-GNU-PR-Package: emacs Original-Received: via spool by 70137-submit@debbugs.gnu.org id=B70137.171308056027609 (code B ref 70137); Sun, 14 Apr 2024 07:43:03 +0000 Original-Received: (at 70137) by debbugs.gnu.org; 14 Apr 2024 07:42:40 +0000 Original-Received: from localhost ([127.0.0.1]:34221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvuVb-0007BD-VC for submit@debbugs.gnu.org; Sun, 14 Apr 2024 03:42:40 -0400 Original-Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:49497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvuVW-0007AC-NG for 70137@debbugs.gnu.org; Sun, 14 Apr 2024 03:42:39 -0400 Original-Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-56e1baf0380so2266413a12.3 for <70137@debbugs.gnu.org>; Sun, 14 Apr 2024 00:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713080536; x=1713685336; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=uvJ4u/Lr6uEXMoPCXYOmqYAHeTsiPIOwuYb1rPbnmdM=; b=RuFm0nzzL7R5Nppz1jj1YV3qISqhyDR34jqSmUAhao8uy0dMRhiMecRRJz2R+ikJtj 0aoQ72zjEKdq6EfITn7AxIAdz1h4hsXIQhT8pdG8o+fYkXd1V6L2XPSlGgjsuiVDYtuz YSaXPZJrVKcn+v0ldlLJPaHFYa8CAlfau3wPaaLPpIALV8/YiEDHt0tvwjw/5e9FGA1g U8FZOZurqZH6beLAGh+CN2xSIUg8D78l0Ad2KmPnyHfOECPzgXeunZsrLa0gTOBDJLE4 3XVrtX1raOq4IyaACvq9r0g64n62DqpftfdJ8ZhFpY9iWX3kFduvmyE+R3qW8drWoB9i vudQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713080536; x=1713685336; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uvJ4u/Lr6uEXMoPCXYOmqYAHeTsiPIOwuYb1rPbnmdM=; b=TgnNjp69ZJOx+lC5+TaarFiB+WANfuDApbL1H0Plq0RS8aeiljiB2sVuq/fQgLMWwc ++tDX2cgFo1Dfk+XmEp25uc2WWdRWSf1DpxSy8gyy8wwdGdTjYyzjXAUJCjQncZVI0cT Wc0O81Pp6bAVTt1WyXOn+wMmrvtoGWzkFm9Wmn7R8+g7ZsPZbXq25B84KXOIJGp5yhn9 i6+nJ5y04u4Za1k4kZlCbwZ0sbw3ggWPuM1zfVBL15PVSkz9RaxS9CX+rsFBSwuiZSC6 fdq7dzszTxwlUh90W8ncEIz0LBx5K27MBrH+HVv0WyJXGjVDs05ftqWyWe0lfVavUNPJ /yDg== X-Gm-Message-State: AOJu0Yyf5xYUGDldAowCm1mCawgxxIMKrgaQOseGCuq7d8qBDxrLvlx1 sj07BC4ulagAyYoEfTTDu4qSioHCrvw27fvnojuUp1aNOQftOxID0gDhQw== X-Google-Smtp-Source: AGHT+IG3T/WWlpo5+SiNbPuMGqIfKCREsnCHSeMd1ZFgeHSuroiz7opOXANkoBQklVAOApmwKDVkiw== X-Received: by 2002:a50:9515:0:b0:568:8e22:4eff with SMTP id u21-20020a509515000000b005688e224effmr4039533eda.37.1713080535780; Sun, 14 Apr 2024 00:42:15 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8a87:ff00::6223]) by smtp.gmail.com with ESMTPSA id v3-20020aa7dbc3000000b0057000659ed6sm2181602edt.46.2024.04.14.00.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 00:42:13 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 10 Apr 2024 17:39:43 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283256 Archived-At: --=-=-= Content-Type: text/plain On Wed, 10 Apr 2024 at 17:39, Stefan Monnier wrote: > Do you happen to have a patch to propagate the value of > `lexical-binding` to the new buffer? This would be the patch to propagate the lexical binding value. (A less magical alternative I guess would be to just always set it to t. Who needs to debug non-lexical code these days anyway?) It doesn't cover the new `pp-insert-short-sexp'. Here again setting lexical-binding=t by default might be okay. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Propagate-lexical-binding-value-to-pp-buffers.patch >From 8d81704d61153f13de516475f4e0ab53e8e94f11 Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Sun, 14 Apr 2024 09:36:05 +0200 Subject: [PATCH] Propagate 'lexical-binding' value to pp buffers See bug#70137. * lisp/emacs-lisp/pp.el (pp-display-expression): Set lexical-binding to match the value in the calling buffer. --- lisp/emacs-lisp/pp.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/pp.el b/lisp/emacs-lisp/pp.el index d586fc59939..f89807c37be 100644 --- a/lisp/emacs-lisp/pp.el +++ b/lisp/emacs-lisp/pp.el @@ -327,7 +327,8 @@ pp-display-expression If a temporary buffer is needed for representation, it will be named after OUT-BUFFER-NAME." - (let* ((old-show-function temp-buffer-show-function) + (let* ((lexical lexical-binding) + (old-show-function temp-buffer-show-function) ;; Use this function to display the buffer. ;; This function either decides not to display it at all ;; or displays it in the usual way. @@ -357,6 +358,7 @@ pp-display-expression (pp expression)) (with-current-buffer standard-output (emacs-lisp-mode) + (setq lexical-binding lexical) (setq buffer-read-only nil) (setq-local font-lock-verbose nil))))) -- 2.44.0 --=-=-=--