From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#70994: [PATCH] Make cache regeneration work in group names with / Date: Thu, 23 May 2024 18:26:50 -0700 Message-ID: <87zfsg6lut.fsf@ericabrahamsen.net> References: <86jzjt11ff.fsf@outlook.com> <87le428xvg.fsf@ericabrahamsen.net> <86y182bg9t.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20894"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Kangas , James Thomas To: 70994@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 24 03:28:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAJjG-00058b-Ar for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 May 2024 03:28:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAJix-00072L-8R; Thu, 23 May 2024 21:27:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAJiv-00070C-0A for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 21:27:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAJiu-0001Kc-NI for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 21:27:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAJj1-0001eB-Ah for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 21:28:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 May 2024 01:28:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70994 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70994-submit@debbugs.gnu.org id=B70994.17165140316294 (code B ref 70994); Fri, 24 May 2024 01:28:03 +0000 Original-Received: (at 70994) by debbugs.gnu.org; 24 May 2024 01:27:11 +0000 Original-Received: from localhost ([127.0.0.1]:33977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAJiA-0001dS-Mv for submit@debbugs.gnu.org; Thu, 23 May 2024 21:27:11 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:37260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAJi5-0001d4-EU for 70994@debbugs.gnu.org; Thu, 23 May 2024 21:27:09 -0400 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 44556FA39F; Fri, 24 May 2024 01:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1716514012; bh=hl9WT8GD2XtHe7qjuCIZi5kktun9bbulgDU+uuF8ijo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ts/mCG8VxY/BTfBUA5AJbmbISjdxf+1OHvGt4SpGLV/eQy4d6OCLIO9hf8PxtpStr VIPcfPWxgw7I4ckQhVz2ADH06xUSefVJjyCZaZaNtv6IJ8QCbFZAipgqAuNqbn9luD T96tq7w9W9emR9yDP0rbi3ATJ03b+TZClx6eHsUI= In-Reply-To: <86y182bg9t.fsf@gmx.net> (James Thomas via's message of "Wed, 22 May 2024 10:21:42 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285734 Archived-At: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Eric Abrahamsen wrote: > >> Stefan Kangas writes: >> >>> James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of >>> text editors" writes: >>> >>>> Reproduction steps for bug: >>>> >>>> - emacs -Q >>>> - (setq gnus-secondary-select-methods >>>> '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) >>>> (setq gnus-select-method '(nnnil "")) >>>> - M-x gnus >>>> - Open a message in the new group and press * >>>> - Add the cache virtual server (info "(gnus) Creating a Virtual Server= ") >>>> - ^ (server buffer) and: g on the cache >>>> - RET to open (fails) >>>> >>>> This is a possible fix that I've tested only on my (limited) setup, for >>>> now: >>> >>> Eric, what do you think of the below patch? >> >> Thanks for the bump... >> >> James, wasn't this what bug#69517 was supposed to be fixing? > > You're right, but that was specifically the 'cache'. In regenerate, all > it sees is that the backend is nnml and there's nothing else special > about the server. Okay, thanks. >> I'm still feeling like we're patching pinhole leaks in a fundamentally >> broken system. > > Sorry if my patch made you think so, but I don't feel that way =F0=9F=99= =82. This > feature is just tangential and things like slashes in group names are > bound to complicate things. I wasn't complaining about your code :) Just generally grumbling that this is so complex. > But let me see if I can whip up an alternative patch that does things in > a simpler way (I did say: 'possible' patch). One thing to decide is > whether '%'s are uncommon enough in group names to warrant special > treatment in a backend as fundamental as nnml. Without diving into this right now, it seems like this is something that should be governed by the nnmail abstract backend, from which nnml and friends inherit. I would dearly, dearly love it if all backends that might potentially create an on-disk directory from a group name would use the same code (applying the same user options) to do it, essentially transparently. It makes me nervous when various functions in various places repeat similar-but-not-quite-identical routines in encoding and decoding group names. I suppose that URL encoding/decoding functions might end up being an okay tool, but I wonder if Elisp doesn't already have some prior art here. I'll do a bit of reading. Thank you for persisting with this stuff! Eric