From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards Date: Thu, 30 May 2024 14:12:48 +0200 Message-ID: <87zfs74hxb.fsf@gmx.de> References: <87ed9m8jp4.fsf@gmx.de> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9317"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71235@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 30 14:14:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sCefk-0002Fz-LJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 May 2024 14:14:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCefJ-00084w-G2; Thu, 30 May 2024 08:13:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCefH-00084d-NY for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 08:13:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sCefH-0004Q8-Ba for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 08:13:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sCefR-000694-OO for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 08:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2024 12:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71235 X-GNU-PR-Package: emacs Original-Received: via spool by 71235-submit@debbugs.gnu.org id=B71235.171707118923459 (code B ref 71235); Thu, 30 May 2024 12:14:01 +0000 Original-Received: (at 71235) by debbugs.gnu.org; 30 May 2024 12:13:09 +0000 Original-Received: from localhost ([127.0.0.1]:60604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCeeb-00066G-6F for submit@debbugs.gnu.org; Thu, 30 May 2024 08:13:09 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:60481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCeeY-00065W-KN for 71235@debbugs.gnu.org; Thu, 30 May 2024 08:13:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1717071169; x=1717675969; i=michael.albinus@gmx.de; bh=S9Az4Vb8Dm9154PJnl4uqx3PtZFQlOzysTdsqR96Abk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=DpEr5CfLPUf3PLFZVra4vC7BeCtGjNVfNVkOd2gAKRkoIz4aIWlkNkOkaI5B1y7S HMz3XXeLsRMBAsPnq7XcWcfmcZGZI5Wi2JxQjbg6zM5A1Vh1xpBbMDTY32rLQnEaQ gzjqV7JFYx2I53qe93iQzXaYLj09e82VlUCLDg4EMYT3S86Cwbreyq+u1X/oYvUJZ skUOYV3FnLQdOF0nHVRxdwVOfJbY+ndQadiBgTQrJBUCYwiyPdWrfhsziJYxw9GEp dtLO2yraOUxWEmyEukiBzTz+BVvwlZhEF+VSYmJRzza33jsXLbgXIRoLnHtjNywCo ngsaAfvMAKiatRtbqg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.151]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MiaYJ-1sjWti2Tbz-00fflX; Thu, 30 May 2024 14:12:49 +0200 In-Reply-To: (Stefan Kangas's message of "Tue, 28 May 2024 22:56:04 +0000") X-Provags-ID: V03:K1:ds37YdQBfWIwKT8OM6SqfN5KV0xLFZI/TI/Ky6ocpAlbjX0V8hK ytzMU9zpjuLsS6Qb/pE5n4jOSHczut7agn170ZMPKXbZHpkt8Ym9UxUDB9O2k8e7SC77O5s IF0vxP2Lr48k+dlAaV0pnEljwl5aWXmh98PTytPXXlG4Yc/SwMfp7RavKHsfnkw0y+gbYjj 5PS7eYcOMskazvLe4/9fQ== UI-OutboundReport: notjunk:1;M01:P0:fgqg/MIH+AA=;H3lV1K2WkngXu9z9kv8mBFqvoCl ZAdkItABjl0Hptm9sWBrFLRvlrbpruBtLBIQ0xAl9hmqHvy8UvUiLj8bNdEVEYLCSaFkCwFvo 5U8EYoIYYovYzwBgi8GhCpWHcsAb4r5tHUqW1ATpunCTR8BASnbKuJP/r8tI+iz09ngDe3xM5 CUBbFl8Wg2PLoNHLK069JSEm+Sz23e/IjezDVrTD4LOLFExx9rsATV1xQ43McqsZNZTdsZbUO cMco5M6Hbv7hk/L4lOuCZNK/NyiPS/XV4k59UFKBBkPRb/NcVrkpcKuzsfLWKjbNh8+vlg6X3 //xsErgbSblEPgowc1FdxI51CdPHwtgZBv/wXbrobj3vY5e8GFUv9uaXpALfE30yRHx4qR35k 8+480JJYLT4vi1tlVfHwI/GspJp45tmL4zLwOAohGem16D5ieZuw/Lv+aZq7mF7EnH2b6Y59y qth08ZDAwogdymjPBBake4d015g1u9WDATJxeyUI8jAFofguyKMnLpmuD4oUUWlCY0rRBAFXf r9v5eVNtqgeabep4DYq6wqvjeL5/F9FsVdRzwgFKmkhzDwZqXK2b4s7nSIpxvs9JsaXzea2RM K3g5/s87BXOSMI6WoYHn0U4LQRyqSY08HgiNEqY8La3AuOYRD5Et24Xf80FSdnjWcyRKRWgPc Z2EWbW24zrrEE8lLfq5iiaLKglTc/lhCbpaO04MH2+eBzW4ZDqJ2LzJLqGi1EvtX/Zc7ATemt lnoopdWDYimGf3V5j/ogTtkejDarsNgLJ7CS2tv3cpcGRzB0z2JZJBZh5RMHO5QkmD3H7UiD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286219 Archived-At: Stefan Kangas writes: Hi Stefan, >>> I see one tramp test fail on macOS 14.3.1. Details below: >>> >>> Ran 98 tests, 82 results as expected, 1 unexpected, 15 skipped >>> (2024-05-27 23:27:48+0200, 89.934240 sec) >>> >>> 1 unexpected results: >>> FAILED tramp-test17-dired-with-wildcards >> >> Could you pls instrument the test, and run it again? See appended patch. > > I've sent you the logs off-list. Thanks for this. The problem is obvious in the log: --8<---------------cut here---------------start------------->8--- 00:52:56.390327 tramp-send-command (6) # ( cd /var/folders/28/y4qn6tl11_126= 568wmx_6kpr0000gn/T/ && env INSIDE_EMACS\=3D30.0.50\,tramp\:2.7.1-pre /bin/= sh -c gls\ -d\ -al\ tramp-test\*/\* 8--- However, Tramp hasn't decided to use gls on its own. Debugging the test case, it looks like it comes from dired-insert-directory: --8<---------------cut here---------------start------------->8--- ;; Expand directory wildcards and fill file-list. (let ((dir-wildcard (and (null file-list) wildcard (insert-directory-wildcard-in-dir-p dir)))) (cond ((and dir-wildcard (files--use-insert-directory-program-p)) (setq switches (concat "-d " switches)) (let* ((default-directory (car dir-wildcard)) (script (format "%s %s %s" insert-directory-program switches (cdr dir-wildcard))) (sh (or (and remotep "/bin/sh") (executable-find shell-file-name) (executable-find "sh"))) (switch (if remotep "-c" shell-command-switch))) ;; Enable globstar (when-let ((globstar dired-maybe-use-globstar) (enable-it (assoc-default (file-truename sh) dired-enable-globstar-in-she= ll (lambda (reg shell) (string-match reg shell))))) (setq script (format "%s; %s" enable-it script))) (unless (zerop (process-file sh nil (current-buffer) nil switch script= )) (user-error "%s: No files matching wildcard" (cdr dir-wildcard))) (insert-directory-clean (point) switches))) --8<---------------cut here---------------end--------------->8--- 'script' is a formatted string, which includes 'insert-directory-program'. And that user option tells us --8<---------------cut here---------------start------------->8--- Absolute or relative name of the =E2=80=98ls=E2=80=99-like program. This is used by =E2=80=98insert-directory=E2=80=99 and =E2=80=98dired-inser= t-directory=E2=80=99 (thus, also by =E2=80=98dired=E2=80=99). For Dired, this should ideally po= int to GNU ls, or another version of ls that supports the "--dired" flag. See =E2=80=98dired-use-ls-dired=E2=80=99. On GNU/Linux and other capable systems, the default is "ls". On *BSD and macOS systems, the default "ls" does not support the "--dired" flag. Therefore, the default is to use the "gls" executable on such machines, if it exists. This means that there should normally be no need to customize this when installing GNU coreutils using something like ports or Homebrew. --8<---------------cut here---------------end--------------->8--- So I guess 'insert-directory-program' is "gls" in your case, but Tramp doesn't find it. Where is it installed? What does '(executable-find "gls")' return on your machine? Best regards, Michael.