From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71264: 30.0.50; Dired deletion moves point under auto-revert Date: Fri, 31 May 2024 14:54:01 +0200 Message-ID: <87zfs6b0ra.fsf@ledu-giraud.fr> References: <87zfs8waqx.fsf@epfl.ch> <87mso61g92.fsf@ledu-giraud.fr> <87ikyu1fo5.fsf@ledu-giraud.fr> <87sexygp0t.fsf@epfl.ch> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21094"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71264@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 31 14:55:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sD1n3-0005Fq-4D for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 May 2024 14:55:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sD1mX-000451-IA; Fri, 31 May 2024 08:54:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sD1mV-00044k-Jo for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 08:54:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sD1mV-0004NE-C5 for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 08:54:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sD1mg-00061P-5z for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 08:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 May 2024 12:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71264 X-GNU-PR-Package: emacs Original-Received: via spool by 71264-submit@debbugs.gnu.org id=B71264.171716007023090 (code B ref 71264); Fri, 31 May 2024 12:55:02 +0000 Original-Received: (at 71264) by debbugs.gnu.org; 31 May 2024 12:54:30 +0000 Original-Received: from localhost ([127.0.0.1]:53509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD1m9-00060M-U7 for submit@debbugs.gnu.org; Fri, 31 May 2024 08:54:30 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:6818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD1m5-000607-NK for 71264@debbugs.gnu.org; Fri, 31 May 2024 08:54:28 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=FL3Fjh9g c5WVbucboX5BzOkG4l4b5yUITtg/lNOhPyE=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=GxSogXkjGDdNY43TX3BERTSlIUt+lw u0I89IIiQmHfKPkAuHvvGVo54bKO9wWvi7VyFLqL+BpQsBB2Pp+XokCA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=FL3Fjh9gc5WVbucb oX5BzOkG4l4b5yUITtg/lNOhPyE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=srWDTAXUV1Ljek2k3wO0bjAVd8bex81OGeuwHq shl9JFxRQVlplv5UKqqfqc+3+cxDl2LL5GYXaJPHISRSbwoV2l0GMEnej8Vex6fAp0LkbQ H6Zgr0Cpbp/Hm27O+2J6YxRuWXUvZkxiBjuhHe/R1axy/ia536+YY80IqfKZHmIPiQousT 2LSkOmrFUMhLbTIPrvp6ZHesgufj56+Bp75d+D5oTUVyNXfBiF2cweQLay0ZBVzHc//tK6 dxtVVr/3/z8HXism0X+Hw8nFcy0uyWY+VYSBx0FTiH9fcAV5IuCKNYEqcSzPKE2es5v5Kg mrKYCMXMlMu0v3QkO/YplJnA== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 82d72c26 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 31 May 2024 14:54:11 +0200 (CEST) In-Reply-To: <87sexygp0t.fsf@epfl.ch> (Basil L. Contovounesios's message of "Fri, 31 May 2024 14:10:58 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286278 Archived-At: --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > Manuel Giraud [2024-05-31 11:42 +0200] wrote: >> Manuel Giraud writes: >>> Customizing `dired-clean-up-buffers-too' to nil, fixes this issue for >>> me. Do you see the same? >> BTW, customizing `dired-clean-confirm-killing-deleted-buffers' to nil >> also solve this issue. > > ISTR that yes, disabling the prompt avoids the issue, maybe because the > prompt allows auto-revert-mode to take effect (just speculating). Ok. > I wouldn't go as far as saying that disabling the prompt 'fixes' the > issue - I would still like to keep the prompt enabled as a user-facing > safety feature. You're right: this is not a 'fix' per se just a circumvention of this issue. Anyway, I think I've made some progress. It seems to come from the following unnecessary funcall (maybe you could try this patch): --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=dired.diff diff --git a/lisp/dired.el b/lisp/dired.el index f2a75df6ef1..518d581e3e6 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -4100,9 +4100,9 @@ dired-clean-up-after-deletion (let ((buf (get-file-buffer fn))) (and buf (or (and dired-clean-confirm-killing-deleted-buffers - (funcall #'y-or-n-p - (format "Kill buffer of %s, too? " - (file-name-nondirectory fn)))) + (y-or-n-p + (format "Kill buffer of %s, too? " + (file-name-nondirectory fn)))) (not dired-clean-confirm-killing-deleted-buffers)) (kill-buffer buf))) (let ((buf-list (dired-buffers-for-dir-or-subdir --=-=-= Content-Type: text/plain As to why it causes this behaviour, I really don't know. -- Manuel Giraud --=-=-=--