From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Date: Thu, 20 Jun 2024 10:22:24 +0200 Message-ID: <87zfrgvxa7.fsf@gmail.com> References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <87sexfaf2i.fsf@gmail.com> <86ed8zy9gc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22400"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , acorallo@gnu.org, 71499@debbugs.gnu.org, bkhl@elektrubadur.se To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 20 10:24:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKD5j-0005dF-SC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jun 2024 10:24:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKD5O-0001WP-KT; Thu, 20 Jun 2024 04:24:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKD5K-0001UD-G0 for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 04:23:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKD5K-0004Jc-8P for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 04:23:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKD5N-0001Yo-NH for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 04:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2024 08:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71499 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71499-submit@debbugs.gnu.org id=B71499.17188718195958 (code B ref 71499); Thu, 20 Jun 2024 08:24:01 +0000 Original-Received: (at 71499) by debbugs.gnu.org; 20 Jun 2024 08:23:39 +0000 Original-Received: from localhost ([127.0.0.1]:48420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKD50-0001Y1-H6 for submit@debbugs.gnu.org; Thu, 20 Jun 2024 04:23:38 -0400 Original-Received: from mail-lf1-f41.google.com ([209.85.167.41]:58569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKD4y-0001Xn-LN for 71499@debbugs.gnu.org; Thu, 20 Jun 2024 04:23:38 -0400 Original-Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52cc5d5179aso973633e87.0 for <71499@debbugs.gnu.org>; Thu, 20 Jun 2024 01:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718871747; x=1719476547; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6KvR1qujlJHA03nIqpxp4pM10YPGa/cgicCDfNWryRs=; b=BuRGRXlG+tCLVp+bf9KYJXQ47h/l6jaRUHBglpYtb0QN8IUUZYScfckkhnzSkKm7PA Cwf65TI8iIU5uU9xLQmrN6+HLEqATXVMloo8tsrgCEhSWVN3F8r/W8qNm2sNoMNFjd14 ofgPzlae8diIXNivPghdg41IfOdw4ueOheHane8Es0wu3v1oWEbPUgXlNJBzuSjf+1fR /5KOW74N4yy/eRRD2KI5rJRSoP2SzlB2R55yVxx92gIyUexmdQ39paereIDt/Q16tUjS TnHuPJNBR1W38lgO9U+HaQHtogd6SD74GSSTWZgVUdbaYPviuZaMF0j46lFmAeetoJ5F DRhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718871747; x=1719476547; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6KvR1qujlJHA03nIqpxp4pM10YPGa/cgicCDfNWryRs=; b=B4BJWIvZmuOYGJGNp8cxtR+58Am2aE/ACSaIKuotDuokaGU41qcWTb61aaRg47ennN d14fzE3xRTx/0RXWixUjRtJ3T/ThDcJRCHAttuSXCIS1FFs+FMnsiPQ65s9A77Z32o0m vBiP/WWnjz1ypFCjQBshSFfgmThZJw2f170S4G7CW3kVT0XooCyKwNk0hx0NcuaPb6Wf gwlktlKmiv8UPLU5Xp1vM2a0KAmXe0wIdM9x82sTP27i10vO/IfNv4QPZzlCM+mAuz/N xoBY9KZDtiZK3cEwfzWWR7H8+Y/quC6qicGaYJADSpDvBGVVUBPMkdECv4cl9//js9JN SHmw== X-Forwarded-Encrypted: i=1; AJvYcCXwjGEVy7NEN3axKv8zHX8HVIWB7u5Pd4yes/7ZsdAR5s7+wzKOquSJFlPkBBhOp7RpZE5Os+GBVgRUE5nFedszeGz0GF8= X-Gm-Message-State: AOJu0Yz/O4AmtLcDDlIf8oJz942Nko34PlkJ7ftRQn7J5szzgZq6CEUw e/LucbV9eRfcbHIuQHPhx7QXpoI/gCvv8L9c2w8MyCcqdSp8WaZp X-Google-Smtp-Source: AGHT+IEhuBqiwmHZtXN2DT9BcEljVNnM7xNjFcb7+sn82fyhEsOzqhDmHa8e2WnSNBMzwmHbFLOrrA== X-Received: by 2002:a19:8c12:0:b0:52c:99fe:3133 with SMTP id 2adb3069b0e04-52ccaa5a120mr3124520e87.63.1718871746445; Thu, 20 Jun 2024 01:22:26 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d1f6da9sm16576765e9.44.2024.06.20.01.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 01:22:25 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Thu, 20 Jun 2024 07:55:19 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287538 Archived-At: >>>>> On Thu, 20 Jun 2024 07:55:19 +0000, Stefan Kangas said: Stefan> Eli Zaretskii writes: >>> From: Robert Pluim >>> Cc: Andrea Corallo , 71499@debbugs.gnu.org, >>> stefankangas@gmail.com, bkhl@elektrubadur.se >>> Date: Fri, 14 Jun 2024 14:23:17 +0200 >>>=20 >>> >>>>> On Thu, 13 Jun 2024 11:30:51 +0300, Eli Zaretskii said: >>> >> I'm as well for having the patch in, but I guess would be safer = in 31 so >>> >> we have plenty of time to react if needed. >>>=20 Eli> OK, thanks. I will then install after the branch is cut. >>>=20 Eli> Meanwhile, Bj=C3=B6rn, I have a few comments to the patch: >>>=20 Eli> . it needs a NEWS entry announcing the new feature Eli> . is there any reason your code to handle the missing newline is n= ot Eli> identical to what the implementation of require-final-newline Eli> does? >>>=20 >>> I=CA=BCm going to chime in and say that, even though I highlight mi= ssing >>> newlines at eob, I don=CA=BCt normally set `require-final-newline' = to t, >>> because of various reasons involving collaboration with others. So = I=CA=BCd >>> have to turn this off once it goes in. Stefan> Could you explain why you'd need to turn it off? Stefan> Do you usually use `whitespace-cleanup` on files where you coll= aborate Stefan> with others, but then you specifically don't want to ever touch= newlines Stefan> at eob? Yes. I guess I could turn off whitespace-cleanup for those files, and complain at those people more loudly :-) . I don=CA=BCt have a strong objection to this feature, so we don=CA=BCt have to add yet-another-config-variable just for me. Robert --=20