From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Date: Fri, 20 Sep 2024 17:08:37 +0100 Message-ID: <87zfo28fzu.fsf@zephyr.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18284"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: monnier@iro.umontreal.ca, dgutov@yandex.ru, juri@linkov.net To: 73387@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 20 18:10:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1srgCw-0004Wm-0s for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Sep 2024 18:10:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srgCf-0004Lg-KY; Fri, 20 Sep 2024 12:09:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srgCb-0004Cq-Ge for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2024 12:09:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srgCV-0003h4-Ub for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2024 12:09:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=Yey9nWp3VtpHx2psNWC6ApAFo+MxJT/mgLyhnHPQ9M0=; b=cZ15I4WJJU+Njb00dOETqVKaNylWt/Z51OoHtOxx3b9vn6hK9pvScIBVUFTGU7G3btwn4UEbZH6dXkivFg+XB0ApdvYwWWdDNHXuVrAgx9GJm0tyaPGzkE0q265dg7vHZWdoLB4uTIG57NpbXvN3cc3mlIcPc5y2aYPZXJVuhQvogPD+z24pg4WlxdenvIN/sYsJ1qBuh+2hfHZgoXSrmyV7mDOog58AV+5jP6JPQPe6HdofhgCFIFW/G0Gdj8SM7SbF/OdSeMoav7x1prk+iGkRMwcmxKiDzX9NuI6PnnN7PpdHOJFiiWp3REiauBrILtuZtELsKJqI9XHOE3rMLg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1srgCn-0003nk-Lk; Fri, 20 Sep 2024 12:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, dgutov@yandex.ru, juri@linkov.net, bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2024 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73387 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: monnier@iro.umontreal.ca, dgutov@yandex.ru, juri@linkov.net Original-Received: via spool by submit@debbugs.gnu.org id=B.172684854814464 (code B ref -1); Fri, 20 Sep 2024 16:10:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Sep 2024 16:09:08 +0000 Original-Received: from localhost ([127.0.0.1]:36128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srgBv-0003lE-Fy for submit@debbugs.gnu.org; Fri, 20 Sep 2024 12:09:07 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srgBt-0003l3-5k for submit@debbugs.gnu.org; Fri, 20 Sep 2024 12:09:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srgBZ-0003Om-TG for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2024 12:08:45 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srgBX-0003bO-OI for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2024 12:08:45 -0400 DKIM-Signature: a=rsa-sha256; b=sEpNRnjxaQkweN8WNfptNNOrhuDs3fDz39opWMND4d4ISNeJ1AWhdL1rVPP2c1KualuADpCXMPGRudK7qUg/SJ7WzmQqTwxdX2Q38R+AcM+IwfJeyJ8I7w5nLdwvVycQZl4PVUTrjf0ROXCQHfsCfqggJv/edJWd4KVd4VSkDfmAVei6hRGMeb7FDYsz/GgCDggICq3n8Q1+YMeFCB7hgixb5ihL2Pq2g+9JHD87fAsHS17+M5zIdzZGKwfWtMFcgvEAPMLzoHJxZCh4oIzoAJxfdCPLn9V5lTS0PTWfwt1KEqur3OdjGiG3oeK+PD/d6vTt/Oj32OPrj9onnM6Nbg==; s=purelymail3; d=spwhitton.name; v=1; bh=wGreWrrRiHEA+7gleVn4jMQDDrxrRW5bwFNgmmsSfoc=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=CLgT4uIs+u15YCYR7PvWia0+AUjkIL8C/psmE5Iuchval2cWWLvjZchYf1Uz+y3KnTYaivhs5PZ7yjwaqXNSy5V1q5t/7UdPwBphUK4YaC7boXrCY2ICDo93YE65V7nFH2UECZTRqr3YjxeMn2078K0yJOrVHJpVEs6iv1ec8tsvxI1hAoReR36aUrAPyhVaJTseoPflqXq7ECeKbjhKNAyCDI8H5xKy5YqzY7+VmmhaM+4JXOD5w+qzS8XcgXH4HOsUvzsldFB6fEmCSXo23Hq9H/fUFDINHXd1T0ViG8YxV+TYFUAbnk54v19r5c4JfA2zhpgEdESWbwv8fskUAg==; s=purelymail3; d=purelymail.com; v=1; bh=wGreWrrRiHEA+7gleVn4jMQDDrxrRW5bwFNgmmsSfoc=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: bug-gnu-emacs@gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1440394413 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 20 Sep 2024 16:08:38 +0000 (UTC) Original-Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 03605949FDC; Fri, 20 Sep 2024 17:08:37 +0100 (BST) Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GAPPY_SUBJECT=0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292128 Archived-At: X-debbugs-cc: monnier@iro.umontreal.ca, dgutov@yandex.ru, juri@linkov.net Hello, If you do C-c C-n in a diff-mode buffer with multiple hunks, a subsequent C-x v v signals a user-error from diff-file-next. I think that the bug is in how diff-vc-deduce-fileset invokes diff-file-next. I'm not sure exactly how to rework diff-vc-deduce-fileset. It would be nice to fix this because then C-c C-n C-x v v would be a convenient way to commit just a single hunk. -- Sean Whitton