From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73412: 31.0.50; Improve sql-read-product Date: Sat, 21 Sep 2024 22:29:54 +0200 Message-ID: <87zfo0n41p.fsf@gmx.net> References: <874j69nklr.fsf@gmx.net> <86o74h2fts.fsf@gnu.org> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3567"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73412-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 21 22:31:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ss6l3-0000lH-14 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Sep 2024 22:31:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ss6kn-0007fj-Oj; Sat, 21 Sep 2024 16:30:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss6ki-0007f8-JW for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 16:30:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ss6kc-0001pW-7R for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 16:30:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=wXbzNcsu+sgetIyaUGVnvQIuPwJjiKVtOX9wk+IoTpo=; b=MfhW/e4LP3L/NX494GMvtRJ9lYARb+TH164ebE1dCrfKvclM40A5CRvFt+rlbCAHY7RWQbJuB/pqYtZnLtdCOnQ+AncLAePtUsvST5yApuiaaCgDyUikcY6zPRALOe6xBRJnIMCrcwPFIKsGMS6AwZDrt/IWREKMoOJzSkxDAPX6TOtGI7laIRqp/78XPCRBV64TEbVSWs4Fsw8jQd49eNljuwCRZ6pvRkqBg+8sv9U6zpO5TIRmfeN8XAus3GuPBib4y4l9Pat9JsXXHtwNJtQBn9kpWyyMqOMlgp/wDlcJVcWGi21zfhM+VIWN/q9jvUDTugM6OZCXSO5FLhME6w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ss6kw-0006Hm-QW for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 16:31:02 -0400 Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Sep 2024 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73412 X-GNU-PR-Package: emacs Mail-Followup-To: 73412@debbugs.gnu.org, stephen.berman@gmx.net, stephen.berman@gmx.net Original-Received: via spool by 73412-done@debbugs.gnu.org id=D73412.172695062523744 (code D ref 73412); Sat, 21 Sep 2024 20:31:02 +0000 Original-Received: (at 73412-done) by debbugs.gnu.org; 21 Sep 2024 20:30:25 +0000 Original-Received: from localhost ([127.0.0.1]:40378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss6kL-0006Ao-Gs for submit@debbugs.gnu.org; Sat, 21 Sep 2024 16:30:25 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:41139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss6kK-00068V-8f for 73412-done@debbugs.gnu.org; Sat, 21 Sep 2024 16:30:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1726950597; x=1727555397; i=stephen.berman@gmx.net; bh=wXbzNcsu+sgetIyaUGVnvQIuPwJjiKVtOX9wk+IoTpo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=PnrOx9TWVwEiwLtd8OILPEXz/+ihY4CiAUCZo0Wl9N1iYCg3ALDUl3kGZTH3RsVw C0qSBktQBv93OD0RBxz/CqH0vTSz8iqlAcvBdGVyznD8W4u5vtFGTsRMClAjlSwjZ fyJTcRRR5BL/+2wyZWtKuDoaUn8B5Wod6LHQT/mPPOi+8p4+x8JcVM8BpyEv9so2L QksKYAmueQM1gPkSAQFwCwvshXyCWoU8maRNvAM/i20y6HWxh8EyPrj4VHlKWFx4e 4ns7aUueFdG7fyxE7qNAtvan2eCgOUf7S9Nba8908ncnrPOeC2DZbS60LEM4UAQhw EhtsoIg2dkt8jA9N3w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([88.130.49.45]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MWics-1sTx643b44-00IlxB; Sat, 21 Sep 2024 22:29:56 +0200 In-Reply-To: <86o74h2fts.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 21 Sep 2024 18:21:03 +0300") X-Provags-ID: V03:K1:hqLW6Li79iipFzzXNi11LLZbCKJt9cVtxREeJBJ7+NUzlk+DnJr zWPZrxlEeTNmLQaRCbflbGObs8ONIBo7neUIPIJVQpVl2MQH0trDSZIZlPkCIbW3aa6R7ry POrqeQLZs2nX5H+tB6ktCSFhqfGMjX8buSG3UX/xDCGndniU5EpGSlDCLF8bbvraWn6Kuk4 voOpADW0G/OUFLP00D8lw== UI-OutboundReport: notjunk:1;M01:P0:NH15t3mxBMQ=;0x+yG5ySyPPbXLHPtwDqQZNBn7f xG2xUUiHKnelvsqTMR7eC7VISGQo9odwkDa2ktGb9L/YjkdkWPW2R9bz4XnV0/odIA2IIVZoC esvQPv+pCjb5q9oi1qoEq26sLTlGgTA9RaQ5FiYWK6DbEbSI12le/A1qZHI2urfUJirM23hE4 c21x8NAU/bwPy1gO7U/gsMLw8nupwtu7gpIxms1Xra1yP0guZrP0ku6Zqyzz11buGnVgUbfTu 3kdj4bUoYkpieRCkAUTm3cqDlFob5pK5kXmXuMthxCpArB5ZeQ4lfCw/6Qloxl+yGDZhb4T3A sCez08Wl5VifoBfV12hY2kznnmS0/dYwJsCqpJtMU5+izRjJCmbwWA3Lr7E2IEDcw78gHyf9l aN0blfONKStfl/NRe1OmFq76E0D5tbEmIkFahVh8okfQV33EPO94Y8897H06qLNBN06f9W/pb n4Z2C4LkUhA9ZjXAY75TkjOGCrn98vCe0nq1EcqDjMtsi38WqeDN9JTRjEk++Ws2p6Zk/ocYL XkmoXpW5FeQ+Zm0G9cfGwTDy2rSwpofuerG0J4pmCtDMNr6DTQly0Aep559CJm9v3aPOlMn+7 k4fdJxjxiJn2JHfOrhXBIZBOfADzrc/ck0Jj0Yl5QW4K2izfbwuzeWuoDzFwCE7BZk6B3TobH elUO9HRNmW1OpLySUJci/CIdmum0H+7ygZxadFOE9D8qdSfgiP7pMBmMxt6GXo2hSdLLdQe6r ubptYFq/wS99nuXyG/MgWausgR1CsWV/NUYbqoxucDf8wKgIue8bMYhdBFFwEbGePJ07OgPw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292207 Archived-At: On Sat, 21 Sep 2024 18:21:03 +0300 Eli Zaretskii wrote: >> Date: Sat, 21 Sep 2024 16:32:16 +0200 >> From: Stephen Berman via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> 0. emacs -Q >> 1. C-u M-x sql-product-interactive RET >> >> Now the minbuffer displays the following: >> >> SQL product: ansi >> >> so it you want to change the product, e.g. to postgres, you first have >> to delete "ansi". >> >> Likewise, `M-x sql-set-product RET' produces the same minbuffer display= , >> requiring deletion to change the product. >> >> The reason "ansi" is displayed after the prompt is that the definition >> of sql-read-product uses the same non-nil value of the deprecated >> argument INITIAL-INPUT as is used for the argument DEF. The attached >> patch makes INITIAL-INPUT nil, thus using only DEF, and also wraps the >> prompt argument of sql-read-product in format-prompt, so the default >> value is shown as part of the prompt and changing it does not require >> deletion. The patch also adjusts the two callers of sql-read-product >> accordingly. > > Thanks. > > I think this should go to the emacs-30 branch, no? I agree and did so in commit c1f2501f55d and am closing the bug. Since this is a minor UI update and improvement with no change in functionality I assume it does not need to be called out in NEWS, right? Steve Berman