unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: jao <jao@gnu.org>
To: "Tassilo Horn" <tsdh@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	73530@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>
Subject: bug#73530: [PATCH] Add imenu index function for Djvu files in doc-view
Date: Sat, 28 Sep 2024 20:03:48 +0100	[thread overview]
Message-ID: <87zfnrzjl7.fsf@mail.jao.io> (raw)
In-Reply-To: <87setjhcm6.fsf@gnu.org> (Tassilo Horn's message of "Sat, 28 Sep 2024 20:11:45 +0200")

On Sat, Sep 28 2024, Tassilo Horn wrote:

> Visuwesh <visuweshm@gmail.com> writes:
>
>>>> doc-view-imenu-enabled
>>>
>>> Indeed.  And while we are here: doesn anyone know why we have an
>>> option to disable imenu support?  I see that we have that since Jose
>>> contributed the initial imenu support but why?  I can't see any harm
>>> done if it was always enabled and would give a user-error like "For
>>> imenu support for XXX files, program YYY has to be installed" or
>>> something when invoking imenu.  And why someone might want to disable
>>> it even if the required program is available is beyond my
>>> imagination.  I mean, if you don't want to use imenu, then just don't
>>> invoke it...
>>
>> I was wondering the same thing, especially since the cost of making the
>> imenu index is not that high.
>
> So lets ask Jose (added to Cc).

If I recall correctly, that flag is there to save CPU cycles in case
users of doc-view are not interested in imenu.

The PDF's outline is scanned using mutool when doc-view-mode is
activated if doc-view-imenu-enabled is true, and for big files that can
take a second or two.

I am not sure why I didn't delay creation of the index, but it's
probably because there are menu entries to create and I didn't bother to
investigate deeper. Also, because I didn't want to see a pause the first
time imenu was invoked on a PDF.

Admittedly, most of the time the pause is small enough to make all of
the above moot.

Cheers,
jao
-- 
Many people take no care of their money till they come nearly to the end
of it, and others do just the same with their time.
  -Johann Wolfgang von Goethe (1749-1832)





  reply	other threads:[~2024-09-28 19:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-28 15:10 bug#73530: [PATCH] Add imenu index function for Djvu files in doc-view Visuwesh
2024-09-28 15:42 ` Eli Zaretskii
2024-09-28 17:02   ` Tassilo Horn
2024-09-28 17:35     ` Visuwesh
2024-09-28 17:53       ` Eli Zaretskii
2024-09-28 18:11       ` Tassilo Horn
2024-09-28 19:03         ` jao [this message]
2024-09-28 19:15           ` Tassilo Horn
2024-09-28 19:50             ` Jose A. Ortega Ruiz
2024-09-29 14:03               ` Tassilo Horn
2024-09-29 14:34                 ` Visuwesh
2024-09-29 16:20                   ` Tassilo Horn
2024-09-29 16:38                     ` Visuwesh
2024-09-29 17:15                       ` Tassilo Horn
2024-09-30 17:29                         ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfnrzjl7.fsf@mail.jao.io \
    --to=jao@gnu.org \
    --cc=73530@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=tsdh@gnu.org \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).