From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#64055: [WIP Patch] Enable editing commit messages - vc-git-modify-change-comment Date: Sun, 20 Oct 2024 15:18:38 +0800 Message-ID: <87zfmzs0mp.fsf@melete.silentflame.com> References: <87pm5yo4m7.fsf@gmail.com> <87legmnq4l.fsf@gmail.com> <87r090o8cl.fsf@melete.silentflame.com> <874j5vgypf.fsf@melete.silentflame.com> <787fb692-db24-4682-871b-5a52d31a1249@gutov.dev> <87ed4obs1b.fsf@melete.silentflame.com> <87o73sad24.fsf@melete.silentflame.com> <877ca63ln5.fsf@melete.silentflame.com> <86r08enfri.fsf@gnu.org> <87cyjyvsns.fsf@melete.silentflame.com> <868qulojrx.fsf@gnu.org> <87zfn1vjvb.fsf@melete.silentflame.com> <864j59ob91.fsf@gnu.org> <87ldyjvbgz.fsf@melete.silentflame.com> <86h697jrpu.fsf@gnu.org> <87plnvtk88.fsf@melete.silentflame.com> <86bjzfjofn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10874"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Morgan.J.Smith@outlook.com, rpluim@gmail.com, 64055@debbugs.gnu.org, dmitry@gutov.dev To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 20 09:20:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2QEN-0002e3-Ur for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Oct 2024 09:20:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2QDy-0003ib-FU; Sun, 20 Oct 2024 03:19:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2QDx-0003iS-En for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 03:19:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t2QDx-0000vY-66 for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 03:19:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=jEhzehS6aeFHtZWowiOp9wQM3OY/yawNxmQSSh21Jxc=; b=THYJzoolmt0K51cksvvOn82o7OZAgJusck0Nugd9vhySJIlSCI6zSTyz6KjBu/vG/NgC3nP3kL+gUpYu7i5vL8TmviFSMTaSg25ApG4hr3hPube3EGrN9kbB4W8GF9uq7Uttc6OYna9ItICBMWNU/84JTIdlur9AqffyrdfIpoP5T5EXh0g+tDOb5+ngSSOKtkzeiKmyaVouRs5giF4WHP9o8sutO/Sw9ZfuXbN6k6jScfgKCVolX75DMMhlRKffk9uKUOXRAVIVswKM5YHpRzLFOKvfwS0gKO2NqQ0LBnqm5pLju8M0FaJyEaen5o429t2GEf7780WwXq/H3wEfCg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t2QEL-0007bT-TR for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2024 03:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2024 07:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.172940875729161 (code B ref 64055); Sun, 20 Oct 2024 07:20:01 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 20 Oct 2024 07:19:17 +0000 Original-Received: from localhost ([127.0.0.1]:45591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2QDc-0007aG-O6 for submit@debbugs.gnu.org; Sun, 20 Oct 2024 03:19:17 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:59806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t2QDa-0007a2-MV for 64055@debbugs.gnu.org; Sun, 20 Oct 2024 03:19:15 -0400 DKIM-Signature: a=rsa-sha256; b=bUWrVMRoUyXHB/ZaajGtJQQcAtlpJJnmnFQ6RoJb5i6WHBNJvWmmoTPsC9oaWySqABfTrT+pTeb7oFiqt3XmjsJeY50DxQ50t7fQLO0kNlHKfS7OmxmFqU2Hj70ADXB6JH60syjVbtwZBxfEFQr9Rs8WvFXmq63oPSrI28VmxeLbZABjV7h2cVxylgZ7OmWxlm5E6PPP40EylMsvMSvzsjkJXJjRz1p11paqvtEP/yeOSZjGEi11T+QEMqWGu/9rWyPsHGHFwFJ+S+RzSRrrCL3p97KB7+kCeN3lKM0JBzClEXbNLG8JDu+VXTjNkGm7iOaVXO6875aWgm4R9LcaVQ==; s=purelymail1; d=spwhitton.name; v=1; bh=GYO1kfuEtybxBq01G6MOW+N9oz1IxIb4gST18UfundQ=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=dvw/lAygabKGSPyRT+QCjgPXkOZii5TiT3aEGC/hGwxrXGkHplqzMuZxOREk9AECTVeshvlprpLNkdWUA5Z4nTzRIw2b+WFH3qQNDk38HXm+1RCt2AOr2IwZrcIdME1H/donKWf064iQoZce8oFpvjftoEwBmbhhY50fKDF67+xhKfiTDqH2ITubH4TgUv0tsX5nExQWhNfRZZCm/Rg0wmD9q5K4vIzmpSh4DbZpH+SUwCBoYwEgoPALhOw83vGrB/loFnEARPRw+P8wvl1nfznKBhl2G1XyDGAf+WUPs7fXqPBg/9ngEgW4XRPC/P5J1t02a+iJ2r+s+onqGC9GeQ==; s=purelymail1; d=purelymail.com; v=1; bh=GYO1kfuEtybxBq01G6MOW+N9oz1IxIb4gST18UfundQ=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 64055@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -859114018; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 20 Oct 2024 07:18:40 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 138677E09E6; Sun, 20 Oct 2024 15:18:38 +0800 (CST) In-Reply-To: <86bjzfjofn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Oct 2024 09:09:16 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293931 Archived-At: Hello, On Sun 20 Oct 2024 at 09:09am +03, Eli Zaretskii wrote: > I see vc-hg-log-switches and vc-bzr-log-switches, so I don't think I > understand why you say Git is special here. What did I miss? By "older VCS" I did not mean to include Hg and bzr, which are special in the same way as Git. And indeed, neither vc-bzr or vc-hg have log-view-modify-change-comment support. It would be good to add it. > In any case, the reason for having a backend method should be > explained in the comments. I've added a FIXME pointing to this bug. Is there somewhere else you have in mind? -- Sean Whitton