bug#74191: 31.0.50; file-directory-p broken when minibuffer-completing-file-name is non nil

bug#74191: 31.0.50; file-directory-p broken when minibuffer-completing-file-name is non nil

[Thierry Volpiatto]

In Emacs-29:

(let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
=>nil

In Emacs-30+:

(let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
=> t

which is wrong obviously.




In GNU Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version
 3.24.33, cairo version 1.16.0) of 2024-09-16 built on IPad-S340
Repository revision: f27553c30a772a0103d2e6762e4d7f588f302e4b
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Linux Mint 21.3

Configured using:
 'configure CFLAGS=-O8 --bindir=/usr/local/sbin/emacs-31.0.50
 --with-cairo --with-modules --without-tree-sitter
 --without-native-compilation'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: fr_FR.UTF-8
  locale-coding-system: utf-8-unix

Major mode: 

Minor modes in effect:
  server-mode: t
  psession-mode: t
  psession-savehist-mode: t
  global-git-gutter-mode: t
  display-time-mode: t
  winner-mode: t
  tv-save-place-mode: t
  helm-epa-mode: t
  helm-descbinds-mode: t
  helm-top-poll-mode: t
  helm-adaptive-mode: t
  helm-mode: t
  helm-minibuffer-history-mode: t
  helm-ff-icon-mode: t
  helm-popup-tip-mode: t
  async-bytecomp-package-mode: t
  dired-async-mode: t
  minibuffer-depth-indicate-mode: t
  gcmh-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  minibuffer-regexp-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort epa-mail face-remap mail-extr addressbook-bookmark
tv-mu4e-config advice gnus-and-mu4e mu4e-patch mu4e-contrib eshell
esh-cmd esh-ext esh-proc esh-opt esh-io esh-arg esh-module
esh-module-loaddefs esh-util mu4e mu4e-org mu4e-notification
notifications mu4e-main smtpmail mu4e-view mu4e-mime-parts mu4e-headers
mu4e-thread mu4e-actions mu4e-compose mu4e-draft gnus-msg mu4e-search
mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message flow-fill hl-line
mu4e-contacts mu4e-update mu4e-folders mu4e-context mu4e-query-items
mu4e-server mu4e-modeline mu4e-vars mu4e-helpers mu4e-config mu4e-window
bookmark ido mu4e-obsolete helm-dabbrev emacsbug tramp-archive
tramp-gvfs tramp-cache time-stamp zeroconf helm-command helm-elisp
helm-eval edebug debug backtrace helm-info helm-ls-git vc-git diff-mode
track-changes emacs-news-mode vc vc-dispatcher flymake-shellcheck
flymake project warnings markdown-mode color org-indent oc-basic
org-element org-persist org-id org-refile org-element-ast inline
avl-tree generator ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc
ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime
gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group
gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail
mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail
yank-media puny rfc822 mml mml-sec mm-decode mm-bodies mm-encode
mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils
mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util
mail-prsvr ol-docview doc-view jka-compr ol-bibtex bibtex ol-bbdb ol-w3m
ol-doi org-link-doi org-config ob-gnuplot org-crypt org-protocol org ob
ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src sh-script smie
treesit executable ob-comint org-pcomplete org-list org-footnote
org-faces org-entities noutline outline org-version ob-emacs-lisp
ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys
oc org-loaddefs find-func org-compat org-macs bug-reference thingatpt
cus-start naquadah-theme solar cal-dst holidays holiday-loaddefs appt
diary-lib diary-loaddefs cal-menu calendar cal-loaddefs server bm
cl-extra imenu tv-utils psession frameset pcase git-gutter mule-util
dired-extension time winner describe-variable help-fns radix-tree
tv-save-place.el init-helm epa derived epg rfc6068 epg-config helm-epa
helm-descbinds cus-edit pp wid-edit helm-sys helm-adaptive helm-mode
helm-misc helm-files image-dired image-dired-tags image-dired-external
image-dired-util image-mode exif filenotify tramp rx trampver
tramp-integration files-x tramp-message help-mode tramp-compat xdg shell
pcomplete parse-time iso8601 time-date tramp-loaddefs helm-buffers
all-the-icons all-the-icons-faces data-material data-weathericons
data-octicons data-fileicons data-faicons data-alltheicons helm-occur
helm-tags helm-locate helm-grep wgrep-helm wgrep grep compile
text-property-search comint ansi-osc ring helm-regexp format-spec
ansi-color helm-utils helm-help helm-types helm-extensions-autoloads
helm-autoloads helm helm-global-bindings helm-easymenu edmacro kmacro
helm-core async-bytecomp helm-source helm-multi-match helm-lib
dired-async async dired-aux dired dired-loaddefs isl-autoloads mb-depth
avoid cus-load gcmh easy-mmode all-the-icons-autoloads info
ledger-mode-autoloads markdown-mode-autoloads w3m-load w3m-autoloads
package browse-url url url-proxy url-privacy url-expand url-methods
url-history url-cookie generate-lisp-file url-domsuf url-util mailcap
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons
password-cache json subr-x map byte-opt gv bytecomp byte-compile
url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs)

Memory information:
((conses 16 801031 433487) (symbols 48 36570 3)
 (strings 32 208077 20114) (string-bytes 1 5167548) (vectors 16 66951)
 (vector-slots 8 631529 601667) (floats 8 2302 1172)
 (intervals 56 75673 125) (buffers 984 145))
<#secure method=pgpmime mode=sign>

-- 
Thierry

bug#74191: 31.0.50; file-directory-p broken when minibuffer-completing-file-name is non nil

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Thierry Volpiatto <thievol@posteo.net> writes:

Hi Thierry,

> In Emacs-29:
>
> (let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
> =>nil
>
> In Emacs-30+:
>
> (let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
> => t
>
> which is wrong obviously.

No, it isn't. It is intended.

It is due to implementation of method, user and host name completion for
remote files.

Best regards, Michael.

bug#74191: 31.0.50; file-directory-p broken when minibuffer-completing-file-name is non nil

[Eli Zaretskii]

> From: Thierry Volpiatto <thievol@posteo.net>
> Date: Sun, 03 Nov 2024 15:42:09 +0000
> 
> 
> In Emacs-29:
> 
> (let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
> =>nil
> 
> In Emacs-30+:
> 
> (let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
> => t
> 
> which is wrong obviously.

Do you have a directory called "/ssh" on your system?

For me, (file-directory-p "/ssh") yields nil even without let-binding
minibuffer-completing-file-name, so I'm not sure I understand the
issue you want to raise.

I also get the same behavior in Emacs 29, btw.

bug#74191: 31.0.50; file-directory-p broken when minibuffer-completing-file-name is non nil

[Thierry Volpiatto]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]


Hi Michael,

Michael Albinus <michael.albinus@gmx.de> writes:

> Thierry Volpiatto <thievol@posteo.net> writes:
>
> Hi Thierry,
>
>> In Emacs-29:
>>
>> (let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
>> =>nil
>>
>> In Emacs-30+:
>>
>> (let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
>> => t
>>
>> which is wrong obviously.
>
> No, it isn't. It is intended.

Hmm, It is perhaps intended and I believe it fixes some problem, but it is
wrong anyway, "/ssh" is NOT a directory.

Can I use file-attributes instead or it is affected as well?

Thanks.


-- 
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 686 bytes --]

bug#74191: 31.0.50; file-directory-p broken when minibuffer-completing-file-name is non nil

[Thierry Volpiatto]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Thierry Volpiatto <thievol@posteo.net>
>> Date: Sun, 03 Nov 2024 15:42:09 +0000
>> 
>> 
>> In Emacs-29:
>> 
>> (let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
>> =>nil
>> 
>> In Emacs-30+:
>> 
>> (let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
>> => t
>> 
>> which is wrong obviously.
>
> Do you have a directory called "/ssh" on your system?

No.

> For me, (file-directory-p "/ssh") yields nil even without let-binding
> minibuffer-completing-file-name,

Of course, here as well, the point is that file-directory-p is not
working anymore when wrapped inside a minibuffer-completing-file-name
let-binding.

-- 
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 686 bytes --]

bug#74191: 31.0.50; file-directory-p broken when minibuffer-completing-file-name is non nil

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Thierry Volpiatto <thievol@posteo.net> writes:

> Hi Michael,

Hi Thierry,

>>> In Emacs-30+:
>>>
>>> (let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
>>> => t
>>>
>>> which is wrong obviously.
>>
>> No, it isn't. It is intended.
>
> Hmm, It is perhaps intended and I believe it fixes some problem, but it is
> wrong anyway, "/ssh" is NOT a directory.

Nobody says so. Remember, we're in file name completion, and Tramp must
trigger some action from the completion machinery. A non-nil return of
file-directory-p is such a trigger.

> Can I use file-attributes instead or it is affected as well?

Should work. Check tramp-completion-file-name-handler-alist. It cares
only about

--8<---------------cut here---------------start------------->8---
((expand-file-name . tramp-completion-handle-expand-file-name)
 (file-directory-p . tramp-completion-handle-file-directory-p)
 (file-exists-p . tramp-completion-handle-file-exists-p)
 (file-name-all-completions . tramp-completion-handle-file-name-all-completions)
 (file-name-completion . tramp-completion-handle-file-name-completion)
 (file-name-directory . tramp-completion-handle-file-name-directory)
 (file-name-nondirectory . tramp-completion-handle-file-name-nondirectory))
--8<---------------cut here---------------end--------------->8---

Alternatively, you could bind temporarily tramp-mode to nil. See
tramp-completion-file-name-handler:

--8<---------------cut here---------------start------------->8---
  (if-let*
      ((fn (and tramp-mode minibuffer-completing-file-name
		(assoc operation tramp-completion-file-name-handler-alist))))
      (save-match-data (apply (cdr fn) args))
    (tramp-run-real-handler operation args)))
--8<---------------cut here---------------end--------------->8---

> Thanks.

Best regards, Michael.

bug#74191: 31.0.50; file-directory-p broken when minibuffer-completing-file-name is non nil

[Thierry Volpiatto]

[-- Attachment #1: Type: text/plain, Size: 2133 bytes --]


Thanks Michael, I finally use a new variable
helm--minibuffer-completing-file-name which doesn't affect
file-directory-p.

Michael Albinus <michael.albinus@gmx.de> writes:

> Thierry Volpiatto <thievol@posteo.net> writes:
>
>> Hi Michael,
>
> Hi Thierry,
>
>>>> In Emacs-30+:
>>>>
>>>> (let ((minibuffer-completing-file-name t)) (file-directory-p "/ssh"))
>>>> => t
>>>>
>>>> which is wrong obviously.
>>>
>>> No, it isn't. It is intended.
>>
>> Hmm, It is perhaps intended and I believe it fixes some problem, but it is
>> wrong anyway, "/ssh" is NOT a directory.
>
> Nobody says so. Remember, we're in file name completion, and Tramp must
> trigger some action from the completion machinery. A non-nil return of
> file-directory-p is such a trigger.
>
>> Can I use file-attributes instead or it is affected as well?
>
> Should work. Check tramp-completion-file-name-handler-alist. It cares
> only about
>
> --8<---------------cut here---------------start------------->8---
> ((expand-file-name . tramp-completion-handle-expand-file-name)
>  (file-directory-p . tramp-completion-handle-file-directory-p)
>  (file-exists-p . tramp-completion-handle-file-exists-p)
>  (file-name-all-completions . tramp-completion-handle-file-name-all-completions)
>  (file-name-completion . tramp-completion-handle-file-name-completion)
>  (file-name-directory . tramp-completion-handle-file-name-directory)
>  (file-name-nondirectory . tramp-completion-handle-file-name-nondirectory))
> --8<---------------cut here---------------end--------------->8---
>
> Alternatively, you could bind temporarily tramp-mode to nil. See
> tramp-completion-file-name-handler:
>
> --8<---------------cut here---------------start------------->8---
>   (if-let*
>       ((fn (and tramp-mode minibuffer-completing-file-name
> 		(assoc operation tramp-completion-file-name-handler-alist))))
>       (save-match-data (apply (cdr fn) args))
>     (tramp-run-real-handler operation args)))
> --8<---------------cut here---------------end--------------->8---
>
>> Thanks.
>
> Best regards, Michael.

-- 
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 686 bytes --]

bug#74191: 31.0.50; file-directory-p broken when minibuffer-completing-file-name is non nil

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Thierry Volpiatto <thievol@posteo.net> writes:

Hi Thierry,

> Thanks Michael, I finally use a new variable
> helm--minibuffer-completing-file-name which doesn't affect
> file-directory-p.

So I close the bug. Nothing left to do.

Best regards, Michael.