From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74781: [PATCH] Add `browse-url-qutebrowser' Date: Wed, 11 Dec 2024 16:54:48 +0100 Message-ID: <87zfl29pvb.fsf@daniel-mendler.de> References: <87msh21z0i.fsf@daniel-mendler.de> <865xnq4720.fsf@gnu.org> <87pllyuuco.fsf@daniel-mendler.de> <871pye5in8.fsf@gmail.com> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6112"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 74781@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 11 16:55:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLP3d-0001IF-Qt for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Dec 2024 16:55:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLP3I-0003nt-Mt; Wed, 11 Dec 2024 10:55:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLP3G-0003mG-O4 for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 10:55:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLP3G-00040e-7M for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 10:55:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=gUHz6fPGIkBICZ+NFsdVHlHwKfo9X7oNpOhcAr1SKDk=; b=b0vRetSXwgh8GYnffT0+3TMwIs7CotvBRZBCxyvhuM3S+suiVyHT7bovL7llOuIZzmoNZ8u8NcvEaKdUDCWNd7leUJa98NmMphzipLkovDWgSWN7k4Ww1cVZ2AjtNaNr4vOSwaGjqvyWUHu7Z8oxMaFkf2Ku1fXKHXMCWM/Cr3+PjiUDdQ1rw/VDRjA6Ysp2DjLkRxwFJJAAyswQ64MqcGYWsRYvE19Gk9XBF70ALZZ8V+nRgKcTqoHOogxKVwcAI/hxqT/8+GEn3/CfbCC5VA9sPtB7KqTCm54ck5PSNt724UZL5jptP5ITRCoyhuYRyWrocUYWlvifFqMBv4zIsg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLP3G-0000KX-15 for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 10:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2024 15:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74781-submit@debbugs.gnu.org id=B74781.17339324971252 (code B ref 74781); Wed, 11 Dec 2024 15:55:01 +0000 Original-Received: (at 74781) by debbugs.gnu.org; 11 Dec 2024 15:54:57 +0000 Original-Received: from localhost ([127.0.0.1]:35808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLP3B-0000K8-Ck for submit@debbugs.gnu.org; Wed, 11 Dec 2024 10:54:57 -0500 Original-Received: from server.qxqx.de ([49.12.34.165]:37907 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLP39-0000Jk-CU for 74781@debbugs.gnu.org; Wed, 11 Dec 2024 10:54:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gUHz6fPGIkBICZ+NFsdVHlHwKfo9X7oNpOhcAr1SKDk=; b=x9enQQhnofQJAnsRM5bkpowziR A3QwwE66S80SZW5u6KuAeL7g3bWpdlv4P+rLth44zbvx9ZyLCCyDjig9F8jKY91ylQ7EzXXf1+/7P 4btbxAX8WhWL2Qu7SpNC1Tr7noCoK3aLE2+2FkUrcndZYcwB8ruPePsjHwg9BUWItKWQ=; In-Reply-To: <871pye5in8.fsf@gmail.com> (Robert Pluim's message of "Wed, 11 Dec 2024 16:44:27 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296843 Archived-At: Robert Pluim writes: >>>>>> On Wed, 11 Dec 2024 16:12:23 +0100, Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" said: > > Daniel> Hello Eli, > Daniel> thanks. I added the version tags, the NEWS entry, improved the > Daniel> docstrings and use `xdg-runtime-dir' now. See the updated patch > Daniel> attached to this mail. > > >>> + (sock (and dir (expand-file-name > >>> + (format "qutebrowser/ipc-%s" (md5 (user-login-name))) > >>> + dir)))) > >> > >> I think Qutebrowser is available on Windows, where we don't (yet) > >> support local sockets. So I think there should be some kind of test > >> for running on Windows, and falling back to alternatives. > > Daniel> On Windows, the socket won't be there, and the new Qutebrowser window > Daniel> will be opened by the newly executed Qutebrowser process via > Daniel> `call-process'. This will work but is unfortunately slower. > > And it will check for the socket for every URL. Could you perhaps test > whether to use the socket or not just once, and then use the > appropriate call? There is only the cheap `file-exists-p' check. It should be fast, in comparison to what comes after that - the socket creation or the process creation. Daniel