unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 74781@debbugs.gnu.org
Subject: bug#74781: [PATCH] Add `browse-url-qutebrowser'
Date: Wed, 11 Dec 2024 16:54:48 +0100	[thread overview]
Message-ID: <87zfl29pvb.fsf@daniel-mendler.de> (raw)
In-Reply-To: <871pye5in8.fsf@gmail.com> (Robert Pluim's message of "Wed, 11 Dec 2024 16:44:27 +0100")

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Wed, 11 Dec 2024 16:12:23 +0100, Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> said:
>
>     Daniel> Hello Eli,
>     Daniel> thanks. I added the version tags, the NEWS entry, improved the
>     Daniel> docstrings and use `xdg-runtime-dir' now. See the updated patch
>     Daniel> attached to this mail.
>
>     >>> +         (sock (and dir (expand-file-name
>     >>> +                         (format "qutebrowser/ipc-%s" (md5 (user-login-name)))
>     >>> +                         dir))))
>     >> 
>     >> I think Qutebrowser is available on Windows, where we don't (yet)
>     >> support local sockets.  So I think there should be some kind of test
>     >> for running on Windows, and falling back to alternatives.
>
>     Daniel> On Windows, the socket won't be there, and the new Qutebrowser window
>     Daniel> will be opened by the newly executed Qutebrowser process via
>     Daniel> `call-process'. This will work but is unfortunately slower.
>
> And it will check for the socket for every URL. Could you perhaps test
> whether to use the socket or not just once, and then use the
> appropriate call?

There is only the cheap `file-exists-p' check. It should be fast, in
comparison to what comes after that - the socket creation or the process
creation.

Daniel





  reply	other threads:[~2024-12-11 15:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11  7:04 bug#74781: [PATCH] Add `browse-url-qutebrowser' Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11  8:27 ` Robert Pluim
2024-12-11  9:07   ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11  9:58     ` Robert Pluim
2024-12-11 10:45       ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 14:14         ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 14:38           ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 16:16             ` Eli Zaretskii
2024-12-11 15:32         ` Eli Zaretskii
2024-12-11 15:36           ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 14:40 ` Eli Zaretskii
2024-12-11 15:12   ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 15:44     ` Robert Pluim
2024-12-11 15:54       ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-12-11 16:54     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfl29pvb.fsf@daniel-mendler.de \
    --to=bug-gnu-emacs@gnu.org \
    --cc=74781@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mail@daniel-mendler.de \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).