From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Yavor Doganov Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#1230: `configure --with-ns' fails when the shell is not bash Date: Thu, 23 Oct 2008 14:38:24 +0300 Organization: The GNU Emacs Church (Bulgarian eparchy) Message-ID: <87y70fsfrj.GNU's_Not_Unix!%yavor@gnu.org> Reply-To: Yavor Doganov , 1230@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1224762657 11769 80.91.229.12 (23 Oct 2008 11:50:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Oct 2008 11:50:57 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 23 13:51:58 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ksyj9-0001tc-Eu for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Oct 2008 13:51:43 +0200 Original-Received: from localhost ([127.0.0.1]:57246 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ksyi3-00010n-Sz for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Oct 2008 07:50:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ksyi0-00010R-7m for bug-gnu-emacs@gnu.org; Thu, 23 Oct 2008 07:50:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ksyhy-000103-4o for bug-gnu-emacs@gnu.org; Thu, 23 Oct 2008 07:50:31 -0400 Original-Received: from [199.232.76.173] (port=60084 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ksyhx-0000zw-UI for bug-gnu-emacs@gnu.org; Thu, 23 Oct 2008 07:50:29 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:33663) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ksyhu-00057v-AN; Thu, 23 Oct 2008 07:50:26 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9NBo10D009796; Thu, 23 Oct 2008 04:50:01 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9NBj3Tl008652; Thu, 23 Oct 2008 04:45:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Yavor Doganov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: yavor@gnu.org, Emacs Bugs , don@donarmstrong.com Resent-Date: Thu, 23 Oct 2008 11:45:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1230 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: patch Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12247619247398 (code B ref -1); Thu, 23 Oct 2008 11:45:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 23 Oct 2008 11:38:44 +0000 Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9NBcaxA007391 for ; Thu, 23 Oct 2008 04:38:37 -0700 Original-Received: from mx10.gnu.org ([199.232.76.166]:56174) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KsyTp-0006O6-PO for emacs-pretest-bug@gnu.org; Thu, 23 Oct 2008 07:35:53 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KsyWQ-0001lZ-WD for emacs-pretest-bug@gnu.org; Thu, 23 Oct 2008 07:38:35 -0400 Original-Received: from [213.91.219.2] (port=1231 helo=southway-varna.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KsyWQ-0001ki-9w for emacs-pretest-bug@gnu.org; Thu, 23 Oct 2008 07:38:34 -0400 Original-Received: from keel.southway-varna.com ([192.168.0.2]) by southway-varna.com with esmtp (Exim 4.63) (envelope-from ) id 1KsyWG-0006HA-LP for emacs-pretest-bug@gnu.org; Thu, 23 Oct 2008 14:38:29 +0300 Original-Received: from localhost ([127.0.0.1] helo=keel.southway-varna.com) by keel.southway-varna.com with esmtp (Exim 4.69) (envelope-from ) id 1KsyWG-000121-Ef for emacs-pretest-bug@gnu.org; Thu, 23 Oct 2008 14:38:24 +0300 User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 =?UTF-8?Q?(Goj=C5=8D)?= APEL/10.7 Emacs/22.2 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI) X-Jabber-ID: doganov@jabber.minus273.org X-SA-Exim-Connect-IP: 192.168.0.2 X-SA-Exim-Mail-From: yavor@gnu.org X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on southway-varna.com) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 23 Oct 2008 07:50:31 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21826 gmane.emacs.pretest.bugs:23291 Archived-At: Package: emacs,ns Tags: patch $ CONFIG_SHELL=3D/bin/dash /bin/dash ./configure --with-ns ... checking for X... libraries , headers=20 ./configure.lineno: 9373: source: not found ./configure.lineno: 9373: source: not found ./configure.lineno: 9373: source: not found checking AppKit/AppKit.h usability... no checking AppKit/AppKit.h presence... no checking for AppKit/AppKit.h... no That's because "source" is a bash feature. But at this point one would expect that configure should exit with an error. However, it continues, checks for GTK+ and finally fails for me because of missing image librararies. If I had them installed on this machine, it would really configure Emacs for a GTK build. This can't be right; if the user says `--with-ns' he really means that. The attached patch addresses both issues. 2008-10-23 Yavor Doganov (tiny change) * configure.in: Use `.' instead of `source' to source GNUstep.conf. Exit with an error if `--with-ns' was specified but is not found. --- configure.in 23 =D0=BE=D0=BA=D1=82 2008 13:56:25 +0300 1.568 +++ configure.in 23 =D0=BE=D0=BA=D1=82 2008 14:13:27 +0300=09 @@ -1234,15 +1234,17 @@ ns_appbindir=3D`pwd`/nextstep/Emacs.app ns_appresdir=3D`pwd`/nextstep/Emacs.app/Resources ns_appsrc=3D${srcdir}/nextstep/GNUstep/Emacs.base - GNUSTEP_MAKEFILES=3D"$(source /etc/GNUstep/GNUstep.conf; echo $GNUSTE= P_MAKEFILES)" - GNUSTEP_SYSTEM_HEADERS=3D"$(source /etc/GNUstep/GNUstep.conf; echo $G= NUSTEP_SYSTEM_HEADERS)" - GNUSTEP_SYSTEM_LIBRARIES=3D"$(source /etc/GNUstep/GNUstep.conf; echo = $GNUSTEP_SYSTEM_LIBRARIES)" + GNUSTEP_MAKEFILES=3D"$(. /etc/GNUstep/GNUstep.conf; echo $GNUSTEP_MAK= EFILES)" + GNUSTEP_SYSTEM_HEADERS=3D"$(. /etc/GNUstep/GNUstep.conf; echo $GNUSTE= P_SYSTEM_HEADERS)" + GNUSTEP_SYSTEM_LIBRARIES=3D"$(. /etc/GNUstep/GNUstep.conf; echo $GNUS= TEP_SYSTEM_LIBRARIES)" CPPFLAGS=3D"$CPPFLAGS -I${GNUSTEP_SYSTEM_HEADERS}" CFLAGS=3D"$CFLAGS -I${GNUSTEP_SYSTEM_HEADERS}" REAL_CFLAGS=3D"$REAL_CFLAGS -I${GNUSTEP_SYSTEM_HEADERS}" LDFLAGS=3D"$LDFLAGS -L${GNUSTEP_SYSTEM_LIBRARIES}" fi - AC_CHECK_HEADER(AppKit/AppKit.h, HAVE_NS=3Dyes) + AC_CHECK_HEADER([AppKit/AppKit.h], [HAVE_NS=3Dyes], + [AC_MSG_ERROR([`--with-ns' was specified, but the include + files are missing or cannot be compiled.])]) NS_HAVE_NSINTEGER=3Dyes AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include ], [NSInteger i;])],