unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Sven Joachim <svenjoac@gmx.de>
To: bug-gnu-emacs@gnu.org
Subject: bug#1739: [Toby Speight] Broken host regexps in generic-x
Date: Tue, 30 Dec 2008 09:51:15 +0100	[thread overview]
Message-ID: <87y6xy3v24.fsf@turtle.gmx.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]

Tags: patch

Another old bug in Debian's BTS, this time with a patch.  The patch
doesn't apply anymore, but it was easy for me to create a new one:

--8<---------------cut here---------------start------------->8---
--- generic-x.el.~1.55.~	2008-10-04 05:11:46.000000000 +0200
+++ generic-x.el	2008-12-30 09:45:00.000000000 +0100
@@ -376,7 +376,7 @@
 (define-generic-mode hosts-generic-mode
   '(?#)
   '("localhost")
-  '(("\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 font-lock-constant-face))
+  '(("\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 font-lock-constant-face))
   '("[hH][oO][sS][tT][sS]\\'")
   nil
   "Generic mode for HOSTS files."))
@@ -1811,7 +1811,7 @@
   '("cache" "primary" "secondary" "forwarders" "limit" "options"
     "directory" "check-names")
   ;; List of additional font-lock-expressions
-  '(("\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 font-lock-constant-face)
+  '(("\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 font-lock-constant-face)
     ("^directory\\s-+\\(.*\\)"              1 font-lock-variable-name-face)
     ("^\\(primary\\|cache\\)\\s-+\\([.A-Za-z]+\\)\\s-+\\(.*\\)"
      (2 font-lock-variable-name-face)
@@ -1829,7 +1829,7 @@
   ;; List of keywords
   '("IN" "NS" "CNAME" "SOA" "PTR" "MX" "A")
   ;; List of additional font-lock-expressions
-  '(("\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 font-lock-constant-face)
+  '(("\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 font-lock-constant-face)
     ("^\\([.A-Za-z0-9]+\\)"                 1 font-lock-variable-name-face))
   ;; List of additional auto-mode-alist expressions
   nil
--8<---------------cut here---------------end--------------->8---


[-- Attachment #2: Type: message/rfc822, Size: 4273 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 283 bytes --]

Package: emacs21-common
Version: 21.3+1-4
Severity: normal
Tags: patch
File: /usr/share/emacs/21.3/lisp/generic-x.el

Some of the regexps in generic-x have only single backslashes to
escape '.' characters - the result being that they match any
character, including '.' - see patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: generic-x.diff --]
[-- Type: text/x-patch, Size: 1331 bytes --]

--- /usr/share/emacs/21.3/lisp/generic-x.el	2003-10-31 18:30:36.000000000 +0000
+++ generic-x.el	2004-03-22 11:55:06.000000000 +0000
@@ -258,7 +258,7 @@
 (define-generic-mode 'hosts-generic-mode
    (list ?#)
    (list "localhost")
-   '(("\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 'font-lock-constant-face))
+   '(("\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 'font-lock-constant-face))
    (list "[hH][oO][sS][tT][sS]\\'")
    nil
    "Generic mode for HOSTS files."))
@@ -1681,7 +1681,7 @@
         "directory" "check-names")
   ;;List of additional font-lock-expressions
   (list
-   (list "\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 'font-lock-constant-face)
+   (list "\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 'font-lock-constant-face)
    (list "^directory\\s-+\\(.*\\)" 1 'font-lock-variable-name-face)
    (list "^\\(primary\\|cache\\)\\s-+\\([.A-Za-z]+\\)\\s-+\\(.*\\)"
          (list 2 'font-lock-variable-name-face)
@@ -1700,7 +1700,7 @@
   (list "IN" "NS" "CNAME" "SOA" "PTR" "MX" "A")
   ;;List of additional font-lock-expressions
   (list
-   (list "\\([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\\)" 1 'font-lock-constant-face)
+   (list "\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\)" 1 'font-lock-constant-face)
    (list "^\\([.A-Za-z0-9]+\\)" 1 'font-lock-variable-name-face)
    )
   ;;List of additional automode-alist expressions

[-- Attachment #2.1.3: Type: text/plain, Size: 639 bytes --]


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing'), (300, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.24
Locale: LANG=en_GB, LC_CTYPE=en_GB (ignored: LC_ALL set to en_GB)

Versions of packages emacs21-common depends on:
ii  dpkg                        1.10.19      Package maintenance system for Deb
ii  emacsen-common              1.4.15       Common facilities for all emacsen.
ii  libc6                       2.3.2.ds1-11 GNU C Library: Shared libraries an
ii  liblockfile1                1.05         NFS-safe locking library, includes

-- no debconf information


             reply	other threads:[~2008-12-30  8:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0q7i4dfoa3.fsf@fencepost.gnu.org>
2008-12-30  8:51 ` Sven Joachim [this message]
2009-01-30  3:55   ` bug#1739: marked as done ([Toby Speight] Broken host regexps in generic-x) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6xy3v24.fsf@turtle.gmx.de \
    --to=svenjoac@gmx.de \
    --cc=1739@emacsbugs.donarmstrong.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).