unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#7645: 23.2; ido commands failed to execute if there is some killed buffer
@ 2010-12-15  6:07 Abaw
  2010-12-15  8:29 ` Glenn Morris
  0 siblings, 1 reply; 7+ messages in thread
From: Abaw @ 2010-12-15  6:07 UTC (permalink / raw)
  To: 7645


[-- Attachment #1.1: Type: text/plain, Size: 1496 bytes --]

Hi maintainers,

ido commands that finally calls ``ido-make-buffer-list'' would fail to
execute if there is some killed buffer returned by
``buffer-list''. Because (buffer-name a-killed-buffer) will return nil,
``ido-ignore-item-p'' fail to treat it as a stream. My solution is to
return non-nil if name passed to ``ido-ignore-item-p'' is nil.

The attachment is the patch I made for ido.el.


In GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0)
of 2010-08-15 on raven, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.60900000
configured using `configure '--build' 'i486-linux-gnu' '--build'
'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib'
'--libexecdir=/usr/lib' '--localstatedir=/var/lib'
'--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes'
'--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.2/leim'
'--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars'
'build_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g'
'CPPFLAGS=''

Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default enable-multibyte-characters: t

[-- Attachment #1.2: Type: text/html, Size: 1854 bytes --]

[-- Attachment #2: ido.el.patch --]
[-- Type: application/octet-stream, Size: 437 bytes --]

--- ido.orig.el	2010-12-15 13:44:36.000000000 +0800
+++ ido.el	2010-12-15 13:44:49.000000000 +0800
@@ -3768,7 +3768,8 @@
 
 (defun ido-ignore-item-p (name re-list &optional ignore-ext)
   ;; Return t if the buffer or file NAME should be ignored.
-  (or (member name ido-ignore-item-temp-list)
+  (or (null name)
+      (member name ido-ignore-item-temp-list)
       (and
        ido-process-ignore-lists re-list
        (save-match-data

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-04-27 13:35 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-15  6:07 bug#7645: 23.2; ido commands failed to execute if there is some killed buffer Abaw
2010-12-15  8:29 ` Glenn Morris
     [not found]   ` <AANLkTimtHeYp1YzjUu3gPH=5+ax1rY8GiMN+g4yr8dq7@mail.gmail.com>
2010-12-15 15:31     ` bug#7645: Fwd: " Abaw
2011-01-22 20:03       ` Chong Yidong
2011-04-27  8:28         ` Leo
2011-04-27 12:58           ` Drew Adams
2011-04-27 13:35           ` martin rudalics

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).