From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string Date: Wed, 25 May 2011 15:31:16 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87y61uldyj.fsf@lifelogs.com> References: <87d3j932n7.fsf@lifelogs.com> <87zkmaopfs.fsf@lifelogs.com> <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B@simplegeo.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306355531 11684 80.91.229.12 (25 May 2011 20:32:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 25 May 2011 20:32:11 +0000 (UTC) To: Ian Eure , <8706@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 25 22:32:07 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QPKkQ-0008NO-CZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 May 2011 22:32:06 +0200 Original-Received: from localhost ([::1]:38696 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPKkQ-0002ws-0K for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 May 2011 16:32:06 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:45931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPKkO-0002wZ-2c for bug-gnu-emacs@gnu.org; Wed, 25 May 2011 16:32:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPKkM-0008SG-Ua for bug-gnu-emacs@gnu.org; Wed, 25 May 2011 16:32:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPKkM-0008SB-RU for bug-gnu-emacs@gnu.org; Wed, 25 May 2011 16:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QPKkM-0003v4-BK; Wed, 25 May 2011 16:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ted Zlatanov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2011 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8706-submit@debbugs.gnu.org id=B8706.130635548615017 (code B ref 8706); Wed, 25 May 2011 20:32:02 +0000 Original-Received: (at 8706) by debbugs.gnu.org; 25 May 2011 20:31:26 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QPKjm-0003u9-EM for submit@debbugs.gnu.org; Wed, 25 May 2011 16:31:26 -0400 Original-Received: from chirelay1o.jumptrading.com ([38.98.147.153] helo=chirelay1.jumptrading.com) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QPKjk-0003ty-NG for 8706@debbugs.gnu.org; Wed, 25 May 2011 16:31:25 -0400 Original-Received: from chirelay1.jumptrading.com (unknown [127.0.0.1]) by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id 127E632003E for <8706@debbugs.gnu.org>; Wed, 25 May 2011 15:31:19 -0500 (CDT) X-AuditID: 26629395-9b166bb0000049d2-6c-4ddd67160b6a Original-Received: from chiexchange02.w2k.jumptrading.com (unknown [38.98.147.140]) by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id C54992DC006 for <8706@debbugs.gnu.org>; Wed, 25 May 2011 15:31:18 -0500 (CDT) Original-Received: from internalsmtp.w2k.jumptrading.com (10.2.4.29) by chiexchange02.w2k.jumptrading.com (10.2.4.71) with Microsoft SMTP Server id 8.1.291.1; Wed, 25 May 2011 15:31:18 -0500 Original-Received: from tzlatanov-ubuntu-desktop.jumptrading.com ([10.2.14.81]) by internalsmtp.w2k.jumptrading.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 25 May 2011 15:31:18 -0500 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" In-Reply-To: <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B@simplegeo.com> (Ian Eure's message of "Wed, 25 May 2011 09:32:15 -0700") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-OriginalArrivalTime: 25 May 2011 20:31:18.0270 (UTC) FILETIME=[B39221E0:01CC1B1A] X-Brightmail-Tracker: AAAAAA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 25 May 2011 16:32:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46704 Archived-At: On Wed, 25 May 2011 09:32:15 -0700 Ian Eure wrote: IE> 1. Two-element sequences should work as they do now. IE> 2. One-element sequences should get an empty string appended. IE> 3. Invalid sequences ignored. IE> I'm not sure it makes sense to support #2, since it seems somewhat IE> opaque and you can do the same thing with an empty string in scenario IE> #1. Single-element parameters, shown as just "key" instead of "key=val", are a well-known URL query string convention. They are not opaque. I think they should be explicitly supported. IE> #3 I'm not sure how to do without using remove-if from cl-seq. IE> I don't know why someone would pass in nil in place of a k/v pair, and IE> it seems better to raise an error about that rather than silently IE> accepting it, since it seems likely to be an error in the calling IE> code. OK, let's make #3 an error. That works for me. Can you just comment on it in the source so it's clear we punt to the caller? Thanks! Ted