From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#8838: tty-run-terminal-initialization fails Date: Sun, 12 Jun 2011 17:42:59 -0500 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: <87y616hdsc.fsf@lifelogs.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1307918671 20336 80.91.229.12 (12 Jun 2011 22:44:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 12 Jun 2011 22:44:31 +0000 (UTC) Cc: 8838@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 13 00:44:27 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QVtOM-00046s-Cx for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 Jun 2011 00:44:26 +0200 Original-Received: from localhost ([::1]:47270 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QVtOL-0001oQ-Lp for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 Jun 2011 18:44:25 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:39908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QVtO2-0001nt-BE for bug-gnu-emacs@gnu.org; Sun, 12 Jun 2011 18:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QVtNz-0006yj-EK for bug-gnu-emacs@gnu.org; Sun, 12 Jun 2011 18:44:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QVtNz-0006yN-3i for bug-gnu-emacs@gnu.org; Sun, 12 Jun 2011 18:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QVtNy-0001I4-1d; Sun, 12 Jun 2011 18:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ted Zlatanov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Jun 2011 22:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8838 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8838-submit@debbugs.gnu.org id=B8838.13079185894890 (code B ref 8838); Sun, 12 Jun 2011 22:44:01 +0000 Original-Received: (at 8838) by debbugs.gnu.org; 12 Jun 2011 22:43:09 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QVtN6-0001Go-GG for submit@debbugs.gnu.org; Sun, 12 Jun 2011 18:43:08 -0400 Original-Received: from z.lifelogs.com ([173.255.230.239]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QVtN3-0001GH-Ui for 8838@debbugs.gnu.org; Sun, 12 Jun 2011 18:43:06 -0400 Original-Received: from heechee (c-67-186-102-106.hsd1.il.comcast.net [67.186.102.106]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tzz) by z.lifelogs.com (Postfix) with ESMTPSA id 5C5DC6200E; Sun, 12 Jun 2011 22:43:00 +0000 (UTC) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Glenn Morris's message of "Sat, 11 Jun 2011 18:54:24 -0400") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 12 Jun 2011 18:44:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47103 Archived-At: On Sat, 11 Jun 2011 18:54:24 -0400 Glenn Morris wrote: GM> Glenn Morris wrote: >> tty-run-terminal-initialization: Wrong type argument: number-or-marker-p, nil GM> The error comes from terminal-init-xterm at line 542, where version is nil. Thank you for fixing that with rev 104578 through 104575 (104575 was the essential fix). GM> I also noticed a pointless check at line 511: GM> (when xterm-extra-capabilities GM> This code is already inside a "(when xterm-extra-capabilities" at line 488. Thanks for catching that too, plus your other style fixes and simplifications. I disagree with replacing `when' with `if' in the case of just one clause, which you did in several places. Rather than simplifying the code, it complicates reading it IMO. Since `when' is a macro I think any performance gains are minor. Ted