unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 8838@debbugs.gnu.org
Subject: bug#8838: tty-run-terminal-initialization fails
Date: Sun, 12 Jun 2011 17:42:59 -0500	[thread overview]
Message-ID: <87y616hdsc.fsf@lifelogs.com> (raw)
In-Reply-To: <o6tybwf07z.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sat, 11 Jun 2011 18:54:24 -0400")

On Sat, 11 Jun 2011 18:54:24 -0400 Glenn Morris <rgm@gnu.org> wrote: 

GM> Glenn Morris wrote:
>> tty-run-terminal-initialization: Wrong type argument: number-or-marker-p, nil

GM> The error comes from terminal-init-xterm at line 542, where version is nil.

Thank you for fixing that with rev 104578 through 104575 (104575 was the
essential fix).

GM> I also noticed a pointless check at line 511:

GM> (when xterm-extra-capabilities

GM> This code is already inside a "(when xterm-extra-capabilities" at line 488.

Thanks for catching that too, plus your other style fixes and
simplifications.

I disagree with replacing `when' with `if' in the case of just one
clause, which you did in several places.  Rather than simplifying the
code, it complicates reading it IMO.  Since `when' is a macro I think
any performance gains are minor.

Ted





  parent reply	other threads:[~2011-06-12 22:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-11 22:15 bug#8838: tty-run-terminal-initialization fails Glenn Morris
2011-06-11 22:54 ` Glenn Morris
2011-06-12 17:03   ` Eli Zaretskii
2011-06-12 22:42   ` Ted Zlatanov [this message]
2011-06-14 16:54     ` Ted Zlatanov
2011-06-14 17:16       ` Glenn Morris
2011-06-14 17:54         ` Glenn Morris
2011-06-12  3:03 ` Eli Zaretskii
2011-06-12  5:52   ` Glenn Morris
2011-06-12  7:46   ` Andreas Schwab
2011-06-12 18:08     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y616hdsc.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=8838@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).