From: David Engster <deng@randomsample.de>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: 11981@debbugs.gnu.org, Michael Albinus <michael.albinus@gmx.de>
Subject: bug#11981: 24.1.50; url-http-parse-headers should not disable file name handlers since it breaks auth-source
Date: Sun, 12 Aug 2012 16:52:47 +0200 [thread overview]
Message-ID: <87y5lkcgcg.fsf@engster.org> (raw)
In-Reply-To: <557CA48A-899E-4DCA-A22F-46EF0AC3CEFA@swipnet.se> ("Jan \=\?iso-8859-1\?Q\?Dj\=E4rv\=22's\?\= message of "Mon, 6 Aug 2012 19:18:21 +0200")
Jan Djärv writes:
> Hello.
>
> 6 aug 2012 kl. 18:01 skrev Stefan Monnier:
>
>>> @@ -246,18 +246,24 @@
>>> "Return the directory part of FILE, for a URL."
>>> (cond
>>> ((null file) "")
>>> - ((string-match "\\?" file)
>>> - (file-name-directory (substring file 0 (match-beginning 0))))
>>> - (t (file-name-directory file))))
>>> + ((string-match "\\(\\?\\|%3[fF]\\)" file)
>>> + (url-file-directory (substring file 0 (match-beginning 0))))
>>
>> Should %3F really be treated like a ? (i.e. a special char that
>> delimits two different parts of a URL) rather than like "a normal ?
>> character encoded so as not to delimit two different parts of a URL"?
>>
>
> A normal non-delimiting ?. How else can one get a ? in to an URL?
You are both right, of course; I was overcompensating. The match for
%3[fF] must be removed.
-David
next prev parent reply other threads:[~2012-08-12 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 18:38 bug#11981: 24.1.50; url-http-parse-headers should not disable file name handlers since it breaks auth-source David Engster
2012-07-19 6:35 ` Michael Albinus
2012-07-19 8:55 ` Stefan Monnier
2012-07-19 12:51 ` David Engster
2012-07-21 14:31 ` David Engster
2012-08-06 16:01 ` Stefan Monnier
2012-08-06 17:18 ` Jan Djärv
2012-08-12 14:52 ` David Engster [this message]
2012-08-12 17:36 ` Stefan Monnier
2012-08-13 19:23 ` David Engster
2012-08-14 14:55 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5lkcgcg.fsf@engster.org \
--to=deng@randomsample.de \
--cc=11981@debbugs.gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).