From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#10885: Replace expressions: enhance functionality when searching in filled paragraphs Date: Thu, 06 Sep 2012 11:54:12 +0300 Organization: JURTA Message-ID: <87y5knpm4r.fsf@mail.jurta.org> References: <33392837.post@talk.nabble.com> <1oipiuxspa.fsf@fencepost.gnu.org> <87d38z1bp3.fsf@mail.jurta.org> <87linm79pc.fsf@mail.jurta.org> <8762ebbehj.fsf@mail.jurta.org> <87oblo21xe.fsf@mail.jurta.org> <87boho1wyz.fsf@mail.jurta.org> <87ligozwx1.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1346921887 27923 80.91.229.3 (6 Sep 2012 08:58:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Sep 2012 08:58:07 +0000 (UTC) Cc: 10885-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 06 10:58:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T9Xua-0000Ht-9M for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Sep 2012 10:58:08 +0200 Original-Received: from localhost ([::1]:48093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9XuX-0005Ro-DK for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Sep 2012 04:58:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9XuP-0005JK-B5 for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2012 04:58:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9XuJ-0008NM-Kl for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2012 04:57:57 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9XuJ-0008NI-HI for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2012 04:57:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T9XuU-0004wc-6D for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2012 04:58:02 -0400 Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Sep 2012 08:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 10885 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 10885@debbugs.gnu.org, juri@jurta.org Original-Received: via spool by 10885-done@debbugs.gnu.org id=D10885.134692183718947 (code D ref 10885); Thu, 06 Sep 2012 08:58:01 +0000 Original-Received: (at 10885-done) by debbugs.gnu.org; 6 Sep 2012 08:57:17 +0000 Original-Received: from localhost ([127.0.0.1]:42149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9Xti-0004vW-S0 for submit@debbugs.gnu.org; Thu, 06 Sep 2012 04:57:16 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:51304 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9Xtb-0004vA-UJ for 10885-done@debbugs.gnu.org; Thu, 06 Sep 2012 04:57:11 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id C8DA0451CB38; Thu, 6 Sep 2012 01:56:54 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 05 Sep 2012 10:38:59 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63833 Archived-At: >> Since query-replace is going in the direction of closer integration with >> isearch, the right thing would be to get its search function from isearch. > > Agreed. Installed. Since this enhancement request is completely implemented, and all mentioned problems are fixed, I'm closing it. >> (defun replace-highlight (match-beg match-end range-beg range-end >> - string regexp case-fold) >> + string regexp word case-fold) > > Maybe we should use an isearch-state argument? Actually these arguments correspond to the variables of `perform-replace', not isearch state. So I renamed them to the names used in `perform-replace', causing isearch-related let-bindings in `replace-highlight' to be the exact copy of let-bindings in `perform-replace'.