unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 10885-done@debbugs.gnu.org
Subject: bug#10885: Replace expressions: enhance functionality when searching in filled paragraphs
Date: Thu, 06 Sep 2012 11:54:12 +0300	[thread overview]
Message-ID: <87y5knpm4r.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvehmgzgb5.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 05 Sep 2012 10:38:59 -0400")

>> Since query-replace is going in the direction of closer integration with
>> isearch, the right thing would be to get its search function from isearch.
>
> Agreed.

Installed.  Since this enhancement request is completely implemented,
and all mentioned problems are fixed, I'm closing it.

>>  (defun replace-highlight (match-beg match-end range-beg range-end
>> -			  string regexp case-fold)
>> +			  string regexp word case-fold)
>
> Maybe we should use an isearch-state argument?

Actually these arguments correspond to the variables of `perform-replace',
not isearch state.  So I renamed them to the names used in `perform-replace',
causing isearch-related let-bindings in `replace-highlight' to be
the exact copy of let-bindings in `perform-replace'.





  reply	other threads:[~2012-09-06  8:54 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-26  1:02 bug#10885: Replace expressions: enhance functionality when searching in filled paragraphs linuxfever
2012-02-26  1:57 ` Glenn Morris
2012-02-26  7:16   ` Kevin Rodgers
2012-02-28 10:04     ` Dani Moncayo
2012-02-28 10:09       ` Dani Moncayo
2012-02-28 10:42       ` Juri Linkov
2012-02-29  0:12         ` Glenn Morris
2012-02-29  0:41           ` Juri Linkov
2012-03-11  8:59             ` Dani Moncayo
2012-03-11 10:48               ` Juri Linkov
2012-09-02  9:45                 ` Juri Linkov
2012-09-02 11:32                   ` Juri Linkov
2012-09-05  8:38                     ` Juri Linkov
2012-09-05 14:38                       ` Stefan Monnier
2012-09-06  8:54                         ` Juri Linkov [this message]
2012-09-06 15:54                           ` Dani Moncayo
2012-09-06 16:50                             ` Juri Linkov
2012-09-06 17:39                               ` Dani Moncayo
2012-09-06 19:11                                 ` Juri Linkov
2012-09-06 19:15                                   ` Juri Linkov
2012-09-06 19:45                                   ` Dani Moncayo
2012-09-06 20:21                                     ` Dani Moncayo
2012-09-06 21:25                               ` Stefan Monnier
2012-09-07  8:33                                 ` Dani Moncayo
2012-09-07  9:28                                   ` Juri Linkov
2012-09-09 22:15                                     ` Juri Linkov
2012-09-05 14:39                       ` Stefan Monnier
2012-02-26 10:10   ` linuxfever
2012-02-26 21:22     ` Stefan Monnier
2012-02-26 10:17 ` Dani Moncayo
2012-02-27 10:58   ` Juri Linkov
2012-02-27 13:27     ` Dani Moncayo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5knpm4r.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=10885-done@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).