From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#1806: dired-pop-to-buffer in wrong place Date: Thu, 04 Oct 2012 02:29:57 +0300 Organization: JURTA Message-ID: <87y5jnqmma.fsf@mail.jurta.org> References: <87r63gzcap.fsf@jurta.org> <505DBC23.5040907@gmx.at> <87y5k1lhn6.fsf@mail.jurta.org> <505ED4BB.3030103@gmx.at> <87txunj0ej.fsf@mail.jurta.org> <50602A8D.6010203@gmx.at> <8739261q8h.fsf@mail.jurta.org> <5061807D.1010401@gmx.at> <87pq59z3nr.fsf@mail.jurta.org> <5062C173.3050402@gmx.at> <87r4ppxfgm.fsf@mail.jurta.org> <5062E0FA.50701@gmx.at> <87sja3rj1p.fsf@mail.jurta.org> <50648DAF.5070409@gmx.at> <87d317l15d.fsf@mail.jurta.org> <50654463.2010008@gmx.at> <87bogqbgci.fsf@mail.jurta.org> <5065A2A0.1000302@gmx.at> <87k3ve5fs6.fsf@mail.jurta.org> <5068234C.1020600@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349402048 26453 80.91.229.3 (5 Oct 2012 01:54:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Oct 2012 01:54:08 +0000 (UTC) Cc: 1806@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 05 03:54:10 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TJx5M-0006Y7-CT for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Oct 2012 03:52:16 +0200 Original-Received: from localhost ([::1]:33980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJZ3r-0005TA-1q for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Oct 2012 20:13:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJZ3n-0005S5-IL for bug-gnu-emacs@gnu.org; Wed, 03 Oct 2012 20:13:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJZ3l-0003eE-EB for bug-gnu-emacs@gnu.org; Wed, 03 Oct 2012 20:13:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJZ3l-0003eA-AZ for bug-gnu-emacs@gnu.org; Wed, 03 Oct 2012 20:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TJZ3m-000381-VS for bug-gnu-emacs@gnu.org; Wed, 03 Oct 2012 20:13:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Oct 2012 00:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1806 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 1806-submit@debbugs.gnu.org id=B1806.134930956111982 (code B ref 1806); Thu, 04 Oct 2012 00:13:02 +0000 Original-Received: (at 1806) by debbugs.gnu.org; 4 Oct 2012 00:12:41 +0000 Original-Received: from localhost ([127.0.0.1]:51948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TJZ3Q-000378-E6 for submit@debbugs.gnu.org; Wed, 03 Oct 2012 20:12:41 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:34814 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TJZ3N-00036y-Hj for 1806@debbugs.gnu.org; Wed, 03 Oct 2012 20:12:38 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id EDB7C451CCBF; Wed, 3 Oct 2012 17:12:33 -0700 (PDT) In-Reply-To: <5068234C.1020600@gmx.at> (martin rudalics's message of "Sun, 30 Sep 2012 12:47:40 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65208 Archived-At: >>> Anyone who wants the nil behavior for `dired-shrink-to-fit' can add a >>> corresponding entry to `display-buffer-alist' as you proposed earlier. >> >> This means that `dired-shrink-to-fit' could be marked obsolete? > > I think so. > >>> (Someone would have to formulate that for users nicely and in the >>> appropriate context.) Do you think this is a good formulation: === modified file 'lisp/dired.el' --- lisp/dired.el 2012-09-30 12:11:18 +0000 +++ lisp/dired.el 2012-10-03 23:28:07 +0000 @@ -248,6 +248,10 @@ (defvar dired-shrink-to-fit t ;; I see no reason ever to make this nil -- rms. ;; (> baud-rate search-slow-speed) "Non-nil means Dired shrinks the display buffer to fit the marked files.") +(make-obsolete-variable 'dired-shrink-to-fit + "use the Customization interface to add a new rule +to `display-buffer-alist' where condition regexp is \"Marked Files\", +action argument symbol is `window-height' and its value is nil." "24.3") (defvar dired-file-version-alist) @@ -2940,6 +2943,7 @@ (defun dired-mark-prompt (arg files) (defun dired-pop-to-buffer (buf) "Pop up buffer BUF in a way suitable for Dired." + (declare (obsolete dired-mark-pop-up "24.3")) (let ((split-window-preferred-function (lambda (window) (or (and (let ((split-height-threshold 0)) @@ -2981,6 +2985,11 @@ (defun dired-mark-pop-up (buffer-or-name window is not shown if there is just one file, `dired-no-confirm' is t, or OP-SYMBOL is a member of the list in `dired-no-confirm'. +By default Dired shrinks the display buffer to fit the marked files. +To disable this, use the Customization interface to add a new rule +to `display-buffer-alist' where condition regexp is \"Marked Files\", +action argument symbol is `window-height' and its value is nil. + FILES is the list of marked files. It can also be (t FILENAME) in the case of one marked file, to distinguish that from using just the current file. PS: Also I noticed that there are no new actions in the Customization interface for `display-buffer-alist'. I guess you omitted the action `display-buffer-at-bottom' because it's not yet ready for prime time. But is there a reason to not add `display-buffer-below-selected' to `display-buffer--action-function-custom-type'?