unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 9803@debbugs.gnu.org
Subject: bug#9803: [PATCH] Add ERT option to skip test
Date: Mon, 21 Oct 2013 19:02:00 +0200	[thread overview]
Message-ID: <87y55m36d3.fsf@gmx.de> (raw)
In-Reply-To: <jwviowq600x.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Mon, 21 Oct 2013 12:53:14 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I've tried to change it as proposed by Stefan, but I'm too stupid to
>> manage all this sophisticated cl-* stuff :-(
>
> What have you tried and how did it fail?

I've tried a kind of `letf'; this failed because it replaces only
function calls of functions which exist already. Does not work, because
`skip-if' shall not exist.

Then I did traverse `remaining' in `ert--parse-keys-and-body', replacing all
`skip-if' occurences in the car's by `ert--skip-if'. This did work
somehow, but only if `skip-if' is called on the top-level of the body of
an ert test. Parsing the whole structure might be possible, but I don't
know a respective function/macro, and writing an own recursive parsing
seems to expensive to me.

>         Stefan

Best regards, Michael.





  reply	other threads:[~2013-10-21 17:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20  3:42 bug#9803: Add ERT option to skip test Glenn Morris
2013-07-04 18:40 ` Michael Albinus
2013-10-18 13:37 ` bug#9803: [PATCH] " Michael Albinus
2013-10-19  1:02   ` Glenn Morris
2013-10-19  2:12     ` Stefan Monnier
2013-10-19  6:44       ` Michael Albinus
2013-10-19  6:44     ` Michael Albinus
2013-10-20  2:02       ` Glenn Morris
2013-10-20 14:09     ` Michael Albinus
2013-10-21 15:08       ` Michael Albinus
2013-10-21 16:53         ` Stefan Monnier
2013-10-21 17:02           ` Michael Albinus [this message]
2013-10-21 19:23             ` Stefan Monnier
2013-10-22  8:23               ` Michael Albinus
2013-10-23 12:21                 ` Michael Albinus
2013-10-24  7:46                   ` Michael Albinus
2013-10-24  8:00                     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y55m36d3.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=9803@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).