From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenjiro NAKAYAMA Newsgroups: gmane.emacs.bugs Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field. Date: Sun, 15 Dec 2013 01:18:54 +0900 Message-ID: <87y53ncsnl.fsf@dhcp-193-97.nrt.redhat.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387038011 4951 80.91.229.3 (14 Dec 2013 16:20:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Dec 2013 16:20:11 +0000 (UTC) Cc: Nakayama Kenjiro , 16141@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 14 17:20:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vrrwu-0002hh-QC for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Dec 2013 17:20:17 +0100 Original-Received: from localhost ([::1]:47784 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrrwu-00012d-Ay for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Dec 2013 11:20:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrrwn-00010T-6A for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 11:20:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vrrwi-0001UL-3y for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 11:20:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrrwh-0001T9-Vk for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 11:20:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vrrwh-0008LR-4U for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 11:20:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Dec 2013 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16141-submit@debbugs.gnu.org id=B16141.138703794531984 (code B ref 16141); Sat, 14 Dec 2013 16:20:02 +0000 Original-Received: (at 16141) by debbugs.gnu.org; 14 Dec 2013 16:19:05 +0000 Original-Received: from localhost ([127.0.0.1]:50214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrrvk-0008Jn-Ds for submit@debbugs.gnu.org; Sat, 14 Dec 2013 11:19:05 -0500 Original-Received: from mail-pb0-f47.google.com ([209.85.160.47]:51046) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrrvg-0008JL-Ns for 16141@debbugs.gnu.org; Sat, 14 Dec 2013 11:19:01 -0500 Original-Received: by mail-pb0-f47.google.com with SMTP id um1so3787992pbc.20 for <16141@debbugs.gnu.org>; Sat, 14 Dec 2013 08:18:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; bh=cxYiGhJ2Opw2t+aCf6sHqGXCGx2tvC5echEkrjYBqAo=; b=lCp2a4W/DV0zRNMt8fXYnXwQfEKDLNzgNe5t8djVUoswKC5tHptX6CIPxlLXZn9NCg CwCiHbYwQwP4AMe+jL4pQnoA3jvkU19j5/iL/amK+2nMreEcD9oCpqph4+l2iylV+LRW oo1RsoYXosZXKTbiFTIDrTngr4uTT8YQ2doWhc3YudI3rGT0IzcqeIQ2WceKgqd/Dnnv vxqChx/MrsfWX8LU2EmQPzmU2bkX+eU7BrrwN0uEiw7Gdv1fhXScMQJwfOhw9onmKFnm WRPCbFPpg+AE/9HCzpSVqWRpU9MNE/rq7NdXxwDUcd/ME+Lf2Q7El1SDzXxB7jL+eyEn uRRg== X-Received: by 10.68.173.132 with SMTP id bk4mr1109701pbc.169.1387037939725; Sat, 14 Dec 2013 08:18:59 -0800 (PST) Original-Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com. [66.187.238.10]) by mx.google.com with ESMTPSA id gv10sm13357429pbd.0.2013.12.14.08.18.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Dec 2013 08:18:58 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.2 In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81963 Archived-At: > Such comments should describe what the change *does* rather than what it > *did*, i.e. use the present tense (and capitalize the word after the > colon since it starts a sentence). Thank you Stefan. I resend patch with a fixed comment. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-tag-select): Add text-property to jump to next select field. --- lisp/net/eww.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 1693e74..0264174 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -841,7 +841,8 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input[1]'.") (put-text-property start (point) 'eww-form menu) (add-face-text-property start (point) 'eww-form-select) (put-text-property start (point) 'keymap eww-select-map) - (put-text-property start (1+ start) 'help-echo "select field") + (unless (= start (point)) + (put-text-property start (1+ start) 'help-echo "select field")) (shr-ensure-paragraph)))) (defun eww-select-display (select) -- 1.8.3.1 monnier@IRO.UMontreal.CA writes: >> It is useful, if we can jump to next select fiedld with tab commadn. >> Signed-off-by: Kenjiro NAKAYAMA > > Thank you for your patch. I'll let the EWW maintainers decide what to > do with it, but I just wanted to point out: > >> * net/eww.el (eww-tag-select): added text-property to jump to >> next select field. > > Such comments should describe what the change *does* rather than what it > *did*, i.e. use the present tense (and capitalize the word after the > colon since it starts a sentence). > > > Stefan