* bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
@ 2013-12-14 12:05 Nakayama Kenjiro
2013-12-14 14:22 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Nakayama Kenjiro @ 2013-12-14 12:05 UTC (permalink / raw)
To: 16141
It is useful, if we can jump to next select fiedld with tab commadn.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el (eww-tag-select): added text-property to jump to
next select field.
---
lisp/net/eww.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 1693e74..0264174 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -841,7 +841,8 @@ See URL
`https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.")
(put-text-property start (point) 'eww-form menu)
(add-face-text-property start (point) 'eww-form-select)
(put-text-property start (point) 'keymap eww-select-map)
- (put-text-property start (1+ start) 'help-echo "select field")
+ (unless (= start (point))
+ (put-text-property start (1+ start) 'help-echo "select field"))
(shr-ensure-paragraph))))
(defun eww-select-display (select)
--
1.8.3.1
Kenjiro
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
2013-12-14 12:05 bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field Nakayama Kenjiro
@ 2013-12-14 14:22 ` Stefan Monnier
2013-12-14 16:18 ` Kenjiro NAKAYAMA
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2013-12-14 14:22 UTC (permalink / raw)
To: Nakayama Kenjiro; +Cc: 16141
> It is useful, if we can jump to next select fiedld with tab commadn.
> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
Thank you for your patch. I'll let the EWW maintainers decide what to
do with it, but I just wanted to point out:
> * net/eww.el (eww-tag-select): added text-property to jump to
> next select field.
Such comments should describe what the change *does* rather than what it
*did*, i.e. use the present tense (and capitalize the word after the
colon since it starts a sentence).
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
2013-12-14 14:22 ` Stefan Monnier
@ 2013-12-14 16:18 ` Kenjiro NAKAYAMA
2013-12-21 20:48 ` Ted Zlatanov
0 siblings, 1 reply; 6+ messages in thread
From: Kenjiro NAKAYAMA @ 2013-12-14 16:18 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Nakayama Kenjiro, 16141
> Such comments should describe what the change *does* rather than what it
> *did*, i.e. use the present tense (and capitalize the word after the
> colon since it starts a sentence).
Thank you Stefan.
I resend patch with a fixed comment.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el (eww-tag-select): Add text-property to jump to
next select field.
---
lisp/net/eww.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 1693e74..0264174 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -841,7 +841,8 @@ See URL
`https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input[1]'.")
(put-text-property start (point) 'eww-form menu)
(add-face-text-property start (point) 'eww-form-select)
(put-text-property start (point) 'keymap eww-select-map)
- (put-text-property start (1+ start) 'help-echo "select field")
+ (unless (= start (point))
+ (put-text-property start (1+ start) 'help-echo "select field"))
(shr-ensure-paragraph))))
(defun eww-select-display (select)
--
1.8.3.1
monnier@IRO.UMontreal.CA writes:
>> It is useful, if we can jump to next select fiedld with tab commadn.
>> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
>
> Thank you for your patch. I'll let the EWW maintainers decide what to
> do with it, but I just wanted to point out:
>
>> * net/eww.el (eww-tag-select): added text-property to jump to
>> next select field.
>
> Such comments should describe what the change *does* rather than what it
> *did*, i.e. use the present tense (and capitalize the word after the
> colon since it starts a sentence).
>
>
> Stefan
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
2013-12-14 16:18 ` Kenjiro NAKAYAMA
@ 2013-12-21 20:48 ` Ted Zlatanov
2013-12-22 1:56 ` Kenjiro NAKAYAMA
0 siblings, 1 reply; 6+ messages in thread
From: Ted Zlatanov @ 2013-12-21 20:48 UTC (permalink / raw)
To: Kenjiro NAKAYAMA, Lars Magne Ingebrigtsen; +Cc: 16141
On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> wrote:
>> Such comments should describe what the change *does* rather than what it
>> *did*, i.e. use the present tense (and capitalize the word after the
>> colon since it starts a sentence).
KN> Thank you Stefan.
KN> I resend patch with a fixed comment.
KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
KN> * net/eww.el (eww-tag-select): Add text-property to jump to
KN> next select field.
It doesn't apply cleanly anymore, sorry. Can you rebase and resend?
Thanks
Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
2013-12-21 20:48 ` Ted Zlatanov
@ 2013-12-22 1:56 ` Kenjiro NAKAYAMA
2013-12-22 22:41 ` Ted Zlatanov
0 siblings, 1 reply; 6+ messages in thread
From: Kenjiro NAKAYAMA @ 2013-12-22 1:56 UTC (permalink / raw)
To: Ted Zlatanov; +Cc: Lars Magne Ingebrigtsen, Kenjiro NAKAYAMA, 16141
> It doesn't apply cleanly anymore, sorry. Can you rebase and resend?
Sorry, it's my mistake. This is proper patch.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el (eww-tag-select): Add text-property to jump to
next select field.
---
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 15bb2c0..cd59380 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -847,6 +847,8 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/
(put-text-property start (point) 'eww-form menu)
(add-face-text-property start (point) 'eww-form-select)
(put-text-property start (point) 'keymap eww-select-map)
+ (unless (= start (point))
+ (put-text-property start (1+ start) 'help-echo "select field"))
(shr-ensure-paragraph))))
(defun eww-select-display (select)
--
Kenjiro NAKAYAMA
tzz@lifelogs.com writes:
> On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> wrote:
>
>>> Such comments should describe what the change *does* rather than what it
>>> *did*, i.e. use the present tense (and capitalize the word after the
>>> colon since it starts a sentence).
>
> KN> Thank you Stefan.
>
> KN> I resend patch with a fixed comment.
>
> KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
>
> KN> * net/eww.el (eww-tag-select): Add text-property to jump to
> KN> next select field.
>
> It doesn't apply cleanly anymore, sorry. Can you rebase and resend?
>
> Thanks
> Ted
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
2013-12-22 1:56 ` Kenjiro NAKAYAMA
@ 2013-12-22 22:41 ` Ted Zlatanov
0 siblings, 0 replies; 6+ messages in thread
From: Ted Zlatanov @ 2013-12-22 22:41 UTC (permalink / raw)
To: Kenjiro NAKAYAMA; +Cc: Lars Magne Ingebrigtsen, 16141-done
On Sun, 22 Dec 2013 10:56:53 +0900 Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> wrote:
>> It doesn't apply cleanly anymore, sorry. Can you rebase and resend?
KN> Sorry, it's my mistake. This is proper patch.
KN> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
KN> * net/eww.el (eww-tag-select): Add text-property to jump to
KN> next select field.
Applied, thank you.
Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-22 22:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14 12:05 bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field Nakayama Kenjiro
2013-12-14 14:22 ` Stefan Monnier
2013-12-14 16:18 ` Kenjiro NAKAYAMA
2013-12-21 20:48 ` Ted Zlatanov
2013-12-22 1:56 ` Kenjiro NAKAYAMA
2013-12-22 22:41 ` Ted Zlatanov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).