From: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Nakayama Kenjiro <nakayamakenjiro@gmail.com>, 16141@debbugs.gnu.org
Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
Date: Sun, 15 Dec 2013 01:18:54 +0900 [thread overview]
Message-ID: <87y53ncsnl.fsf@dhcp-193-97.nrt.redhat.com> (raw)
In-Reply-To: <jwvsitvzf7g.fsf-monnier+emacsbugs@gnu.org>
> Such comments should describe what the change *does* rather than what it
> *did*, i.e. use the present tense (and capitalize the word after the
> colon since it starts a sentence).
Thank you Stefan.
I resend patch with a fixed comment.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el (eww-tag-select): Add text-property to jump to
next select field.
---
lisp/net/eww.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 1693e74..0264174 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -841,7 +841,8 @@ See URL
`https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input[1]'.")
(put-text-property start (point) 'eww-form menu)
(add-face-text-property start (point) 'eww-form-select)
(put-text-property start (point) 'keymap eww-select-map)
- (put-text-property start (1+ start) 'help-echo "select field")
+ (unless (= start (point))
+ (put-text-property start (1+ start) 'help-echo "select field"))
(shr-ensure-paragraph))))
(defun eww-select-display (select)
--
1.8.3.1
monnier@IRO.UMontreal.CA writes:
>> It is useful, if we can jump to next select fiedld with tab commadn.
>> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
>
> Thank you for your patch. I'll let the EWW maintainers decide what to
> do with it, but I just wanted to point out:
>
>> * net/eww.el (eww-tag-select): added text-property to jump to
>> next select field.
>
> Such comments should describe what the change *does* rather than what it
> *did*, i.e. use the present tense (and capitalize the word after the
> colon since it starts a sentence).
>
>
> Stefan
next prev parent reply other threads:[~2013-12-14 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 12:05 bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field Nakayama Kenjiro
2013-12-14 14:22 ` Stefan Monnier
2013-12-14 16:18 ` Kenjiro NAKAYAMA [this message]
2013-12-21 20:48 ` Ted Zlatanov
2013-12-22 1:56 ` Kenjiro NAKAYAMA
2013-12-22 22:41 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y53ncsnl.fsf@dhcp-193-97.nrt.redhat.com \
--to=nakayamakenjiro@gmail.com \
--cc=16141@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).