From: Juri Linkov <juri@jurta.org>
To: Leo Liu <sdl.web@gmail.com>
Cc: 17695@debbugs.gnu.org
Subject: bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme
Date: Thu, 05 Jun 2014 03:39:04 +0300 [thread overview]
Message-ID: <87y4xcdv4o.fsf@mail.jurta.org> (raw)
In-Reply-To: <m3tx802otw.fsf@gmail.com> (Leo Liu's message of "Thu, 05 Jun 2014 08:16:11 +0800")
> Note: this bug doesn't happen in emacs 24.3.
>
> 1. emacs -Q
> 2. M-x load-theme RET deeper-blue RET
> 3. open a patch in diff-mode.
>
> Face: diff-added (sample) (customize this face)
>
> Documentation:
> `diff-mode' face used to highlight added lines.
>
> Defined in `diff-mode.el'.
>
> Family: unspecified
> Foundry: unspecified
> Width: unspecified
> Height: unspecified
> Weight: unspecified
> Slant: unspecified
> Foreground: unspecified
> DistantForeground: unspecified
> Background: unspecified
> Underline: unspecified
> Overline: unspecified
> Strike-through: unspecified
> Box: unspecified
> Inverse: unspecified
> Stipple: unspecified
> Font: unspecified
> Fontset: unspecified
> Inherit: unspecified
This patch should fix it:
=== modified file 'etc/themes/deeper-blue-theme.el'
--- etc/themes/deeper-blue-theme.el 2014-01-01 07:43:34 +0000
+++ etc/themes/deeper-blue-theme.el 2014-06-05 00:38:30 +0000
@@ -40,8 +40,8 @@ (let ((class '((class color) (min-colors
`(cperl-hash-face ((,class (:foreground "coral1"))))
`(cursor ((,class (:background "green"))))
`(default ((,class (:background "#181a26" :foreground "gray80"))))
- `(diff-added ((,class (nil))))
- `(diff-changed ((,class (nil))))
+ `(diff-added ((,class (:inherit diff-indicator-added))))
+ `(diff-changed ((,class (:inherit diff-indicator-changed))))
`(diff-context ((,class (:foreground "seashell4"))))
`(diff-file-header ((,class (:background "grey60"))))
`(diff-function ((,class (:inherit diff-header))))
@@ -52,7 +52,7 @@ (let ((class '((class color) (min-colors
`(diff-indicator-changed ((,class (:foreground "white" :background "dodgerblue4"))))
`(diff-indicator-removed ((,class (:foreground "white" :background "indianred4"))))
`(diff-refine-change ((,class (:background "skyblue4"))))
- `(diff-removed ((,class (nil))))
+ `(diff-removed ((,class (:inherit diff-indicator-removed))))
`(dired-marked ((,class (:background "dodgerblue3" :foreground "white"))))
`(ediff-current-diff-A ((,class (:background "green4" :foreground "white"))))
`(ediff-current-diff-B ((,class (:background "darkorange3" :foreground "white"))))
next prev parent reply other threads:[~2014-06-05 0:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 0:16 bug#17695: 24.3.91; [REGRESSION] face diff-added disappears in deeper-blue theme Leo Liu
2014-06-05 0:39 ` Juri Linkov [this message]
2014-06-05 2:32 ` Leo Liu
2014-06-05 23:33 ` Juri Linkov
2014-06-06 9:28 ` Leo Liu
2014-06-06 23:07 ` Juri Linkov
2014-06-05 1:09 ` Glenn Morris
2014-06-05 2:40 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4xcdv4o.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=17695@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).