From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.bugs Subject: bug#19711: 25.0.50; (ad-is-adviced sym) is inconsistent with (advice--p (advice--symbol-function sym)) Date: Wed, 28 Jan 2015 14:55:01 +0100 Message-ID: <87y4on57t6.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1422453559 9468 80.91.229.3 (28 Jan 2015 13:59:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Jan 2015 13:59:19 +0000 (UTC) To: 19711@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 28 14:59:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YGT9I-0006jW-PW for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Jan 2015 14:59:17 +0100 Original-Received: from localhost ([::1]:53663 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGT9C-0002RV-82 for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Jan 2015 08:59:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGT98-0002Qe-FM for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 08:59:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGT94-0000bR-9H for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 08:59:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGT94-0000bN-5Z for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 08:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YGT93-0004gL-KR for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 08:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Oleh Krehel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jan 2015 13:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19711 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142245353717972 (code B ref -1); Wed, 28 Jan 2015 13:59:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Jan 2015 13:58:57 +0000 Original-Received: from localhost ([127.0.0.1]:58592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGT8x-0004fm-Cf for submit@debbugs.gnu.org; Wed, 28 Jan 2015 08:58:56 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41026) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGT8s-0004fU-BR for submit@debbugs.gnu.org; Wed, 28 Jan 2015 08:58:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGT8m-0000YW-83 for submit@debbugs.gnu.org; Wed, 28 Jan 2015 08:58:44 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:44975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGT8m-0000YS-59 for submit@debbugs.gnu.org; Wed, 28 Jan 2015 08:58:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGT8l-0002F1-C2 for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 08:58:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGT8g-0000Wz-90 for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 08:58:43 -0500 Original-Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:61384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGT8g-0000Wv-1S for bug-gnu-emacs@gnu.org; Wed, 28 Jan 2015 08:58:38 -0500 Original-Received: by mail-wg0-f50.google.com with SMTP id b13so20669226wgh.9 for ; Wed, 28 Jan 2015 05:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=6bo15gOSUGrOYM7k9foBXnQHmqIw3SVK25sqVGdqLwk=; b=K22vy6tZXtWWZkaWB20eYnK7DFcHcJgTaipKe486FeCxvfp3Wv2A3k63euZyE1sdx3 zV+cF8SLznO2Alyq7LQ5WNeszNpmZKpaRMPP2Nwtm1AX+rvSnDaF+QwciOtyMaUFRooQ 1oyc1otvyUmyBFEhrITW12VzZJD7ZmBvnJSovzxFxmO9mUXnnaxENxlcACnKqpmyzd0Z LR4Ngl/D1V3pM4+vaauZZ62ef1lheeNpX36/m5vUcYilIHShWCr2G2Cr4S0YgyXryszV aXE4b0cUejCzqck7McYT4Z+St5h6adVc4WYyx7e2jStK2COx2dRR7r0CMwtAf6QptiO6 bBLQ== X-Received: by 10.180.211.2 with SMTP id my2mr7278195wic.3.1422453517170; Wed, 28 Jan 2015 05:58:37 -0800 (PST) Original-Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by mx.google.com with ESMTPSA id i4sm6228810wje.20.2015.01.28.05.58.36 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 28 Jan 2015 05:58:36 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98832 Archived-At: `ad-is-adviced' expands to: (get 'foo 'ad-advice-info) This code will not detect if the function `foo' is being instrumented with `elp-instrument-package' (which is a form of advice). On the other hand, this code from `advice-remove' will work: (advice--p (advice--symbol-function 'foo)) To summarize, functions instrumented by elp aren't recognized as adviced by `ad-is-advised', even though :around advice: even shows up in the docstring. A fix could be to change `ad-is-adviced' to expand to either (or (get 'foo 'ad-advice-info) (get 'foo 'elp-info)) or (advice--p (advice--symbol-function 'foo))