From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word Date: Sun, 05 Jun 2016 11:18:46 +0200 Message-ID: <87y46km1s9.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1465118430 22093 80.91.229.3 (5 Jun 2016 09:20:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 Jun 2016 09:20:30 +0000 (UTC) To: 23695@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 05 11:20:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b9UED-0000yF-4p for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jun 2016 11:20:17 +0200 Original-Received: from localhost ([::1]:36202 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UEC-0007I0-9J for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jun 2016 05:20:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UE5-0007ER-3v for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:20:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9UDz-0008SV-2q for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:20:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UDy-0008SR-Vy for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b9UDy-0003qf-PV for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2016 09:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.146511834714706 (code B ref -1); Sun, 05 Jun 2016 09:20:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Jun 2016 09:19:07 +0000 Original-Received: from localhost ([127.0.0.1]:54882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9UD5-0003p8-E5 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:19:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9UD4-0003oe-2G for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:19:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9UCx-0008NJ-S6 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:19:00 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:40322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UCx-0008ND-Ow for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:18:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UCv-0007AK-Dm for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:18:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9UCp-0008M1-Dk for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:18:56 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:50311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UCp-0008Lu-2v for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:18:51 -0400 Original-Received: from rosalinde ([89.245.71.113]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LfkUs-1boZJ73sOg-00pNKV for ; Sun, 05 Jun 2016 11:18:48 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) X-Provags-ID: V03:K0:BFqVnjhTvJQ37jz2hsqeWR6XleuLlpmqxRcqm4nUT+W/MlBWxtk M3IaZ9XUEOyTWITGza5hdiUhaHI7MEl8RwOhvL40HGZ0/fpNOwGtKXVFFa1bPibHvfN7CBz ftQVgDHKh+hwN90TnnjjJWLouMvxzYabniW8fA2UrSLnEXhY44Wa87KqbSfJR7UJFUlJlUc OtKoi1jlU9O7ArirHbFvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:2vCupVTzOTQ=:D9Qvs5dEXuCCCbqU+gKQxX V+c42bBCiH/cZ8F1uuUicOTohoRYA1CoyGarI5vhmdMS1w/ZAh0BBeAEh/PKwkTbEmiaVrn+p 6/0TJ/fjfIhgZX/r/zWP5l1Pvm1HjNDnTWWFWU90DtwsZGDNrPdjh97dnRYh84UXWW+sEON7P pLzCh47cfBqj+T9+WBZ4CRUJnAvyHwfcZU6WvfAe2IcrKLPoz4+hGdxacJKDf2WwOTilCwGHf yjRzcox3cIcVcy8lh+IL/De2V4mY4NcXMHsVqh2U+0chZqpfayK2S9kzYj+dd2WZ9Iuq4fyXy QMncQCpw2E2pKdj0ACDBqKqHdXLB3aXTZfBhCwcesNbFGClp+0mRNjPeSi6iYdIPabSXvQxp7 RjmWxgGsgLbrH6sH+J2+EjlZEtHTtqucM+cxiqch5TqgXqHS4rthGZS9SOxZh5pri2Fae/iWL 9RIo1Nax846UapW9CzCUZRqBpyNPYSm6MLLyVK4sLGfXL5fpTRl9gbhfHO2TNs6AAlOGhvAFO NCgtxgvcGbXND/Oe+hiceZe3zgsPTIAND+oSf9idZ8j2nL3zUNhqPLnUg3ruU7wGzli8Qv9pu zGfal/TwcSK42bvj5YGqI7Vd/B4dsBRxmDBB3z3UzS28vKoJZN2h7T9CfDe4lJc72bzl8m4BO I00rW43No51Yc3iq7P2laugZEOqtTnJVaWNFJlB3lw7qhvEKGUHb79qPG903tNhEWW/7Jp1uc Q9ikNmWFfjKNaLip2FgDGzt3kQkVD8QByzP4ocmIK2v7iQjHo7s4MB053e0tKQ84NjJ/oI0V X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119096 Archived-At: 0. emacs -Q 1. Sanity check: Typing e.g. `C-h f url- SPC' should pop up a *Completions* buffer showing functions beginning with "url-", since SPC in the minibuffer is bound to minibuffer-complete-word. 2. C-g to exit the minibuffer, then, if you have no files made by todo-mode (i.e. no directory ~/.emacs.d/todo), type `M-x todo-show RET RET RET RET RET' (accepting defaults) to create a todo file with a category and an entry. 3. Type `q' to quit todo-mode (optional) and redo step 1. => Upon typing SPC this time, instead of getting the *Completions* buffer, a space is inserted in the minibuffer after "url-". If at step 2 you already have one or more todo-files, then invoking a number of todo-mode commands, e.g. `j' to jump to another category or `C a' to add a new category, will likewise globally change the effect of all subsequent uses of SPC in the minibuffer. The patch below fixes this. I request approval to push this fix to emacs-25, since without it, todo-mode-specific behavior changes the minibuffer behavior in rest of Emacs. Also, the fix is certainly safe, since it replaces naively implemented functionality by canonical code to temporarily change a minibuffer key binding. (Since I normally don't use SPC for minibuffer completion but just TAB, I only discovered this bug yesterday, when I was trying and failed to reproduce bug#23670 in a session in which I had already used the broken todo-mode function.) diff --git a/lisp/calendar/todo-mode.el b/lisp/calendar/todo-mode.el index 8e75258..f0d4bc5 100644 --- a/lisp/calendar/todo-mode.el +++ b/lisp/calendar/todo-mode.el @@ -5750,8 +5750,9 @@ todo-read-category against categories in that file; otherwise complete against all categories from `todo-category-completions-files'." ;; Allow SPC to insert spaces, for adding new category names. - (let ((map minibuffer-local-completion-map)) - (define-key map " " nil) + (let ((minibuffer-local-completion-map + (copy-keymap minibuffer-local-completion-map))) + (define-key minibuffer-local-completion-map " " 'self-insert-command) (let* ((add (eq match-type 'add)) (archive (eq match-type 'archive)) (file0 (when (and file (> (length todo-files) 1)) In GNU Emacs 25.0.94.8 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of 2016-06-05 built on rosalinde Repository revision: a5d05f447008c4a99d1b00f0af642b4a5ce4cbce Windowing system distributor 'The X.Org Foundation', version 11.0.11601000 System Description: openSUSE 13.2 (Harlequin) (x86_64) Configured using: 'configure --with-xwidgets 'CFLAGS=-Og -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XWIDGETS Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix