From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Sat, 23 Jul 2016 00:19:00 -0400 Message-ID: <87y44taswb.fsf@users.sourceforge.net> References: <87vb066ejv.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> <834m7l1u8u.fsf@gnu.org> <83shv4z7e8.fsf@gnu.org> <83inw0yw9q.fsf@gnu.org> <87bn1rdd1f.fsf@users.sourceforge.net> <83h9bjzp5i.fsf@gnu.org> <877fcfd79w.fsf@users.sourceforge.net> <83a8hbysmw.fsf@gnu.org> <874m7icwdg.fsf@users.sourceforge.net> <83fur2xjeu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1469247630 6781 80.91.229.3 (23 Jul 2016 04:20:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Jul 2016 04:20:30 +0000 (UTC) Cc: nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, 23917@debbugs.gnu.org, monnier@iro.umontreal.ca, alex.bennee@linaro.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 23 06:20:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQoQC-0008Gy-Io for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Jul 2016 06:20:16 +0200 Original-Received: from localhost ([::1]:50253 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQoQB-0002Jr-4Y for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Jul 2016 00:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQoQ3-0002Iw-D0 for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2016 00:20:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQoPy-0002Mr-Sn for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2016 00:20:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQoPy-0002Mm-PO; Sat, 23 Jul 2016 00:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQoPy-0001TX-Gr; Sat, 23 Jul 2016 00:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Sat, 23 Jul 2016 04:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.14692475465604 (code B ref 23917); Sat, 23 Jul 2016 04:20:02 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 23 Jul 2016 04:19:06 +0000 Original-Received: from localhost ([127.0.0.1]:34136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQoP4-0001SE-8I for submit@debbugs.gnu.org; Sat, 23 Jul 2016 00:19:06 -0400 Original-Received: from mail-qk0-f169.google.com ([209.85.220.169]:36158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQoP2-0001Rg-5G; Sat, 23 Jul 2016 00:19:04 -0400 Original-Received: by mail-qk0-f169.google.com with SMTP id x1so117626881qkb.3; Fri, 22 Jul 2016 21:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mk8PypvaDxgxS4z/qmbt+rWWKfWKoSwWheMFDRadMbA=; b=qksrbPWZoeEINso3LYBn6BjgyEZ+MydkC05tC7LQJNXGSKdoKSKcs3MDHnAXNLI0D9 JDy1ygED8dJp6v1IFAENkGYLje6rYd5bAyJ5fcKFlq7/oGBYSn+iO99Tf8HNBK71RhxX Uif3bBND6l0SpOT57kBgeTlk6PP6xKwMXVOdPaBz5JTRiR5uHu4shqD96EPVj3Ji/m2T Pjwgl5xS69i31YevN9gcZtPa5ezAJdGdHdqoTEa8WzbsXT6Qq72BpzbWkBRyUcfUwW+Y OFnmfcBMsoizQYwUyP9OICKWpAru0qZKWOU4FHTwXUUw/Plt+5RswZv/vEIAJFg7I/by k2HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=mk8PypvaDxgxS4z/qmbt+rWWKfWKoSwWheMFDRadMbA=; b=maNeX8q6NRaRSLVp2SefYNtOCHah455kiLmN4a+VL+wC5zmLQap396zNMjYODg0m0f +z/jso0mHgDhocicOpJpwbW1XKypwXQ3psp6qgSqFcvG+UbygIZqkS/RHFlWZ2baEkLT mo8qc8ZiLpgmait/CV0LFF5qTAkwpUowSZZNWPVdorK9RBzc6P+6UdaJmXRYCWYuiEeg XrKUZtE9IFIK0I7T/SJbl1uHU/BjP5qhuxd9QzAGY7MUo268U3MIVQm9g3cR8K9Ovj1V m474U5lnHlQezbWOS7AVpLQJKC0PoJzJlZsuAU3lxxYpM/wSofV0GFgwBHgEZp1rO3gE Tq0A== X-Gm-Message-State: AEkoouthwdgEJQs+WfPWgNeFcs7IFOpJ1+eSgfEQA4uoXAFJtsUwoQ+3MQCoKEx+SCJelg== X-Received: by 10.55.17.88 with SMTP id b85mr8821674qkh.104.1469247538569; Fri, 22 Jul 2016 21:18:58 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id l129sm9203867qke.27.2016.07.22.21.18.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jul 2016 21:18:57 -0700 (PDT) In-Reply-To: <83fur2xjeu.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Jul 2016 09:43:05 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121436 Archived-At: tags 23917 fixed close 23917 25.1 quit Eli Zaretskii writes: >> From: npostavs@users.sourceforge.net >> Cc: 23917@debbugs.gnu.org, nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, monnier@iro.umontreal.ca, alex.bennee@linaro.org >> Date: Thu, 21 Jul 2016 21:08:43 -0400 >> >> I made the same adjustments to the saved sub_start and sub_end >> variables, but I had a mistake in that adjustment which caused the false >> positives. Fixed in the attached v2 patch. We could just drop the >> check, though I've already found it useful to catch bugs >> (https://github.com/joaotavora/yasnippet/issues/720). >> >> If I drop the checks (see attached v3 patch), then after following the >> bug#23869 recipe, I get: >> >> ## -*- Octave -*- >> -module(bug). >> -export([identity/1, is_even/1, size/1, reverse/1]). > > OK, let's wait for a few days to give time to the people who were > affected by the issue to test the patch, and if no new issues come up, > please push the version with the error code to emacs-25. Since they've now reported that the new patch is working well, I've pushed it as e1def617.