From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#24750: 26.0.50; incorrect Edebug spec for cl-loop Date: Wed, 16 Nov 2016 15:08:35 -0500 Message-ID: <87y40jur0c.fsf@udel.edu> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1479329582 13741 195.159.176.226 (16 Nov 2016 20:53:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Nov 2016 20:53:02 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 24750@debbugs.gnu.org To: Gemini Lasswell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 16 21:52:58 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c77CT-0003F9-Pp for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2016 21:52:57 +0100 Original-Received: from localhost ([::1]:54830 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c77CX-0001FO-2d for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2016 15:53:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c76W4-00075I-CU for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 15:09:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c76Vy-00042Q-NH for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 15:09:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44480) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c76Vy-00042L-JW for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 15:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c76Vy-0007nb-Bx for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 15:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2016 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24750 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24750-submit@debbugs.gnu.org id=B24750.147932692329953 (code B ref 24750); Wed, 16 Nov 2016 20:09:02 +0000 Original-Received: (at 24750) by debbugs.gnu.org; 16 Nov 2016 20:08:43 +0000 Original-Received: from localhost ([127.0.0.1]:59879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c76Vf-0007n2-3M for submit@debbugs.gnu.org; Wed, 16 Nov 2016 15:08:43 -0500 Original-Received: from mail-qk0-f173.google.com ([209.85.220.173]:35694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c76Ve-0007mq-AQ for 24750@debbugs.gnu.org; Wed, 16 Nov 2016 15:08:42 -0500 Original-Received: by mail-qk0-f173.google.com with SMTP id n204so190774979qke.2 for <24750@debbugs.gnu.org>; Wed, 16 Nov 2016 12:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=9uVLNjhIZdkv/AvIZGLb3TQY9krIqU2G2LNy3ZHi08E=; b=wURGerav7kxl9OWAvNI9c2NXfHMRhvPx8pkFVNa1PaoVDtVpacC/LKz7HEVEafGj/7 2pd6px1SqzJkVsRZJ9vZsloejZfK+TPRa0avQlJMJi2HaojRo4bj6x3TLY/9Q8UViq6K p4QFiKIZXP+fyFTML7+mcDS7kpSBDFQbfqO6tY1VmhtIBNoQe82i4PUf2RXVnSzZk6XH nXXpT1YWN5Ar7+UhUQ6qIXrkgZ9kMWKJ4Fe1zsgToqv2TDQma9IrX6z95WpTjB4S/eTr jmRATN52uoryq/JsHMWVhMA2zabcmJcWns33yGo/rF2Ww/ipNCToJc3OP53QjV/J25H4 U6Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=9uVLNjhIZdkv/AvIZGLb3TQY9krIqU2G2LNy3ZHi08E=; b=F6e3jlCVa+T5GKG5bLkMq2H5Skp/rf/DUQHvP4Enh+z6su15FdTJ2rmoXr/jlvFAyl EZ3fEb7x+zW48JiHYusConkQZaKACVlBUQRr+iQByuAe+Ff7B9bF0tXDz7fQ5eCaf6Mh plsoPPOvunn6ZGTkEjTP2ZhgptgaP8jIdNbGK9CQeWVfVL7KhSOCRRDDQ5kEl/GOPht/ Wx3Vx8t+bPBpkeOxRog/kh/7RKlAggki1FeBAYbgBTkv8ZOYekfCkNYUBU0V3rUNjpBS iMBXw1xQrOXSq02ABcqPZf7DpHYFdze4YD1lTnXyPmPPUJ3hk5mwCq6gvarRHGFkiUqe H8Gg== X-Gm-Message-State: AKaTC01yNhO/T3kVJOsdtYlIFA+kEguWoiMgAR3gv9UDBS/2T8N6TXEIt4tJ2rvSsshteJNP X-Received: by 10.55.122.197 with SMTP id v188mr5042988qkc.120.1479326916737; Wed, 16 Nov 2016 12:08:36 -0800 (PST) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id 46sm18583549qtw.6.2016.11.16.12.08.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Nov 2016 12:08:35 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 103B2663B8; Wed, 16 Nov 2016 15:08:35 -0500 (EST) In-Reply-To: (Gemini Lasswell's message of "Thu, 20 Oct 2016 16:28:07 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125769 Archived-At: Gemini Lasswell writes: > The Edebug spec for cl-loop is incorrect, causing an error message when > you try to instrument code that uses a cl-loop "using" clause. To > reproduce, starting at the root of the Emacs source tree: > > 1. emacs -Q > 2. C-x C-f lisp/registry.el RET > 3. M-x edebug-all-defs RET > 4. M-x eval-buffer RET > > Result: Bad =E2=80=98using=E2=80=99 clause > > The error happens during macro expansion of the cl-loop in > registry-search, when it tries to parse a using clause that has > had edebug-before and edebug-after added to it. > > I tried adding: > > ["using" (symbolp symbolp)] > > to the debug spec for cl-loop and that seemed to fix the problem. That fixes the recipe here, but I am not terribly familiar with edebug specs. diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 2ebb824..210a208 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -923,6 +923,7 @@ cl-loop "count" "maximize" "minimize" "if" "unless" "return"] form] + ["using" (symbolp symbolp)] ;; Simple default, which covers 99% of the cases. symbolp form))) (if (not (memq t (mapcar #'symbolp