From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#25391: 24.5; ffap-guesser "stack overflow in regexp matcher" error may crash emacs. Date: Mon, 09 Jan 2017 08:00:35 +0100 Message-ID: <87y3yk67l8.fsf@gmail.com> References: <87vatqc8j1.fsf@gmail.com> <87y3yl1tdp.fsf@users.sourceforge.net> <8760lp8nqv.fsf@gmail.com> <87lgul167v.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1483945274 12036 195.159.176.226 (9 Jan 2017 07:01:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 9 Jan 2017 07:01:14 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 24.5.1 Cc: 25391@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 09 08:01:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQTx6-0002VK-43 for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Jan 2017 08:01:08 +0100 Original-Received: from localhost ([::1]:37457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQTx9-0003Vx-9B for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Jan 2017 02:01:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQTx3-0003VP-NK for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2017 02:01:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQTx0-0005jJ-Nb for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2017 02:01:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cQTx0-0005jB-Kz for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2017 02:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cQTx0-0006Wv-Co for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2017 02:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Jan 2017 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25391 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25391-submit@debbugs.gnu.org id=B25391.148394524725067 (code B ref 25391); Mon, 09 Jan 2017 07:01:02 +0000 Original-Received: (at 25391) by debbugs.gnu.org; 9 Jan 2017 07:00:47 +0000 Original-Received: from localhost ([127.0.0.1]:47368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQTwl-0006WF-Fh for submit@debbugs.gnu.org; Mon, 09 Jan 2017 02:00:47 -0500 Original-Received: from mail-wj0-f177.google.com ([209.85.210.177]:36215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQTwj-0006W1-Al for 25391@debbugs.gnu.org; Mon, 09 Jan 2017 02:00:45 -0500 Original-Received: by mail-wj0-f177.google.com with SMTP id ew7so47166773wjc.3 for <25391@debbugs.gnu.org>; Sun, 08 Jan 2017 23:00:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=ZbjJcWsqtlKPU+7ZTbRtQSFdud8pwQsjR0L4QJS+6sk=; b=bBbUTF4htMqmeSbvinH8PWgfk36HrKbikUvtq3Wp3SIEU4YKNpZtu1z+7/AhQ8xdBN aquRpA+GxiVvvnLJTi87c6m1ytSvIWoPSfYYOS3Z2RejPy2iBL2lXQJmiGHuDOZ3Nz8O +DW2KSM8vN/o+kzTEO9qVSxHdd4wTt0qnMW6S27Y9zbnRf3oKSa1j4S9QZvKt0ec5KgE /vkaIyH0XKWZkqH57kEA/HXPvRWC9dANRZOJrcuOG0i7rVbV7q/4uAe/QavFCbEsIokE EfdvUEFmvhgQHh5pbAqubBtmkONnF/8BCv9YOHmmEhSxKrS82dieq3Sh6U2aqq/EanIz fJ6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=ZbjJcWsqtlKPU+7ZTbRtQSFdud8pwQsjR0L4QJS+6sk=; b=dmq25FXPJkYdNMLHIyzNsNDVGaiFfVn2xI/ltSkGZzD309UJ2HkQYO2bdHG+TQR0gb 5KJA+I0Eb0/rh+sZMxhE7K8C+FpbSL7G4R18xcYcOQurqG4d6iY4VOLKmNaWE9r86Ipb NOCHUynXoCaONp7ZGIIqyHw84pJeR4qnoqsQ7D1yEgjpNf9r6pY3TSwZGgvLGajFFB3l DZvRAnbvLhWotqMLmiVZHXPFosH/JyPgqrY2GCFXWI9wv2ouaO67ImocP5Xp2QQhDjMM iXQKh+ABPwLu+/go7SBzKGNmoWqP8AEnapNhwGW4QjtbkMWrSW+P2YQKAZKxV9sYXGkE a0UQ== X-Gm-Message-State: AIkVDXKYEpDcFN0qACbEpNfnjQtSIppWhnvK6mEb5sGLXNZaZCJYQfd+SesaCZo/bnDUgA== X-Received: by 10.194.117.134 with SMTP id ke6mr64718458wjb.123.1483945239192; Sun, 08 Jan 2017 23:00:39 -0800 (PST) Original-Received: from dell-14z ([37.164.235.156]) by smtp.gmail.com with ESMTPSA id u78sm17106644wma.11.2017.01.08.23.00.37 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 08 Jan 2017 23:00:38 -0800 (PST) In-reply-to: <87lgul167v.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127926 Archived-At: npostavs@users.sourceforge.net writes: > tags 25391 patch > quit > > Thierry Volpiatto writes: >> >> However, this handle the problem with "Stack overflow in regexp matcher" >> generally, but perhaps regexps such as `ffap-gopher-regexp` could be >> avoided when possible in emacs source code. > > Ah, so by "crash" you meant throw an error. I had the both, a crash on emacs-26, emacs taking all memory and finally crashing and on emacs-24.5 "Stack overflow in regexp matcher". > Right, and ffap-gopher-at-point is also using `set' on local variables, > icky. Here's a patch: I don't know `let-alist`, but looks good, however keeping `ffap-gopher-regexp` instead of hardcoding it and returning nil when the regexp is nil would allow users to disable the feature. Thanks. -- Thierry