unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#13808: Gnus gratuiously messes with the encoding of attachments
       [not found]                   ` <87fuk73zpr.fsf@gnus.org>
@ 2017-01-25 15:58                     ` Lars Ingebrigtsen
  2017-01-25 16:26                       ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2017-01-25 15:58 UTC (permalink / raw)
  To: David Kastrup; +Cc: 13808

Lars Ingebrigtsen <larsi@gnus.org> writes:

> The mml encoding code is headache-inducing, probably because it was
> written to support non-Mule and XEmacs and modern Emacs at the same
> time.  So you have stuff like:
>
> (defun mm-find-charset-region (b e)
>   "Return a list of Emacs charsets in the region B to E."
>   (cond
>    ((mm-multibyte-p)
>
> [...]
>
>    (t
>     ;; We are in a unibyte buffer, so we futz around a bit.
>
> [...]
>
> 		      (car (last (assq mail-parse-charset
> 				       mm-mime-mule-charset-alist)))))
> 	    (list 'ascii (or charset 'latin-iso8859-1)))))))))
>
> which is part of what's biting us here.
>
> I wonder whether the best solution here is to just rewrite the mml code
> completely.  There's so much...  magic in the various code paths.

And I think the answer is...  yes.  I'll start rewriting.  Shouldn't be
... that much code, should it?  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#13808: Gnus gratuiously messes with the encoding of attachments
  2017-01-25 15:58                     ` bug#13808: Gnus gratuiously messes with the encoding of attachments Lars Ingebrigtsen
@ 2017-01-25 16:26                       ` Lars Ingebrigtsen
  2017-01-25 16:56                         ` David Kastrup
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2017-01-25 16:26 UTC (permalink / raw)
  To: David Kastrup; +Cc: 13808

Lars Ingebrigtsen <larsi@gnus.org> writes:

> And I think the answer is...  yes.  I'll start rewriting.  Shouldn't be
> ... that much code, should it?  :-)

Not a lot of rewriting was required, really.  *phew*  It now detect
coding systems reliably, and never rewrites file contents.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#13808: Gnus gratuiously messes with the encoding of attachments
  2017-01-25 16:26                       ` Lars Ingebrigtsen
@ 2017-01-25 16:56                         ` David Kastrup
  0 siblings, 0 replies; 3+ messages in thread
From: David Kastrup @ 2017-01-25 16:56 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 13808

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> And I think the answer is...  yes.  I'll start rewriting.  Shouldn't be
>> ... that much code, should it?  :-)
>
> Not a lot of rewriting was required, really.  *phew* It now detect
> coding systems reliably, and never rewrites file contents.

That was quick after the initial delay.  Apparently the partial
handover/retirement of Gmane gave you an opportunity to catch up with
Gnus.

Thanks!

-- 
David Kastrup





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-25 16:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <87ppzp2t1n.fsf@fencepost.gnu.org>
     [not found] ` <87zjtzwu36.fsf@building.gnus.org>
     [not found]   ` <871u7blkuw.fsf@fencepost.gnu.org>
     [not found]     ` <87r4fbvegl.fsf@building.gnus.org>
     [not found]       ` <87wqp3k54g.fsf@fencepost.gnu.org>
     [not found]         ` <m3pputgq1i.fsf@stories.gnus.org>
     [not found]           ` <87zjtxi1f3.fsf@fencepost.gnu.org>
     [not found]             ` <87ppn86hyj.fsf@building.gnus.org>
     [not found]               ` <87d2j86hkm.fsf@building.gnus.org>
     [not found]                 ` <87k3dg4pje.fsf@fencepost.gnu.org>
     [not found]                   ` <87fuk73zpr.fsf@gnus.org>
2017-01-25 15:58                     ` bug#13808: Gnus gratuiously messes with the encoding of attachments Lars Ingebrigtsen
2017-01-25 16:26                       ` Lars Ingebrigtsen
2017-01-25 16:56                         ` David Kastrup

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).