From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.bugs Subject: bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as hex Date: Mon, 29 May 2017 17:47:49 -0700 Message-ID: <87y3tftbka.fsf@SoraLaptop> References: <20170528204250.wjbrm2pul6cf6xam@odonien.localdomain> <83o9ucfl37.fsf@gnu.org> <20170529062859.mwoveygr5oh5iphz@odonien.localdomain> <87y3tfqz6c.fsf@SoraLaptop> <834lw3fnju.fsf@gnu.org> <20170529202021.ax4reeivfvlijkqv@odonien.localdomain> <87o9ubi5fq.fsf@SoraLaptop> <87fufn430m.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1496105292 18612 195.159.176.226 (30 May 2017 00:48:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 May 2017 00:48:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 27122@debbugs.gnu.org, Vasilij Schneidermann To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 30 02:48:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFVKR-0004gA-Vy for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 May 2017 02:48:08 +0200 Original-Received: from localhost ([::1]:51015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFVKX-0003IJ-9J for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 May 2017 20:48:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFVKP-0003ID-Ab for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 20:48:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFVKM-0003pS-8r for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 20:48:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41287) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFVKM-0003pI-4u for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 20:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dFVKL-00081K-Qo for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 20:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2017 00:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27122 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27122-submit@debbugs.gnu.org id=B27122.149610527930822 (code B ref 27122); Tue, 30 May 2017 00:48:01 +0000 Original-Received: (at 27122) by debbugs.gnu.org; 30 May 2017 00:47:59 +0000 Original-Received: from localhost ([127.0.0.1]:43964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFVKI-000813-G8 for submit@debbugs.gnu.org; Mon, 29 May 2017 20:47:58 -0400 Original-Received: from vps28183.inmotionhosting.com ([23.235.221.66]:37146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFVKG-00080q-LP for 27122@debbugs.gnu.org; Mon, 29 May 2017 20:47:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cochranmail.com; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=R+/zIH1Aft7IrBW9b2AT7zjC9qrqcE70lflWgWVIyXI=; b=xGZMuHfv4kC89HQyW+szzpb/a +GEf7AmtBu2WViaLjwJ0dukxCw4lOh8q7ryS+ElpwZ6ABalHzfbMCZC3x1JEhK0VFw/R3KPCvwgQk MQWIs3hKAzQslBfu8pDrhODIEXM0dJ33W6GLuVR5KDmdlKKKvD7vTusrNs3AZuOlJIVHo0Gia2YTa WF5yDpDbj3dNfA32snnVWOFPZrzN5pKf75T0aYOQwMDaFAz7BsmJYYkmJK7FzPKJlCRIgFVP+5R25 Hzh4jFfa1FYq51Kz7tJbg3eIj7HrPxCtZv9edvBhJMI62/nJzDo7BCMzcPgRNllZZGrqduUVwbPm8 kGJkEAvCQ==; Original-Received: from 131-191-86-130.as.clicknet.org ([131.191.86.130]:50542 helo=SoraLaptop) by vps28183.inmotionhosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dFVKA-0004XK-MC; Mon, 29 May 2017 17:47:50 -0700 In-Reply-To: <87fufn430m.fsf@users.sourceforge.net> (npostavs's message of "Mon, 29 May 2017 20:11:37 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps28183.inmotionhosting.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - cochranmail.com X-Get-Message-Sender-Via: vps28183.inmotionhosting.com: authenticated_id: robert@cochranmail.com X-Authenticated-Sender: vps28183.inmotionhosting.com: robert@cochranmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133027 Archived-At: npostavs@users.sourceforge.net writes: > While I'm also okay with changing this to hex display without an option, > I don't think that commit introduced the octal behaviour, it just > changed the implementation. I think these these removed lines used to > do it: > > - /* Insert three more glyphs into IT->ctl_chars for > - the octal display of the character. */ > - g = ((str[i] >> 6) & 7) + '0'; > - XSETINT (it->ctl_chars[i * 4 + 1], g); > - g = ((str[i] >> 3) & 7) + '0'; > - XSETINT (it->ctl_chars[i * 4 + 2], g); > - g = (str[i] & 7) + '0'; > - XSETINT (it->ctl_chars[i * 4 + 3], g); Indeed. I wasn't looking closely enough. I mentally skipped over that part because it was below the new sprintf. My bad, thanks for catching that. -- ~Robert Cochran GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26 AD2D E5C3 EB36 4886 8871